fix #94: detekt fixes

Author: arthurgregorio

config/detekt/detekt.yml

@@ -1,13 +1,13 @@
 complexity:
   CognitiveComplexMethod:
     active: true
-    threshold: 15
+    allowedComplexity: 15
   ComplexCondition:
     active: true
-    threshold: 4
+    allowedConditions: 4
   NestedScopeFunctions:
     active: true
-    threshold: 1
+    allowedDepth: 1
     functions:
       - 'kotlin.apply'
       - 'kotlin.run'
@@ -16,11 +16,14 @@ complexity:
       - 'kotlin.also'
   LongParameterList:
     active: true
-    functionThreshold: 6
-    constructorThreshold: 10
+    allowedFunctionParameters: 6
+    allowedConstructorParameters: 10
     ignoreDefaultParameters: true
     ignoreDataClasses: true
     ignoreAnnotatedParameter: [ Column ]
+  LargeClass:
+    active: true
+    excludes: [ '**/test/**', '**/androidTest/**', '**/commonTest/**', '**/jvmTest/**', '**/androidUnitTest/**', '**/androidInstrumentedTest/**', '**/jsTest/**', '**/iosTest/**' ]
 
 exceptions:
   NotImplementedDeclaration:
@@ -40,9 +43,6 @@ naming:
   BooleanPropertyNaming:
     active: true
     allowedPattern: '^(is|has|are)'
-  FunctionMinLength:
-    active: true
-    minimumFunctionNameLength: 2
   NonBooleanPropertyPrefixedWithIs:
     active: true
 
@@ -100,17 +100,18 @@ style:
     allowedPatterns: ''
   NewLineAtEndOfFile:
     active: false
-  SpacingBetweenPackageAndImports:
-    active: true
   TrailingWhitespace:
     active: true
-  UnusedImports:
+  UnusedImport:
     active: true
+    additionalOperatorSet: []
   ReturnCount:
     active: true
     max: 3
     excludedFunctions:
       - 'equals'
     excludeLabeled: false
     excludeReturnFromLambda: true
-    excludeGuardClauses: true
+    excludeGuardClauses: true
+  WildcardImport:
+    active: true

src/main/kotlin/br/com/webbudget/domain/services/financial/RecurringMovementService.kt

@@ -26,7 +26,9 @@ class RecurringMovementService(
         val externalId = requireNotNull(recurringMovement.externalId) { EXTERNAL_ID_IS_NULL }
 
         recurringMovementRepository.findByExternalIdAndState(externalId, ENDED)
-            ?.let { throw BusinessException("Recurring movement isn't active", "recurring-movement.errors.invalid-state") }
+            ?.let {
+                throw BusinessException("Recurring movement isn't active", "recurring-movement.errors.invalid-state")
+            }
 
         return recurringMovementRepository.merge(recurringMovement)
     }

src/test/kotlin/br/com/webbudget/controllers/UserAccountControllerUTest.kt

@@ -59,7 +59,7 @@ class UserAccountControllerUTest : BaseControllerIntegrationTest() {
             content = body
             with(csrf())
         }.andExpect {
-            status { isUnprocessableEntity() }
+            status { isUnprocessableContent() }
         }
     }
 
@@ -134,7 +134,7 @@ class UserAccountControllerUTest : BaseControllerIntegrationTest() {
             content = body
             with(csrf())
         }.andExpect {
-            status { isUnprocessableEntity() }
+            status { isUnprocessableContent() }
         }
     }
 
@@ -177,7 +177,7 @@ class UserAccountControllerUTest : BaseControllerIntegrationTest() {
             content = body
             with(csrf())
         }.andExpect {
-            status { isUnprocessableEntity() }
+            status { isUnprocessableContent() }
         }
     }
 

src/test/kotlin/br/com/webbudget/controllers/advice/ValidationExceptionController.kt

@@ -29,7 +29,7 @@ class ValidationExceptionController {
         throw MethodArgumentNotValidException(methodParameter, bindingResult)
     }
 
-    @Suppress("UnusedPrivateMember")
+    @Suppress("UnusedPrivateMember", "UnusedParameter")
     fun theMethod(theParameter: String) {
         println("Dummy method")
     }

src/test/kotlin/br/com/webbudget/controllers/financial/PeriodMovementControllerUTest.kt

@@ -206,7 +206,7 @@ class PeriodMovementControllerUTest : BaseControllerIntegrationTest() {
             contentType = MediaType.APPLICATION_JSON
             content = JsonPayload("period-movement/unprocessable")
         }.andExpect {
-            status { isUnprocessableEntity() }
+            status { isUnprocessableContent() }
         }.andReturn()
             .response
             .contentAsString
@@ -236,7 +236,7 @@ class PeriodMovementControllerUTest : BaseControllerIntegrationTest() {
             contentType = MediaType.APPLICATION_JSON
             content = JsonPayload("period-movement/unprocessable")
         }.andExpect {
-            status { isUnprocessableEntity() }
+            status { isUnprocessableContent() }
         }.andReturn()
             .response
             .contentAsString

src/test/kotlin/br/com/webbudget/controllers/financial/RecurringMovementControllerUTest.kt

@@ -189,7 +189,7 @@ class RecurringMovementControllerUTest : BaseControllerIntegrationTest() {
             contentType = MediaType.APPLICATION_JSON
             content = JsonPayload("recurring-movement/unprocessable")
         }.andExpect {
-            status { isUnprocessableEntity() }
+            status { isUnprocessableContent() }
         }.andReturn()
             .response
             .contentAsString
@@ -218,7 +218,7 @@ class RecurringMovementControllerUTest : BaseControllerIntegrationTest() {
             contentType = MediaType.APPLICATION_JSON
             content = JsonPayload("recurring-movement/unprocessable")
         }.andExpect {
-            status { isUnprocessableEntity() }
+            status { isUnprocessableContent() }
         }.andReturn()
             .response
             .contentAsString

src/test/kotlin/br/com/webbudget/controllers/registration/ClassificationControllerUTest.kt

@@ -98,7 +98,7 @@ class ClassificationControllerUTest : BaseControllerIntegrationTest() {
             contentType = MediaType.APPLICATION_JSON
             content = JsonPayload("movement-class/invalid")
         }.andExpect {
-            status { isUnprocessableEntity() }
+            status { isUnprocessableContent() }
         }.andReturn()
             .response
             .contentAsString