fix #77

Author: arthurgregorio

src/test/kotlin/br/com/webbudget/mappers/financial/PeriodMovementMapperUTest.kt

@@ -11,7 +11,6 @@ import br.com.webbudget.application.payloads.financial.PeriodMovementUpdateForm
 import br.com.webbudget.domain.entities.financial.PeriodMovement
 import br.com.webbudget.infrastructure.repository.registration.FinancialPeriodRepository
 import br.com.webbudget.infrastructure.repository.registration.MovementClassRepository
-import br.com.webbudget.utilities.fixture.createApportionment
 import br.com.webbudget.utilities.fixture.createFinancialPeriod
 import br.com.webbudget.utilities.fixture.createMovementClass
 import br.com.webbudget.utilities.fixture.createPeriodMovement
@@ -239,46 +238,4 @@ class PeriodMovementMapperUTest {
 
         confirmVerified(movementClassRepository, financialPeriodRepository)
     }
-
-    @Test
-    fun `should map update form to domain object ignoring null values`() {
-
-        val movementClass = createMovementClass()
-        val financialPeriod = createFinancialPeriod()
-        val apportionments = mutableListOf(createApportionment(movementClass = movementClass))
-
-        val domainObject = createPeriodMovement(financialPeriod = financialPeriod, apportionments = apportionments)
-
-        val form = PeriodMovementUpdateForm(name = "New name")
-
-        periodMovementMapper.mapToDomain(form, domainObject)
-
-        assertThat(domainObject)
-            .isNotNull
-            .satisfies({
-                assertThat(it.name).isEqualTo("New name")
-                assertThat(it.dueDate).isEqualTo(LocalDate.now())
-                assertThat(it.value).isEqualTo(BigDecimal.ONE)
-                assertThat(it.state).isEqualTo(PeriodMovement.State.OPEN)
-                assertThat(it.description).isNull()
-                assertThat(it.financialPeriod).isEqualTo(financialPeriod)
-                assertThat(it.quoteNumber).isNull()
-                assertThat(it.payment).isNull()
-                assertThat(it.creditCardInvoice).isNull()
-                assertThat(it.recurringMovement).isNull()
-            })
-
-        assertThat(domainObject.apportionments)
-            .isNotEmpty
-            .hasSize(1)
-            .satisfiesExactlyInAnyOrder({
-                assertThat(it.value).isEqualTo(apportionments.first().value)
-                assertThat(it.movementClass).isEqualTo(movementClass)
-            })
-
-        verify(exactly = 0) { movementClassRepository.findByExternalId(ofType<UUID>()) }
-        verify(exactly = 0) { financialPeriodRepository.findByExternalId(ofType<UUID>()) }
-
-        confirmVerified(movementClassRepository, financialPeriodRepository)
-    }
 }

src/test/kotlin/br/com/webbudget/mappers/financial/RecurringMovementMapperUTest.kt

@@ -9,7 +9,6 @@ import br.com.webbudget.application.payloads.financial.RecurringMovementCreateFo
 import br.com.webbudget.application.payloads.financial.RecurringMovementUpdateForm
 import br.com.webbudget.domain.entities.financial.RecurringMovement
 import br.com.webbudget.infrastructure.repository.registration.MovementClassRepository
-import br.com.webbudget.utilities.fixture.createApportionment
 import br.com.webbudget.utilities.fixture.createMovementClass
 import br.com.webbudget.utilities.fixture.createRecurringMovement
 import io.mockk.confirmVerified
@@ -202,38 +201,4 @@ class RecurringMovementMapperUTest {
 
         confirmVerified(movementClassRepository)
     }
-
-    @Test
-    fun `should map update form to domain object ignoring null values`() {
-
-        val movementClass = createMovementClass()
-        val apportionments = mutableListOf(createApportionment(movementClass = movementClass))
-
-        val domainObject = createRecurringMovement(apportionments = apportionments)
-
-        val form = RecurringMovementUpdateForm(name = "New name")
-
-        recurringMovementMapper.mapToDomain(form, domainObject)
-
-        assertThat(domainObject)
-            .isNotNull
-            .satisfies({
-                assertThat(it.name).isEqualTo(form.name)
-                assertThat(it.startingAt).isEqualTo(LocalDate.now())
-                assertThat(it.autoLaunch).isTrue()
-                assertThat(it.description).isNull()
-            })
-
-        assertThat(domainObject.apportionments)
-            .isNotEmpty
-            .hasSize(1)
-            .satisfiesExactlyInAnyOrder({
-                assertThat(it.value).isEqualTo(apportionments.first().value)
-                assertThat(it.movementClass).isEqualTo(movementClass)
-            })
-
-        verify(exactly = 0) { movementClassRepository.findByExternalId(ofType<UUID>()) }
-
-        confirmVerified(movementClassRepository)
-    }
 }