env change isn't triggering RSC hot reload or React fast refresh

[sandren]

Vite server restarts, but the Waku app's state isn't updated.

[vite] .env changed, restarting server...
[vite] server restarted.
[vite] connected.

[dai-shi]

@hi-ogawa Do you think it's fixable?

[hi-ogawa]

It's full server restart, so it won't be HMR but browser full reload at best.

Currently Waku CLI only expliictly watch waku.config.ts, but there are other files vite server automatically restarts itself, which are .env and also tsconfig.json. Waku would need to intercept Vite's own server restart to handle it, which is what Astro CLI dev server does if I remember correctly.

waku/packages/waku/src/lib/vite-rsc/cli.ts

Lines 40 to 54 in e4e49d4

	async function handleConfigChange(changedFile: string) {
	const dirname = path.dirname(changedFile);
	const filename = path.basename(changedFile);
	if (
	dirname === process.cwd() &&
	(filename === 'waku.config.ts' || filename === 'waku.config.js')
	) {
	console.log(`Waku configuration file changed, restarting server...`);
	await server.close();
	await startDevServer(host, port, {
	...rscPluginOptions,
	config: await loadConfig(),
	});
	}
	}

[dai-shi]

there are other files vite server automatically restarts itself, which are .env and also tsconfig.json.

I see. What does vite do for restarting. It means it's not enough for waku, right?

to intercept Vite's own server restart to handle it,

sounds like the right direction.

[hi-ogawa]

What does vite do for restarting. It means it's not enough for waku, right?

Yes, I was expecting Vite restarting itself can break Waku since it resets Vte dev server (and all internal plugins) but it doesn't reset Waku plugins.