fix: skinning matrix not getting applied on mesh normals of imported FBX (stride3d#2925)

rmtttt · web-flow · commit b74a54d43314 · 2025-10-13T14:08:11.000+02:00
This is a regression which was introduced in 7b84fed, it basically adds back this line: https://github.com/stride3d/stride/blob/b96860acf82aa80758117aa916a24b0d894b076d/sources/tools/Stride.Importer.FBX/MeshConverter.cpp#L273
diff --git a/sources/tools/Stride.Importer.3D/MeshConverter.cs b/sources/tools/Stride.Importer.3D/MeshConverter.cs
@@ -874,7 +874,10 @@ private unsafe MeshInfo ProcessMesh(Scene* scene, Silk.NET.Assimp.Mesh* mesh, Di
 
                 totalClusterCount = (int)mesh->MNumBones;
                 if (totalClusterCount > 0)
+                {
                     hasSkinningPosition = true;
+                    hasSkinningNormal = mesh->MNormals != null;
+                }
             }
 
             // Build the vertex declaration

Original file line number	Diff line number	Diff line change
`@@ -874,7 +874,10 @@ private unsafe MeshInfo ProcessMesh(Scene* scene, Silk.NET.Assimp.Mesh* mesh, Di`
`874`	`874`
`875`	`875`	`totalClusterCount = (int)mesh->MNumBones;`
`876`	`876`	`if (totalClusterCount > 0)`
	`877`	`+ {`
`877`	`878`	`hasSkinningPosition = true;`
	`879`	`+ hasSkinningNormal = mesh->MNormals != null;`
	`880`	`+ }`
`878`	`881`	`}`
`879`	`882`
`880`	`883`	`// Build the vertex declaration`