[feature request] Improve dark theme setting

[avi12]

After waking up, I opened the app and tried to hunt down the dark theme setting while being blinded by the light theme, until I realized that the setting is managed by two switches. Instead, it should be managed by a drop-down with [Device theme] [Light theme] [Dark theme]

[vmiklos]

Yes, that would be indeed an option. Do you actually use this feature that the app would have a custom "is dark" setting, not following the system theme? My understanding is that this option was primarily added when lots of phones didn't run new enough Android to have a "system dark mode" setting. But possibly these days ~everyone is on new enough Android, and then all these settings can be removed and we can just always use the system dark mode setting.

[avi12]

I'm on Pixel 9 running Android 16, so the OS isn't the issue
the issue is that I close off the blinds before bed and when I wake up, the room is dark and I'd rather the app UI not to blind me when I want to stop the sleep tracking, thus it's always dark

[vmiklos]

OK, I think that's a valid use-case. So makes sense to keep the setting, but simplify it to a 3-way dropdown instead of the current toggle of pairs. The code for the preferences activity is here:

• activity kotlin code: app/src/main/java/hu/vmiklos/plees_tracker/PreferencesActivity.kt
• preferences xml: app/src/main/res/xml/preferences.xml
• mapping from android preferences to user-visible strings: app/src/main/java/hu/vmiklos/plees_tracker/Preferences.kt
• commit 53d6421 (bedtime/wakeup: show the value of these in the preferences activity, 2025-05-09) was somewhat similar

Probably makes sense to keep the underlying Android settings unchanged and just tweak the UI here. Are you interesting in looking into this yourself? Hopefully it's reasonably straightforward with the above code pointers. Thanks.

[avi12]

I'm not proficient in Android development, I'm a web dev