What the comment "it will delete by reclaim" means when meta client removeSession fail?

[iiibui]

nebula/src/graph/session/GraphSessionManager.cpp

Lines 140 to 153 in 544c86b

	void GraphSessionManager::removeSession(SessionID id) {
	auto iter = activeSessions_.find(id);
	if (iter == activeSessions_.end()) {
	return;
	}
	iter->second->markAllQueryKilled();
	auto resp = metaClient_->removeSession(id).get();
	if (!resp.ok()) {
	// it will delete by reclaim
	LOG(ERROR) << "Remove session `" << id << "' failed: " << resp.status();
	}
	activeSessions_.erase(iter);
	}

It means meta client will retry in reclaimExpiredSessions? But it will have no chance because session has been removed from activeSessions_.

It means meta server will do reclaim? But I didn't find any “reclaim” related operations in metad.

[wey-gu]

I agree with you that it will be still erased from activeSessions_ anyway including even the case remove session failed. Thus reclaim won't consider this session anymore.

[yixinglu]

@wey-gu could you open an issue for this session problem?

[wey-gu]

Sure, will create it now.

[yixinglu]

@iiibui you are right! I have checked related implementation, I agree with you and think it's a bug. Could you given a PR to fix it? thanks for this feedback.

[iiibui]

Sorry I can’t give PR at the moment, because I’m working on other things.
It seems that it is simple to redo the removal on graphd, but I think metad should also do “reclaim”, this is a bit troublesome.

[wey-gu]

no worries @iiibui the issue was assigned #3612

thanks~~