py(ruff[N]) Enforce pep8-naming

why: N surfaces identifiers that drift from Python naming norms --
camelCase locals and exception classes without an Error suffix -- which
hurt grep-ability and readability. Enabling it after the exception
renames keeps the rule clean with no suppressions.

what:
- Add "N" to [tool.ruff.lint].select
- Lowercase the module_funcName local in log.py (N806)
- Suffix the test-local _Boom sentinel as _BoomError (N818)

Author: tony

pyproject.toml

@@ -214,6 +214,7 @@ select = [
   "F", # pyflakes
   "I", # isort
   "UP", # pyupgrade
+  "N", # pep8-naming
   "A", # flake8-builtins
   "B", # flake8-bugbear
   "C4", # flake8-comprehensions

src/vcspull/log.py

@@ -295,7 +295,7 @@ def template(self, record: logging.LogRecord) -> str:
             Style.RESET_ALL,
             " ",
         ]
-        module_funcName = [Fore.GREEN, Style.BRIGHT, "%(module)s.%(funcName)s()"]
+        module_func_name = [Fore.GREEN, Style.BRIGHT, "%(module)s.%(funcName)s()"]
         lineno = [
             Fore.BLACK,
             Style.DIM,
@@ -307,7 +307,7 @@ def template(self, record: logging.LogRecord) -> str:
         ]
 
         return "".join(
-            reset + levelname + asctime + name + module_funcName + lineno + reset,
+            reset + levelname + asctime + name + module_func_name + lineno + reset,
         )
 
 

tests/cli/test_sync_watchdog.py

@@ -127,14 +127,14 @@ def test_watchdog_preserves_failed_outcome(
 ) -> None:
     """Synchronous exceptions from ``update_repo`` surface as ``failed``."""
 
-    class _Boom(RuntimeError):
+    class _BoomError(RuntimeError):
         """Sentinel used to trace exception propagation."""
 
     def _raising_update_repo(
         repo: dict[str, t.Any], *, progress_callback: t.Any
     ) -> None:
         msg = "remote exploded"
-        raise _Boom(msg)
+        raise _BoomError(msg)
 
     monkeypatch.setattr(sync_module, "update_repo", _raising_update_repo)
 
@@ -146,7 +146,7 @@ def _raising_update_repo(
     )
 
     assert outcome.status == "failed"
-    assert isinstance(outcome.error, _Boom)
+    assert isinstance(outcome.error, _BoomError)
     assert "remote exploded" in str(outcome.error)