Re-enable SwiftLint rules and refactor for compliance (#5)

* chore: remove logo.png

* refactor: modularize monitoring and animation to satisfy lint

- Re-enable the 200-line type_body_length guard in .swiftlint.yml and document
  the lint policy updates in STANDARDS.md
- Decompose LogMonitor into focused collaborators (state store, watcher
  coordinator, event pipeline, animation tracker, pattern access validator,
  error handler, file watcher bridge, match processor, handler factory) and
  wire them through the app/services/tests
- Extract IconAnimationFrameCalculator and IconAnimationRenderer so IconAnimator
  stays under the class length threshold without losing functionality
- Expand unit coverage for the refactored animation helpers and refresh
  monitoring-related specs to follow the new APIs
- Add new brand assets: 14 logo/icon variants (light/dark, stacked/horizontal,
  transparent/solid backgrounds) in docs/images/
- Update app icon to use icon-only-compact design with light/dark mode support
  (20 icon files generated at all required sizes with appearance variants)
- Add logo to README.md using logo-light-stacked-transparent.png

* fix: mark log monitor as main actor

* fix: stop Claude Code Review from spamming comments on every push

Remove manual gh pr comment instruction that was bypassing the action's
built-in sticky comment feature. Now the action itself handles posting
comments and will update the same comment on subsequent pushes instead
of creating new ones each time.

Changes:
- Remove manual "Use gh pr comment" instruction from prompt
- Remove claude_args with allowed gh tools
- Remove REPO/PR NUMBER context (action provides this automatically)
- Keep use_sticky_comment: true (now actually works)

Author: jamesbrink

.github/workflows/claude-code-review.yml

@@ -38,9 +38,6 @@ jobs:
           claude_code_oauth_token: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }}
           use_sticky_comment: true
           prompt: |
-            REPO: ${{ github.repository }}
-            PR NUMBER: ${{ github.event.pull_request.number }}
-
             Please review this pull request and provide feedback on:
             - Code quality and best practices
             - Potential bugs or issues
@@ -50,9 +47,3 @@ jobs:
 
             Use the repository's CLAUDE.md for guidance on style and conventions. Be constructive and helpful in your feedback.
 
-            Use `gh pr comment` with your Bash tool to leave your review as a comment on the PR.
-
-          # See https://github.com/anthropics/claude-code-action/blob/main/docs/usage.md
-          # or https://docs.claude.com/en/docs/claude-code/cli-reference for available options
-          claude_args: '--allowed-tools "Bash(gh issue view:*),Bash(gh search:*),Bash(gh issue list:*),Bash(gh pr comment:*),Bash(gh pr diff:*),Bash(gh pr view:*),Bash(gh pr list:*)"'
-

.swiftlint.yml

@@ -10,17 +10,23 @@ excluded:
 disabled_rules:
   - file_length
   - todo
-  - type_body_length
-  - function_body_length
-  - redundant_string_enum_value
-  - orphaned_doc_comment
-  - explicit_top_level_acl
 
 opt_in_rules:
   - redundant_type_annotation
   - trailing_comma
   - force_unwrapping # Confirmed for SwiftLint 0.61.0
 
+trailing_comma:
+  mandatory_comma: true
+
+type_body_length:
+  warning: 200
+  error: 300
+
+function_body_length:
+  warning: 50
+  error: 80
+
 line_length:
   warning: 100
   error: 120

README.md

@@ -1,3 +1,7 @@
+<p align="center">
+  <img src="docs/images/logo-light-stacked-transparent.png" alt="Simmer Logo" width="200"/>
+</p>
+
 # Simmer
 
 [![Build](https://github.com/utensils/Simmer/actions/workflows/build.yml/badge.svg?branch=main)](https://github.com/utensils/Simmer/actions/workflows/build.yml)

STANDARDS.md

@@ -24,6 +24,13 @@
 - Explicit `self` only when required
 - Warnings as errors in CI
 - Disabled rules: `line_length` in comments
+- Type bodies should stay under 200 lines (lint warns at 200 and errors at 300)
+- Function bodies should target 50 lines or fewer (lint warns at 50 and errors at 80)
+- Type bodies should stay under 200 lines (lint warns at 200 and errors at 300)
+- Function bodies should target 50 lines or fewer (lint warns at 50 and errors at 80)
+- Trailing commas are required in multiline collection literals
+- Explicit access control is required on all top-level declarations
+- Vertical whitespace is enforced between switch cases
 
 **ShellCheck** for all shell scripts:
 - All `.sh` files must pass `shellcheck` with zero warnings

Simmer/App/AppDelegate.swift

@@ -37,6 +37,7 @@ final class AppDelegate: NSObject, NSApplicationDelegate {
     super.init()
   }
 
+  // swiftlint:disable function_body_length
   func applicationDidFinishLaunching(_ notification: Notification) {
     let configurationPath = ProcessInfo.processInfo.environment["XCTestConfigurationFilePath"]
     let environment = ProcessInfo.processInfo.environment
@@ -106,6 +107,7 @@ final class AppDelegate: NSObject, NSApplicationDelegate {
       }
     }
   }
+  // swiftlint:enable function_body_length
 
   func applicationWillTerminate(_ notification: Notification) {
     logMonitor?.stopAll()

Simmer/Assets.xcassets/AppIcon.appiconset/Contents.json

@@ -6,59 +6,179 @@
       "scale" : "1x",
       "size" : "16x16"
     },
+    {
+      "appearances" : [
+        {
+          "appearance" : "luminosity",
+          "value" : "dark"
+        }
+      ],
+      "filename" : "icon_16x16_dark.png",
+      "idiom" : "mac",
+      "scale" : "1x",
+      "size" : "16x16"
+    },
     {
       "filename" : "[email protected]",
       "idiom" : "mac",
       "scale" : "2x",
       "size" : "16x16"
     },
+    {
+      "appearances" : [
+        {
+          "appearance" : "luminosity",
+          "value" : "dark"
+        }
+      ],
+      "filename" : "icon_16x16@2x_dark.png",
+      "idiom" : "mac",
+      "scale" : "2x",
+      "size" : "16x16"
+    },
     {
       "filename" : "icon_32x32.png",
       "idiom" : "mac",
       "scale" : "1x",
       "size" : "32x32"
     },
+    {
+      "appearances" : [
+        {
+          "appearance" : "luminosity",
+          "value" : "dark"
+        }
+      ],
+      "filename" : "icon_32x32_dark.png",
+      "idiom" : "mac",
+      "scale" : "1x",
+      "size" : "32x32"
+    },
     {
       "filename" : "[email protected]",
       "idiom" : "mac",
       "scale" : "2x",
       "size" : "32x32"
     },
+    {
+      "appearances" : [
+        {
+          "appearance" : "luminosity",
+          "value" : "dark"
+        }
+      ],
+      "filename" : "icon_32x32@2x_dark.png",
+      "idiom" : "mac",
+      "scale" : "2x",
+      "size" : "32x32"
+    },
     {
       "filename" : "icon_128x128.png",
       "idiom" : "mac",
       "scale" : "1x",
       "size" : "128x128"
     },
+    {
+      "appearances" : [
+        {
+          "appearance" : "luminosity",
+          "value" : "dark"
+        }
+      ],
+      "filename" : "icon_128x128_dark.png",
+      "idiom" : "mac",
+      "scale" : "1x",
+      "size" : "128x128"
+    },
     {
       "filename" : "[email protected]",
       "idiom" : "mac",
       "scale" : "2x",
       "size" : "128x128"
     },
+    {
+      "appearances" : [
+        {
+          "appearance" : "luminosity",
+          "value" : "dark"
+        }
+      ],
+      "filename" : "icon_128x128@2x_dark.png",
+      "idiom" : "mac",
+      "scale" : "2x",
+      "size" : "128x128"
+    },
     {
       "filename" : "icon_256x256.png",
       "idiom" : "mac",
       "scale" : "1x",
       "size" : "256x256"
     },
+    {
+      "appearances" : [
+        {
+          "appearance" : "luminosity",
+          "value" : "dark"
+        }
+      ],
+      "filename" : "icon_256x256_dark.png",
+      "idiom" : "mac",
+      "scale" : "1x",
+      "size" : "256x256"
+    },
     {
       "filename" : "[email protected]",
       "idiom" : "mac",
       "scale" : "2x",
       "size" : "256x256"
     },
+    {
+      "appearances" : [
+        {
+          "appearance" : "luminosity",
+          "value" : "dark"
+        }
+      ],
+      "filename" : "icon_256x256@2x_dark.png",
+      "idiom" : "mac",
+      "scale" : "2x",
+      "size" : "256x256"
+    },
     {
       "filename" : "icon_512x512.png",
       "idiom" : "mac",
       "scale" : "1x",
       "size" : "512x512"
     },
+    {
+      "appearances" : [
+        {
+          "appearance" : "luminosity",
+          "value" : "dark"
+        }
+      ],
+      "filename" : "icon_512x512_dark.png",
+      "idiom" : "mac",
+      "scale" : "1x",
+      "size" : "512x512"
+    },
     {
       "filename" : "[email protected]",
       "idiom" : "mac",
       "scale" : "2x",
       "size" : "512x512"
+    },
+    {
+      "appearances" : [
+        {
+          "appearance" : "luminosity",
+          "value" : "dark"
+        }
+      ],
+      "filename" : "icon_512x512@2x_dark.png",
+      "idiom" : "mac",
+      "scale" : "2x",
+      "size" : "512x512"
     }
   ],
   "info" : {