test: relax notification expectation fulfillment

Author: jamesbrink

SimmerTests/MonitoringTests/LogMonitorTests.swift

@@ -67,16 +67,12 @@ internal final class LogMonitorTests: XCTestCase {
     let queue = bundle.queue
 
     let notificationExpectation = expectation(description: "patterns change broadcast")
-    var observer: NSObjectProtocol?
-    observer = notificationCenter.addObserver(
+    notificationExpectation.assertForOverFulfill = false
+    let observer = notificationCenter.addObserver(
       forName: .logMonitorPatternsDidChange,
       object: nil,
       queue: .main
     ) { _ in
-      if let token = observer {
-        notificationCenter.removeObserver(token)
-        observer = nil
-      }
       notificationExpectation.fulfill()
     }
 
@@ -94,6 +90,8 @@ internal final class LogMonitorTests: XCTestCase {
 
     await fulfillment(of: [alertExpectation, notificationExpectation], timeout: 1.0)
 
+    notificationCenter.removeObserver(observer)
+
     let updated = storeRef.loadPatterns().first { $0.id == patternID }
     XCTAssertEqual(updated?.enabled, false)