Skip to content

unclarity/bug when using rails-erb-loader-dependencies directive in non-js files #107

@bertBruynooghe

Description

@bertBruynooghe

I spent quite some time figuring out I needed the following syntax to get dependencies detected for my .html.erb files:

<!-- /* rails-erb-loader-dependencies ... */ -->

I see two solutions:

  1. document this properly
  2. iso. /* rails-erb-loader-dependencies ... */ implement searching for: rails-erb-loader-dependencies (which allows users to use the proper comment syntax for the resulting file, and which is backwards compatible)

It would also be fine if we could support <%# rails-erb-loader-dependencies ... %>, which leaves no traces in the end result, and would also work for stuff that doesn't support comments (e.g. .json.erb)

I am willing to create a PR for this if you decide which of the two solutions you prefer...

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions