Commit f64f576
noun: fix Lagoon argmin/argmax jets to return the forward (ravel) index
The argmin/argmax jets computed the result index as `len_x - i - 1`
(reversed), so the jetted index disagreed with the Hoon (which returns the
forward ravel index of the first extremum) and with the unjetted interpreter
whenever the extremum was not at index 0 -- a silent jet/Hoon mismatch.
Use the forward index `i`. Upstreams the numerics fix (urbit/numerics#29,
already in the numerics master copy but never carried into the runtime).
Verified on a hoon-135 fakezod: for a 3-vector with its min/max at logical
index 2, the jet now returns 2 (was 0), matching the unjetted Hoon.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>1 parent 257dbc2 commit f64f576
1 file changed
Lines changed: 8 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
589 | 589 | | |
590 | 590 | | |
591 | 591 | | |
592 | | - | |
| 592 | + | |
593 | 593 | | |
594 | 594 | | |
595 | 595 | | |
| |||
599 | 599 | | |
600 | 600 | | |
601 | 601 | | |
602 | | - | |
| 602 | + | |
603 | 603 | | |
604 | 604 | | |
605 | 605 | | |
| |||
609 | 609 | | |
610 | 610 | | |
611 | 611 | | |
612 | | - | |
| 612 | + | |
613 | 613 | | |
614 | 614 | | |
615 | 615 | | |
| |||
619 | 619 | | |
620 | 620 | | |
621 | 621 | | |
622 | | - | |
| 622 | + | |
623 | 623 | | |
624 | 624 | | |
625 | 625 | | |
| |||
662 | 662 | | |
663 | 663 | | |
664 | 664 | | |
665 | | - | |
| 665 | + | |
666 | 666 | | |
667 | 667 | | |
668 | 668 | | |
| |||
672 | 672 | | |
673 | 673 | | |
674 | 674 | | |
675 | | - | |
| 675 | + | |
676 | 676 | | |
677 | 677 | | |
678 | 678 | | |
| |||
682 | 682 | | |
683 | 683 | | |
684 | 684 | | |
685 | | - | |
| 685 | + | |
686 | 686 | | |
687 | 687 | | |
688 | 688 | | |
| |||
692 | 692 | | |
693 | 693 | | |
694 | 694 | | |
695 | | - | |
| 695 | + | |
696 | 696 | | |
697 | 697 | | |
698 | 698 | | |
| |||
0 commit comments