Skip to content

Commit 268eaed

Browse files
committed
Fix: metric_cos_gt overflow in tests
1 parent 652a75a commit 268eaed

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

cpp/test.cpp

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
*/
1515
#include <algorithm> // `std::shuffle`
1616
#include <cassert> // `assert`
17+
#include <cmath> // `std::abs`
1718
#include <random> // `std::default_random_engine`
1819
#include <stdexcept> // `std::terminate`
1920
#include <unordered_map> // `std::unordered_map`
@@ -673,16 +674,16 @@ void test_cosine(std::size_t collection_size, std::size_t dimensions) {
673674
scalar_t const* row(std::size_t i) const noexcept { return (*vector_of_vectors_ptr)[i].data(); }
674675

675676
float operator()(member_cref_t const& a, member_cref_t const& b) const {
676-
return metric_cos_gt<scalar_t>{}(row(get_slot(b)), row(get_slot(a)), dimensions);
677+
return metric_cos_gt<scalar_t, float>{}(row(get_slot(b)), row(get_slot(a)), dimensions);
677678
}
678679
float operator()(scalar_t const* some_vector, member_cref_t const& member) const {
679-
return metric_cos_gt<scalar_t>{}(some_vector, row(get_slot(member)), dimensions);
680+
return metric_cos_gt<scalar_t, float>{}(some_vector, row(get_slot(member)), dimensions);
680681
}
681682
float operator()(member_citerator_t const& a, member_citerator_t const& b) const {
682-
return metric_cos_gt<scalar_t>{}(row(get_slot(b)), row(get_slot(a)), dimensions);
683+
return metric_cos_gt<scalar_t, float>{}(row(get_slot(b)), row(get_slot(a)), dimensions);
683684
}
684685
float operator()(scalar_t const* some_vector, member_citerator_t const& member) const {
685-
return metric_cos_gt<scalar_t>{}(some_vector, row(get_slot(member)), dimensions);
686+
return metric_cos_gt<scalar_t, float>{}(some_vector, row(get_slot(member)), dimensions);
686687
}
687688
};
688689

0 commit comments

Comments
 (0)