Skip to content

Commit 0e1a22a

Browse files
committed
Fixes from review
1 parent 5091368 commit 0e1a22a

File tree

2 files changed

+23
-20
lines changed

2 files changed

+23
-20
lines changed

unicodetools/src/main/java/org/unicode/props/UcdProperty.java

Lines changed: 17 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -105,11 +105,7 @@ public enum UcdProperty {
105105
ValueCardinality.Unordered,
106106
"Do_Not_Emit_Dispreferred"),
107107
Do_Not_Emit_Preferred(
108-
PropertyType.String,
109-
DerivedPropertyStatus.UCDNonProperty,
110-
null,
111-
ValueCardinality.Unordered,
112-
"Do_Not_Emit_Preferred"),
108+
PropertyType.String, DerivedPropertyStatus.UCDNonProperty, "Do_Not_Emit_Preferred"),
113109
Equivalent_Unified_Ideograph(PropertyType.String, DerivedPropertyStatus.Approved, "EqUIdeo"),
114110
FC_NFKC_Closure(PropertyType.String, DerivedPropertyStatus.Approved, "FC_NFKC"),
115111
Idn_Mapping(PropertyType.String, DerivedPropertyStatus.NonUCDNonProperty, "idnm"),
@@ -118,7 +114,11 @@ public enum UcdProperty {
118114
NFKC_Casefold(PropertyType.String, DerivedPropertyStatus.Approved, "NFKC_CF"),
119115
NFKC_Simple_Casefold(PropertyType.String, DerivedPropertyStatus.Approved, "NFKC_SCF"),
120116
Names_List_Cross_Ref(
121-
PropertyType.String, DerivedPropertyStatus.UCDNonProperty, "Names_List_Cross_Ref"),
117+
PropertyType.String,
118+
DerivedPropertyStatus.UCDNonProperty,
119+
null,
120+
ValueCardinality.Unordered,
121+
"Names_List_Cross_Ref"),
122122
Simple_Case_Folding(PropertyType.String, DerivedPropertyStatus.Approved, "scf", "sfc"),
123123
Simple_Lowercase_Mapping(PropertyType.String, DerivedPropertyStatus.Approved, "slc"),
124124
Simple_Titlecase_Mapping(PropertyType.String, DerivedPropertyStatus.Approved, "stc"),
@@ -128,12 +128,7 @@ public enum UcdProperty {
128128
kCompatibilityVariant(
129129
PropertyType.String, DerivedPropertyStatus.Approved, "cjkCompatibilityVariant"),
130130
kEH_AltSeq(PropertyType.String, DerivedPropertyStatus.Provisional, "kEH_AltSeq"),
131-
kSEAL_MCJK(
132-
PropertyType.String,
133-
DerivedPropertyStatus.Provisional,
134-
null,
135-
ValueCardinality.Unordered,
136-
"kSEAL_MCJK"),
131+
kSEAL_MCJK(PropertyType.String, DerivedPropertyStatus.Provisional, "kSEAL_MCJK"),
137132
kSimplifiedVariant(
138133
PropertyType.String,
139134
DerivedPropertyStatus.Provisional,
@@ -205,9 +200,17 @@ public enum UcdProperty {
205200
Named_Sequences(PropertyType.Miscellaneous, DerivedPropertyStatus.UCDNonProperty, "NS"),
206201
Named_Sequences_Prov(PropertyType.Miscellaneous, DerivedPropertyStatus.UCDNonProperty, "NSP"),
207202
Names_List_Alias(
208-
PropertyType.Miscellaneous, DerivedPropertyStatus.UCDNonProperty, "Names_List_Alias"),
203+
PropertyType.Miscellaneous,
204+
DerivedPropertyStatus.UCDNonProperty,
205+
null,
206+
ValueCardinality.Unordered,
207+
"Names_List_Alias"),
209208
Names_List_Comment(
210-
PropertyType.Miscellaneous, DerivedPropertyStatus.UCDNonProperty, "Names_List_Comment"),
209+
PropertyType.Miscellaneous,
210+
DerivedPropertyStatus.UCDNonProperty,
211+
null,
212+
ValueCardinality.Unordered,
213+
"Names_List_Comment"),
211214
Names_List_Subheader(
212215
PropertyType.Miscellaneous,
213216
DerivedPropertyStatus.UCDNonProperty,

unicodetools/src/main/resources/org/unicode/props/IndexPropertyRegex.txt

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -76,16 +76,16 @@ Arabic_Shaping_Schematic_Name ; SINGLE_VALUED ; .*
7676
CJK_Radical ; ORDERED ; [0-9]{1,3}'{0,3}
7777
Do_Not_Emit_Dispreferred ; MULTI_VALUED ; .*
7878
Do_Not_Emit_Dispreferred_Type ; MULTI_VALUED ; <enum>
79-
Do_Not_Emit_Preferred ; MULTI_VALUED ; .*
79+
Do_Not_Emit_Preferred ; SINGLE_VALUED ; .*
8080
Emoji_DCM ; SINGLE_VALUED ; [0-9A-F]{4}
8181
Emoji_KDDI ; SINGLE_VALUED ; [0-9A-F]{4}
8282
Emoji_SB ; SINGLE_VALUED ; [0-9A-F]{4}
8383
emoji_variation_sequence ; SINGLE_VALUED ; text style|emoji style
8484
Named_Sequences ; SINGLE_VALUED ; $name
8585
Named_Sequences_Prov ; SINGLE_VALUED ; $name
86-
Names_List_Alias ; SINGLE_VALUED ; .*
87-
Names_List_Comment ; SINGLE_VALUED ; .*
88-
Names_List_Cross_Ref ; SINGLE_VALUED ; .*
86+
Names_List_Alias ; MULTI_VALUED ; .*
87+
Names_List_Comment ; MULTI_VALUED ; .*
88+
Names_List_Cross_Ref ; MULTI_VALUED ; .*
8989
Names_List_Subheader ; MULTI_VALUED ; .*
9090
Names_List_Subheader_Notice ; MULTI_VALUED ; .*
9191
Non_Unihan_Numeric_Value ; SINGLE_VALUED ; NaN|$rational
@@ -250,7 +250,7 @@ kTGT_Numeric ; SINGLE_VALUED ; NaN|$digit+|$positi
250250
## Seal
251251
kSEAL_CCZSrc ; SINGLE_VALUED ; C-\d{5}
252252
kSEAL_DYCSrc ; SINGLE_VALUED ; D-\d{5}
253-
kSEAL_MCJK ; MULTI_VALUED ; [0-9A-F]{4,5}
253+
kSEAL_MCJK ; SINGLE_VALUED ; [0-9A-F]{4,5}
254254
kSEAL_QJZSrc ; SINGLE_VALUED ; K-\d{5}
255255
kSEAL_Rad ; MULTI_VALUED ; \d{1,3}\.[A-F0-9]{4,5}
256-
kSEAL_THXSrc ; SINGLE_VALUED ; TH-\d{5}|TH-(X|Y)\d{3}|KD-[0-9A-F]{5}
256+
kSEAL_THXSrc ; SINGLE_VALUED ; TH-(\d{5}|X\d{3}|Y\d{3})

0 commit comments

Comments
 (0)