Skip to content

Suggestion for slightly cleaner formatting when filtering by cwd #26

Description

@pupto-bismol

Currently, the output of gtrash restore looks like this when you press c to filter by the current directory:

 Trash (cwd)  14/137 >                                         Restore   0/0 >
┌────────────────────────────────────────────────────────────┐┌──────────────────────┐
│ No   DeletedAt       Path (cwd)                            ││ No   Path            │
│────────────────────────────────────────────────────────────││──────────────────────│
│ 1    12 minutes ago  ~/path/to/cwd/afile/a                 ││                      │
│ 2    26 minutes ago  ~/path/to/cwd/package/Thing.java      ││                      │
│ 3    49 minutes ago  ~/path/to/cwd/package/Label.java      ││                      │
│ 4    1 hour ago      ~/path/to/cwd/Title.java              ││                      │
│ 54   1 week ago      ~/path/to/cwd/package/Property.java   ││                      │
│ 55   1 week ago      ~/path/to/cwd/package/OneOf.java      ││                      │

However, I think it would be a little bit more concise/easier on the eyes to simply remove the part of the file path that is the current directory, and indicate the cwd in the header, like so:

 Trash (cwd)  14/137 >                                         Restore   0/0 >
┌────────────────────────────────────────────────────────────┐┌──────────────────────┐
│ No   DeletedAt       Path (cwd: ~/path/to/cwd)             ││ No   Path            │
│────────────────────────────────────────────────────────────││──────────────────────│
│ 1    12 minutes ago  ../afile/a                            ││                      │
│ 2    26 minutes ago  ../package/Thing.java                 ││                      │
│ 3    49 minutes ago  ../package/Label.java                 ││                      │
│ 4    1 hour ago      ../Title.java                         ││                      │
│ 54   1 week ago      ../package/Property.java              ││                      │
│ 55   1 week ago      ../package/OneOf.java                 ││                      │

In the cli interface, the user can just awk the output or something if they want to change how the file paths are printed, but in the interactive version it's not so simple. Plus, you won't be scripting here anyways, so this is just cleaner and easier to read quickly.

Also, this would be a big benefit for anyone working with really long paths, especially if you are using tmux/etc. in which case a much thinner terminal would quickly run out of space and the UI starts to cut off characters anyways. This would ensure that happens less often, but it still gives the user the exact same amount of information.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions