updateUploadHistory throws an error when undos is empty

[devnaumov]

Description

There is the media placeholder example in the: docs. Inside media-placeholder-node component, there’s a call to updateUploadHistory.
In this function, we try to find an index by iterating over editor.history.undos. If undos is empty, or if we can’t find the item with batch.operations.some, index will be -1.
Currently, the code does:

const batch = editor.history.undos[index];
for (const operation of batch.operations) { ... }

When index is -1, batch is undefined, and for (const operation of batch.operations) throws an error.

I think we should check that index is not -1 before proceeding.

Also, can someone clarify the purpose of this function?

Reproduction URL

No response

Reproduction steps

1. Try to insert image
2. Error appears

Plate version

52.0.1

Slate React version

52.0.1

Screenshots

Logs

TypeError: Cannot read properties of undefined (reading 'operations')

Browsers

Chrome

[dosubot]

You're right—a check for index !== -1 is needed before accessing batch.operations. The error happens because when editor.history.undos is empty or no matching batch is found, index is -1 and batch is undefined, so trying to access batch.operations throws a TypeError.

The purpose of updateUploadHistory is to patch the undo history after a media placeholder is replaced with the actual media node. It searches for the most recent undo batch containing an insert_node operation for the node’s placeholderId, updates that operation with the new node, and writes the modified batch back. This keeps undo/redo behavior consistent after media uploads by making sure the historical operation reflects the final node. If no matching batch is found, the function should return early to avoid errors.
Source

To reply, just mention @dosu.

---

^{How did I do? Good | Irrelevant | Incorrect | Verbose | Hallucination | Report 🐛 | Other}

   

[felixfeng33]

I remember it was to undo the successfully uploaded images all at once, rather than undo them back to placeholders.