Fix Explicit API mode warnings; make explicit API strict on Android libs.

Author: psteiger

conventions/src/main/kotlin/ribs.kotlin-android-library-conventions.gradle.kts

@@ -27,7 +27,7 @@ kotlin {
     jvmToolchain(11)
 
     compilerOptions {
-        explicitApiWarning()
+        explicitApi()
         jvmTarget = JvmTarget.JVM_1_8
         optIn.add("kotlin.RequiresOptIn")
         freeCompilerArgs.add("-Xjvm-default=all")

libraries/rib-android-compose/src/main/kotlin/com/uber/rib/core/BasicComposeRouter.kt

@@ -18,10 +18,10 @@ package com.uber.rib.core
 import androidx.compose.runtime.Composable
 import androidx.compose.runtime.MutableState
 
-open class BasicComposeRouter<I : BasicInteractor<*, *>>(
-  val presenter: ComposePresenter,
+public open class BasicComposeRouter<I : BasicInteractor<*, *>>(
+  public val presenter: ComposePresenter,
   interactor: I,
-  val slot: MutableState<(@Composable () -> Unit)>,
+  public val slot: MutableState<@Composable () -> Unit>,
 ) : BasicRouter<I>(interactor) {
   override fun willAttach() {
     slot.value = presenter.composable

libraries/rib-android-compose/src/main/kotlin/com/uber/rib/core/ComposePresenter.kt

@@ -17,6 +17,6 @@ package com.uber.rib.core
 
 import androidx.compose.runtime.Composable
 
-abstract class ComposePresenter : Presenter() {
-  abstract val composable: @Composable () -> Unit
+public abstract class ComposePresenter : Presenter() {
+  public abstract val composable: @Composable () -> Unit
 }

libraries/rib-android-core/src/main/kotlin/com/uber/rib/core/ActivityDelegate.kt

@@ -25,35 +25,35 @@ import androidx.annotation.IntRange
  * functionality. This allows [RibActivity] and any other type of [Activity] that you need to
  * support to share [CoreAppCompatActivity] as a common parent.
  */
-interface ActivityDelegate {
+public interface ActivityDelegate {
   /** @see [Activity.onCreate] */
-  fun onCreate(savedInstanceState: Bundle?) {}
+  public fun onCreate(savedInstanceState: Bundle?) {}
 
   /** @see [Activity.onStart] */
-  fun onStart() {}
+  public fun onStart() {}
 
   /** @see [Activity.onResume] */
-  fun onResume() {}
+  public fun onResume() {}
 
   /** @see [Activity.onPause] */
-  fun onPause() {}
+  public fun onPause() {}
 
   /** @see [Activity.onStop] */
-  fun onStop() {}
+  public fun onStop() {}
 
   /** @see [Activity.onDestroy] */
-  fun onDestroy() {}
+  public fun onDestroy() {}
 
   /** @see [Activity.onActivityResult] */
-  fun onActivityResult(
+  public fun onActivityResult(
     activity: Activity,
     requestCode: Int,
     resultCode: Int,
     data: Intent?,
   ) {}
 
   /** @see [Activity.onRequestPermissionsResult] */
-  fun onRequestPermissionsResult(
+  public fun onRequestPermissionsResult(
     activity: Activity,
     @IntRange(from = 0, to = 255) requestCode: Int,
     permissions: Array<String>,

libraries/rib-android-core/src/main/kotlin/com/uber/rib/core/CoreAppCompatActivity.kt

@@ -25,7 +25,7 @@ import androidx.lifecycle.ViewTreeViewModelStoreOwner
 import androidx.savedstate.ViewTreeSavedStateRegistryOwner
 
 /** Core Support v7 AppCompat Activity. */
-abstract class CoreAppCompatActivity : AppCompatActivity() {
+public abstract class CoreAppCompatActivity : AppCompatActivity() {
 
   private var activityDelegate: ActivityDelegate? = null
 

libraries/rib-android-core/src/main/kotlin/com/uber/rib/core/HasActivityDelegate.kt

@@ -16,11 +16,11 @@
 package com.uber.rib.core
 
 /** Interface to indicate an object has an [ActivityDelegate]. */
-interface HasActivityDelegate {
+public interface HasActivityDelegate {
   /**
    * Get the delegate.
    *
    * @return The delegate.
    */
-  fun activityDelegate(): ActivityDelegate
+  public fun activityDelegate(): ActivityDelegate
 }

libraries/rib-android/src/main/kotlin/com/uber/rib/core/ActivityContext.kt

@@ -15,9 +15,7 @@
  */
 package com.uber.rib.core
 
-import java.lang.annotation.Retention
-import java.lang.annotation.RetentionPolicy.RUNTIME
 import javax.inject.Qualifier
 
 /** Injection qualifier for an Activity Context. */
-@Qualifier @Retention(RUNTIME) annotation class ActivityContext
+@Qualifier @Retention(AnnotationRetention.RUNTIME) public annotation class ActivityContext

libraries/rib-android/src/main/kotlin/com/uber/rib/core/ActivityStarter.kt

@@ -21,13 +21,13 @@ import android.content.Intent
  * Start activities. A much cleaner dependency than an entire activity or context, and easier to
  * inject and mock in tests.
  */
-interface ActivityStarter {
+public interface ActivityStarter {
   /**
    * Start an activity with the given intent.
    *
    * @param intent The intent to open a new activity.
    */
-  fun startActivity(intent: Intent)
+  public fun startActivity(intent: Intent)
 
   /**
    * Start an activity with the given intent, to be notified when that activity finishes.
@@ -37,5 +37,5 @@ interface ActivityStarter {
    *   from this request.
    */
   @Deprecated("""use plain Activity instead""")
-  fun startActivityForResult(intent: Intent, requestCode: Int)
+  public fun startActivityForResult(intent: Intent, requestCode: Int)
 }

libraries/rib-android/src/main/kotlin/com/uber/rib/core/BasicViewRouter.kt

@@ -22,7 +22,7 @@ import android.view.View
  *
  * @param <I> type of interactor.
  */
-abstract class BasicViewRouter<V : View, I : Interactor<*, *>>(
+public abstract class BasicViewRouter<V : View, I : Interactor<*, *>>(
   view: V,
   interactor: I,
 ) : ViewRouter<V, I>(view, interactor)

libraries/rib-android/src/main/kotlin/com/uber/rib/core/IntentCreator.kt

@@ -18,15 +18,15 @@ package com.uber.rib.core
 import android.content.Intent
 
 /** Creates intent objects. */
-interface IntentCreator {
+public interface IntentCreator {
   /**
    * Create an explicit intent targeted at a particular class, which is guaranteed to be limited to
    * your app's package.
    *
    * @param cls The class that you intend to receive this intent.
    * @return The intent.
    */
-  fun create(cls: Class<*>): Intent
+  public fun create(cls: Class<*>): Intent
 
   /**
    * Create an implicit intent targeted at an action, which may end up resolving to your app or to
@@ -37,5 +37,5 @@ interface IntentCreator {
    * @param action The intent action, which any app may register to receive.
    * @return The intent.
    */
-  fun create(action: String): Intent
+  public fun create(action: String): Intent
 }