Skip to content

fix: return stable autorouting solver names - #2158

Closed
seveibar wants to merge 2 commits into
mainfrom
fix/stable-solver-name
Closed

fix: return stable autorouting solver names#2158
seveibar wants to merge 2 commits into
mainfrom
fix/stable-solver-name

Conversation

@seveibar

@seveibar seveibar commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add literal getSolverName() overrides to autorouting pipelines 3, 4, 5, and 8
  • retain the existing literal overrides on the other core-facing pipelines
  • cover all ten autorouter exports used by core, including aliases

Why

solver-utils already uses the instance getSolverName() method throughout GenericSolverDebugger. Returning literals avoids minified labels such as aby without static metadata or constructor wrappers in core.

Verification

  • bun test tests/solver-name.test.ts --timeout 9999999
  • bunx tsc --noEmit
  • bun run build using the Terser-minified output
  • bun run format:check
  • built integration check against all core-facing autorouter exports

@vercel

vercel Bot commented Aug 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
capacity-node-autorouter Ready Ready Preview Aug 18, 2026 10:30pm

Request Review

@tscircuitbot

Copy link
Copy Markdown
Contributor

Benchmark This PR

Run benchmarks by commenting on this PR:

/benchmark [benchmark.sh args...]
/benchmark-long [benchmark.sh args...]
/benchmark-all
/benchmark --same-machine
/benchmark-all --same-machine
/profile --dataset 18

Comment /benchmark to run the default dataset, or append any arguments accepted by ./benchmark.sh.
Comment /benchmark-long for an 8-vCPU run that defaults to 8 workers and has an eight-hour timeout.
Comment exactly /benchmark-all to start separate workflow runs and result comments for the default dataset plus srj18, srj19, srj20, srj21, and srj23.
Append --same-machine to /benchmark or /benchmark-all to compare current main and the PR head sequentially on the same 8-vCPU Blacksmith runner.
Comment /profile --dataset 18 to compare direct Pipeline 7 stage-time percentages between current main and the PR head sequentially on one Blacksmith runner.

Everything after /benchmark or /benchmark-long is safely forwarded to ./benchmark.sh, except --profile-solvers, which enables profile comparison tables, and --same-machine, which enables the paired runner.
Examples: /benchmark --dataset 18 --sample-timeout 2000s, /benchmark --pipeline 10 --dataset 29, /benchmark --pipeline 10 --dataset 29 --sample 1, /benchmark --pipeline 7 --limit 20, /benchmark all 20 --concurrency 8, /benchmark --same-machine, /benchmark-all --same-machine, and /benchmark-long --dataset 18.

Use /update-snapshots (or /us) to run BUN_UPDATE_SNAPSHOTS=1 bun test --timeout 120_000 on the PR branch and auto-commit snapshot updates.
Use /usf to read recent failed test files, update and verify their exact CI test shards, and auto-commit only their snapshots. It uses the configured fast benchmark runner by default; use /usf --ubuntu-latest for GitHub-hosted x64 CI parity.

Any PR whose title contains [BENCHMARK TEST] will automatically run one default-dataset benchmark on PR updates; it does not post a PR result comment.

@seveibar seveibar changed the title fix: add stable autorouting solver names fix: return stable autorouting solver names Aug 18, 2026
@seveibar seveibar closed this Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants