Fix schematic box text alignment with bottom pins

Author: seveibar

lib/components/base-components/NormalComponent/NormalComponent.ts

@@ -860,9 +860,9 @@ export class NormalComponent<
       source_component_id: this.source_component_id!,
       schematic_sheet_id: this._resolveSchematicSheetId(),
     })
+    const hasTopPins = schPortArrangement?.topSide !== undefined
     const hasTopOrBottomPins =
-      schPortArrangement?.topSide !== undefined ||
-      schPortArrangement?.bottomSide !== undefined
+      hasTopPins || schPortArrangement?.bottomSide !== undefined
     const schematic_box_width = dimensions?.getSize().width
     const schematic_box_height = dimensions?.getSize().height
     const manufacturer_part_number_schematic_text = db.schematic_text.insert({
@@ -871,7 +871,7 @@ export class NormalComponent<
       anchor: "left",
       rotation: 0,
       position: {
-        x: hasTopOrBottomPins
+        x: hasTopPins
           ? center.x + (schematic_box_width ?? 0) / 2 + 0.1
           : center.x - (schematic_box_width ?? 0) / 2,
         y: hasTopOrBottomPins
@@ -888,7 +888,7 @@ export class NormalComponent<
       anchor: "left",
       rotation: 0,
       position: {
-        x: hasTopOrBottomPins
+        x: hasTopPins
           ? center.x + (schematic_box_width ?? 0) / 2 + 0.1
           : center.x - (schematic_box_width ?? 0) / 2,
         y: hasTopOrBottomPins

tests/components/normal-components/__snapshots__/connector-usbc-inner-symbol-schematic.snap.svg

@@ -0,0 +1,41 @@
+import { expect, test } from "bun:test"
+import type { PartsEngine } from "@tscircuit/props"
+import type { AnyCircuitElement } from "circuit-json"
+import usbCC165948CircuitJson from "tests/fixtures/assets/usb-c-C165948.circuit.json"
+import { getTestFixture } from "tests/fixtures/get-test-fixture"
+
+test("USB-C connector text is aligned with the schematic box left edge", async () => {
+  const { circuit } = getTestFixture()
+
+  const mockPartsEngine: PartsEngine = {
+    findPart: async () => ({ jlcpcb: ["C165948"] }),
+    fetchPartCircuitJson: async ({ supplierPartNumber }) => {
+      if (supplierPartNumber === "C165948") {
+        return usbCC165948CircuitJson as AnyCircuitElement[]
+      }
+      return undefined
+    },
+  }
+
+  circuit.add(
+    <board partsEngine={mockPartsEngine} width="20mm" height="20mm">
+      <connector
+        name="J_USB"
+        manufacturerPartNumber="HRO-TYPE-C-31-M-12"
+        standard="usb_c"
+      />
+    </board>,
+  )
+
+  await circuit.renderUntilSettled()
+
+  const schematicComponent = circuit.db.schematic_component.list()[0]
+  const expectedLeftEdge =
+    schematicComponent.center.x - schematicComponent.size.width / 2
+  const schematicTextPositions = circuit.db.schematic_text
+    .list()
+    .map(({ position }) => position.x)
+
+  expect(schematicTextPositions).toEqual([expectedLeftEdge, expectedLeftEdge])
+  expect(circuit).toMatchSchematicSnapshot(import.meta.path)
+})