-
Notifications
You must be signed in to change notification settings - Fork 136
Description
Hi there Tordanik, thank you again for the great work! Just recently found out we can add windows too .
I have an issue with it, not sure if it's a bug, probably not, but should be communicated with the community I think on the proposal wiki for windows.
if a window is between concrete beams and covers 100% of the area between 2 beams the only way for me to add windows is define a wall there and then say the window must be rendered in/on that wall.
So if a lower beam has min_height=4.60 and height=5.00
and the upper beam has min_height=7.60 and height=8.00
the space between is then 7.60-5.00 = 2.60 so the mapper would add a wall between with min_height=5.00 and height=7.60
Now since the mapper would want the windows to go all the way from the bottom to the top he'd map
window:breast=0 and window:height=2.60
And now the windows won't be rendered. The mapper is wondering:"huh, what's wrong?" it's simply not visible.
Took me also a while to figure it out.
But the trick here is to set window:height=2.59 now it's being rendered.
So the window really has to be INSIDE the wall - even if the wall is fictive just to be able to add the window rendering node to that wall - the windows can not span 100% of the area but always -0.01 to make sure it's being rendered.
So maybe not a bug - although I do think the windows should be rendered between the 2 beams, but the -0.01 is a neat trick to get it done anyway.
But then one might consider to update the wiki on windows for your proposal to inform mappers:"the window:height+window:breast must be smaller than the height of the wall they're embedded into. If they're equal - they won't be rendered.
Again, I do think it should be possible that a window is rendered to equal height, but if not possible programmatically then consider adding this little piece of information to the wiki on windows to always keep the window:beast+window:height < height(of the wall)