Rename socket to stream

[alexrook]

website/content/tokio/tutorial/io.md

Line 192 in cb9b7f4

let (mut socket, _) = listener.accept().await?;

looks like renaming socket to stream would be better

[AlfredWilmot]

I reckon the choice to name that variable socket is probably just because that's what's done in the example from the std-lib: https://doc.rust-lang.org/std/net/struct.TcpListener.html#method.accept

Looking at the tokio API docs it does look like renaming socket to stream would better reflect the fact that a TcpStream is returned by the TcpListener::accept method, as opposed to a TcpSocket (which can be used to create a TcpStream).

However, the I think if socket is renamed to stream here, it would need to be renamed elsewhere for consistency, which means a lot of changes across multiple tokio code-bases. For example, here are some lines from the website and the main tokio repo that I've cloned locally that would require updating:

grep -IR 'let .*socket.*=.*\.accept\(\).*;' . | grep -v "\.js:"
./tokio/tokio/tests/rt_threaded.rs:        let (mut socket, _) = server.accept().await.unwrap();
./tokio/tokio/tests/tcp_connect.rs:        let (socket, addr) = assert_ok!(srv.accept().await);
./tokio/tokio/tests/tcp_connect.rs:        let (socket, addr) = assert_ok!(srv.accept().await);
./tokio/tokio/tests/tcp_accept.rs:                    let (socket, _) = assert_ok!(listener.accept().await);
./tokio/tokio/tests/rt_common.rs:            let (mut socket, _) = server.accept().await.unwrap();
./tokio/tokio/tests/rt_common.rs:            let (mut socket, _) = server.accept().await.unwrap();
./tokio/tokio/src/runtime/mod.rs://!         let (mut socket, _) = listener.accept().await?;
./tokio/tokio/src/runtime/mod.rs://!             let (mut socket, _) = listener.accept().await?;
./tokio/tokio/src/task/builder.rs:///         let (socket, _) = listener.accept().await?;
./tokio/tokio/src/task/spawn.rs:    ///         let (socket, _) = listener.accept().await?;
./tokio/tokio/src/lib.rs://!         let (mut socket, _) = listener.accept().await?;
./tokio/tokio/src/net/tcp/listener.rs:    ///         let (socket, _) = listener.accept().await?;
./tokio/tokio/src/sync/semaphore.rs:///         let (mut socket, _) = listener.accept().await?;
./tokio/tokio/README.md:        let (mut socket, _) = listener.accept().await?;
./tokio/stress-test/examples/simple_echo_tcp.rs:        let (mut socket, _) = listener.accept().await.unwrap();
./tokio/examples/print_each_packet.rs:        let (socket, _) = listener.accept().await?;
./tokio/examples/echo-tcp.rs:        let (mut socket, _) = listener.accept().await?;
./tokio/README.md:        let (mut socket, _) = listener.accept().await?;
./website/content/tokio/tutorial/shared-state.md:        let (socket, _) = listener.accept().await.unwrap();
./website/content/tokio/tutorial/io.md:        let (mut socket, _) = listener.accept().await?;
./website/content/tokio/tutorial/io.md:        let (mut socket, _) = listener.accept().await?;
./website/content/tokio/tutorial/select.md:                let (socket, _) = listener.accept().await?;
./website/content/tokio/tutorial/select.md:                let (socket, _) = listener.accept().await?;
./website/content/tokio/tutorial/spawning.md:        let (socket, _) = listener.accept().await.unwrap();
./website/content/tokio/tutorial/spawning.md:        let (socket, _) = listener.accept().await.unwrap();
./website/content/blog/2019-08-alphas.md:        let (mut socket, _) = listener.accept().await?;
./website/content/blog/2019-08-alphas.md:let (mut socket, _) = listener.accept().await?;
./website/content/blog/2021-07-tokio-uring.md:            let (mut socket, _) = listener.accept().await.unwrap();
./website/content/blog/2020-04-preemption.md:    let (mut socket, _) = listener.accept().await?;
./website/content/blog/2019-11-tokio-0-2.md:let (mut socket, _peer_addr) = listener.accept().await?;
./website/tutorial-code/shared-state/src/main.rs:        let (socket, _) = listener.accept().await.unwrap();
./website/tutorial-code/spawning/src/main.rs:        let (socket, _) = listener.accept().await.unwrap();
./website/tutorial-code/io/src/echo-server.rs:        let (mut socket, _) = listener.accept().await?;
./website/tutorial-code/io/src/echo-server-copy.rs:        let (mut socket, _) = listener.accept().await?;

Plus it would deviate from the examples in the std-lib, which is probably not desirable either.