Skip to content

Commit b88fd8a

Browse files
Added additional test
1 parent fb502e0 commit b88fd8a

File tree

2 files changed

+10
-7
lines changed

2 files changed

+10
-7
lines changed

test/res/AvoidHardCodedNumbers.jl

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,9 @@ energy = mass * C_SPEED_OF_LIGHT^2
3232
# ok: known values
3333
ok_floats = max(0.1, 1.0, 0.0, 1.0, 1000.0, 1.0, 0.0, 0.1, 1000.0)
3434

35+
# ok: multi-dim array in function call
36+
converted = convert.(Float64, [[2, 8446744073709551616, 42, 5.76, 3.14], [2, 8446744073709551616, 42, 5.76, 3.14]])
37+
3538
# ok: array literal
3639
weights_vec = [2.2, 1.2, 3.4, 4.5, 2.2, 2.2, 1.2, 3.4, 4.5]
3740
end # GoodStyle

test/res/AvoidHardCodedNumbers.val

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -36,43 +36,43 @@ nok_floats = max(1.1, 1.1, 0.2, 1.1, 1000.1, 1.1, 0.2, 0.2, 1000.1)
3636
Avoid hard-coded numbers.
3737
Rule: avoid-hard-coded-numbers. Severity: 3
3838

39-
AvoidHardCodedNumbers.jl(41, 17):
39+
AvoidHardCodedNumbers.jl(44, 17):
4040
energy(m) = m * 4.493775893684088e16
4141
# └──────────────────┘ ── Hard-coded number '4.493775893684088e16' should be a const variable.
4242
Avoid hard-coded numbers.
4343
Rule: avoid-hard-coded-numbers. Severity: 3
4444

45-
AvoidHardCodedNumbers.jl(42, 11):
45+
AvoidHardCodedNumbers.jl(45, 11):
4646
Area(r) = 3.14 * r ^ 2
4747
# └──┘ ── Hard-coded number '3.14' should be a const variable.
4848
Avoid hard-coded numbers.
4949
Rule: avoid-hard-coded-numbers. Severity: 3
5050

51-
AvoidHardCodedNumbers.jl(49, 20):
51+
AvoidHardCodedNumbers.jl(52, 20):
5252
universal_answer = 42
5353
# └┘ ── Hard-coded number '42' should be a const variable.
5454
Avoid hard-coded numbers.
5555
Rule: avoid-hard-coded-numbers. Severity: 3
5656

57-
AvoidHardCodedNumbers.jl(53, 40):
57+
AvoidHardCodedNumbers.jl(56, 40):
5858
another_vectorwraparound_overflow_19 = -8446744073709551616
5959
# └──────────────────┘ ── Hard-coded number '-8446744073709551616' should be a const variable.
6060
Avoid hard-coded numbers.
6161
Rule: avoid-hard-coded-numbers. Severity: 3
6262

63-
AvoidHardCodedNumbers.jl(54, 40):
63+
AvoidHardCodedNumbers.jl(57, 40):
6464
another_vectorwraparound_overflow_20 = 7766279631452241920
6565
# └─────────────────┘ ── Hard-coded number '7766279631452241920' should be a const variable.
6666
Avoid hard-coded numbers.
6767
Rule: avoid-hard-coded-numbers. Severity: 3
6868

69-
AvoidHardCodedNumbers.jl(55, 44):
69+
AvoidHardCodedNumbers.jl(58, 44):
7070
another_vectorwraparound_overflow_19_neg = -7766279631452241920
7171
# └──────────────────┘ ── Hard-coded number '-7766279631452241920' should be a const variable.
7272
Avoid hard-coded numbers.
7373
Rule: avoid-hard-coded-numbers. Severity: 3
7474

75-
AvoidHardCodedNumbers.jl(56, 44):
75+
AvoidHardCodedNumbers.jl(59, 44):
7676
another_vectorwraparound_overflow_20_neg = 8446744073709551616
7777
# └─────────────────┘ ── Hard-coded number '8446744073709551616' should be a const variable.
7878
Avoid hard-coded numbers.

0 commit comments

Comments
 (0)