crash in store due to a bug in mysql adapter on missing auth record

Author: or-else

server/db/mongodb/adapter.go

@@ -1121,7 +1121,7 @@ func (a *adapter) AuthGetRecord(uid t.Uid, scheme string) (string, auth.Level, [
 	err := a.db.Collection("auth").FindOne(a.ctx, filter, findOpts).Decode(&record)
 	if err != nil {
 		if err == mdb.ErrNoDocuments {
-			return "", 0, nil, time.Time{}, t.ErrNotFound
+			err = t.ErrNotFound
 		}
 		return "", 0, nil, time.Time{}, err
 	}

server/db/mysql/adapter.go

@@ -867,8 +867,8 @@ func (a *adapter) AuthGetRecord(uid t.Uid, scheme string) (string, auth.Level, [
 	if err := a.db.GetContext(ctx, &record, "SELECT uname,secret,expires,authlvl FROM auth WHERE userid=? AND scheme=?",
 		store.DecodeUid(uid), scheme); err != nil {
 		if err == sql.ErrNoRows {
-			// Nothing found - clear the error
-			err = nil
+			// Nothing found - use standard error.
+			err = t.ErrNotFound
 		}
 		return "", 0, nil, expires, err
 	}

server/session.go

@@ -955,7 +955,8 @@ func (s *Session) login(msg *ClientComMessage) {
 }
 
 // authSecretReset resets an authentication secret;
-//  params: "auth-method-to-reset:credential-method:credential-value".
+// params: "auth-method-to-reset:credential-method:credential-value",
+// for example: "basic:email:alice@example.com".
 func (s *Session) authSecretReset(params []byte) error {
 	var authScheme, credMethod, credValue string
 	if parts := strings.Split(string(params), ":"); len(parts) == 3 {

server/store/store.go

@@ -322,8 +322,13 @@ func (UsersObjMapper) GetAuthRecord(user types.Uid, scheme string) (string, auth
 	unique, authLvl, secret, expires, err := adp.AuthGetRecord(user, scheme)
 	if err == nil {
 		parts := strings.Split(unique, ":")
-		unique = parts[1]
+		if len(parts) > 1 {
+			unique = parts[1]
+		} else {
+			err = types.ErrInternal
+		}
 	}
+
 	return unique, authLvl, secret, expires, err
 }