refactor(inventory): break out inventory types

Breaks out inventory types out of the inventory index.js.

Author: jniles

package-lock.json

@@ -74,6 +74,7 @@ const employeeReports = require('../controllers/payroll/reports');
 const inventory = require('../controllers/inventory');
 const inventoryUnits = require('../controllers/inventory/units');
 const inventoryGroups = require('../controllers/inventory/groups');
+const inventoryTypes = require('../controllers/inventory/types');
 
 const depots = require('../controllers/inventory/depots');
 const inventoryReports = require('../controllers/inventory/reports');
@@ -371,14 +372,7 @@ exports.configure = function configure(app) {
 
   /** Inventory Group API endpoints */
   app.use('/inventory/groups', inventoryGroups);
-
-  /** Inventory Type API endpoints */
-  app.post('/inventory/types', inventory.createInventoryTypes);
-  app.get('/inventory/types', inventory.listInventoryTypes);
-  app.get('/inventory/types/:id', inventory.detailsInventoryTypes);
-  app.put('/inventory/types/:id', inventory.updateInventoryTypes);
-  app.delete('/inventory/types/:id', inventory.deleteInventoryTypes);
-
+  app.use('/inventory/types', inventoryTypes);
   app.use('/inventory/units', inventoryUnits);
 
   /** Inventory Import API endpoints */

server/config/routes.js

@@ -13,7 +13,6 @@
 // const debug = require('debug')('bhima:inventory:index');
 const _ = require('lodash');
 const core = require('./inventory/core');
-const types = require('./inventory/types');
 const importing = require('./import');
 const util = require('../../lib/util');
 const db = require('../../lib/db');
@@ -31,13 +30,6 @@ exports.updateInventoryItems = updateInventoryItems;
 exports.getInventoryItems = getInventoryItems;
 exports.getInventoryItemsById = getInventoryItemsById;
 
-// expose inventory types methods
-exports.createInventoryTypes = createInventoryTypes;
-exports.updateInventoryTypes = updateInventoryTypes;
-exports.listInventoryTypes = listInventoryTypes;
-exports.detailsInventoryTypes = detailsInventoryTypes;
-exports.deleteInventoryTypes = deleteInventoryTypes;
-
 exports.deleteInventory = deleteInventory;
 
 exports.getInventoryUnitCosts = getInventoryUnitCosts;
@@ -276,53 +268,3 @@ async function deleteInventory(req, res) {
   await core.remove(req.params.uuid);
   res.sendStatus(204);
 }
-
-// ======================= inventory type =============================
-/**
- * POST /inventory/types
- * Create a new inventory types
- */
-async function createInventoryTypes(req, res) {
-  const id = await types.create(req.body);
-  res.status(201).json({ id });
-
-}
-
-/**
- * PUT /inventory/types/:id
- * Create a new inventory types
- */
-async function updateInventoryTypes(req, res) {
-  const rows = await types.update(req.body, req.params.id);
-  res.status(201).json(rows);
-
-}
-
-/**
- * GET /inventory/types
- * get the list of inventory types
- */
-async function listInventoryTypes(req, res) {
-  const rows = await types.list();
-  res.status(200).json(rows);
-
-}
-
-/**
- * GET /inventory/types/:id
- * get the list of inventory types
- */
-async function detailsInventoryTypes(req, res) {
-  const rows = await types.details(req.params.id);
-  res.status(200).json(rows);
-
-}
-
-/**
- * DELETE /inventory/types/:id
- * delete an inventory types
- */
-async function deleteInventoryTypes(req, res) {
-  await types.remove(req.params.id);
-  res.sendStatus(204);
-}

server/controllers/inventory/index.js

@@ -0,0 +1,72 @@
+const router = require('express').Router();
+const db = require('../../../lib/db');
+
+/**
+ * POST /inventory/types
+ *
+ * @description
+ * Create a new inventory type
+ */
+router.post('/', async (req, res) => {
+  const sql = 'INSERT INTO inventory_type (text, description) VALUES (?, ?);';
+  const row = await db.exec(sql, [req.body.text, req.body.description]);
+  res.status(201).json({ id : row.insertId });
+});
+
+/**
+ * GET /inventory/types
+ *
+ * @description
+ * Get the list of inventory types
+ */
+router.get('/', async (req, res) => {
+  const rows = await getTypes();
+  res.status(200).json(rows);
+});
+
+/**
+ * GET /inventory/types/:id
+ *
+ * @description
+ * Get the specific type.
+ */
+router.get('/:id', async (req, res) => {
+  const rows = await getTypes(req.params.id);
+  res.status(200).json(rows);
+});
+
+/**
+ * PUT /inventory/types/:id
+ *
+ * @description
+ * Update the specific inventory type identified by id.
+ */
+router.put('/:id', async (req, res) => {
+  const sql = 'UPDATE inventory_type SET ? WHERE id = ?;';
+  await db.exec(sql, [req.body, req.params.id]);
+  const rows = await getTypes(req.params.id);
+  res.status(200).json(rows);
+});
+
+/**
+ * DELETE /inventory/types/:id
+ *
+ * @description
+ * Delete an inventory type.
+ */
+router.delete('/:id', async (req, res) => {
+  const sql = 'DELETE FROM inventory_type WHERE id = ?;';
+  await db.exec(sql, [req.params.id]);
+  res.sendStatus(204);
+});
+
+/**
+ * Get list of inventory types
+ * @param {string} id the type id is optional
+ */
+function getTypes(id) {
+  const sql = `SELECT id, text, description, is_predefined FROM inventory_type ${id ? ' WHERE id = ?' : ''};`;
+  return db.exec(sql, [id]);
+}
+
+module.exports = router;