Skip to content

Commit 3db6909

Browse files
rafaeljwbardliao
authored andcommitted
Revert "ACPI: PM: Let acpi_dev_pm_attach() skip devices without ACPI PM"
Revert commit 88fad6c ("ACPI: PM: Let acpi_dev_pm_attach() skip devices without ACPI PM") that introduced SoundWire suspend regression [1]. It is actually not true that the commit above doesn't make a functional difference because acpi_subsys_suspend(), for example, may resume devices in runtime-suspend which affects the subsequent handling of those devices during the suspend transition. For this reason, the devices that were handled by the ACPI PM domain before that commit may be handled differently now which may lead to suspend-resume issues. Fixes: 88fad6c ("ACPI: PM: Let acpi_dev_pm_attach() skip devices without ACPI PM") Reported-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com> Closes: #5677 (comment) [1] Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
1 parent 05d1c69 commit 3db6909

File tree

1 file changed

+0
-9
lines changed

1 file changed

+0
-9
lines changed

drivers/acpi/device_pm.c

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1456,15 +1456,6 @@ int acpi_dev_pm_attach(struct device *dev, bool power_on)
14561456
if (!adev || !acpi_match_device_ids(adev, special_pm_ids))
14571457
return 0;
14581458

1459-
/*
1460-
* Skip devices whose ACPI companions don't support power management and
1461-
* don't have a wakeup GPE.
1462-
*/
1463-
if (!acpi_device_power_manageable(adev) && !acpi_device_can_wakeup(adev)) {
1464-
dev_dbg(dev, "No ACPI power management or wakeup GPE\n");
1465-
return 0;
1466-
}
1467-
14681459
/*
14691460
* Only attach the power domain to the first device if the
14701461
* companion is shared by multiple. This is to prevent doing power

0 commit comments

Comments
 (0)