deps: golangci linter v2 (#24)

Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>

Author: golanglemonade

.golangci.yaml

@@ -1,43 +1,44 @@
+version: "2"
 run:
-  timeout: 10m
   allow-serial-runners: true
-  concurrency: 0
-linters-settings:
-  goimports:
-    local-prefixes: github.com/theopenlane/httpsling
-  gofumpt:
-    extra-rules: true
-  gosec:
-    exclude-generated: true
-  revive:
-    ignore-generated-header: true
 linters:
   enable:
     - bodyclose
-    - errcheck
+    - err113
     - gocritic
     - gocyclo
-    - err113
-    - gofmt
-    - goimports
-    - mnd
-    - gosimple
-    - govet
     - gosec
-    - ineffassign
     - misspell
+    - mnd
     - noctx
     - revive
     - staticcheck
-    - stylecheck
-    - typecheck
-    - unused
     - whitespace
     - wsl
+  exclusions:
+    generated: lax
+    presets:
+      - comments
+      - common-false-positives
+      - legacy
+      - std-error-handling
+    paths:
+      - example_test.go
+      - httptestutil/*
+      - third_party$
+      - builtin$
+      - examples$
+      - _test.go$
+      - mocks.go
 issues:
   fix: true
-  exclude-use-default: true
-  exclude-dirs:
-    - httptestutil/*
-  exclude-files:
-    - example_test.go
+formatters:
+  enable:
+    - gofmt
+    - goimports
+  settings:
+    gofumpt:
+      extra-rules: true
+    goimports:
+      local-prefixes:
+        - github.com/theopenlane/httpsling

Taskfile.yaml

@@ -10,7 +10,7 @@ tasks:
   go:lint:
     desc: runs golangci-lint, the most annoying opinionated linter ever
     cmds:
-      - golangci-lint run --config=.golangci.yaml --verbose --fast --fix
+      - golangci-lint run --config=.golangci.yaml --verbose --fix
 
   go:fmt:
     desc: format all go code

go.mod

@@ -6,8 +6,7 @@ require (
 	github.com/felixge/httpsnoop v1.0.4
 	github.com/google/go-querystring v1.1.0
 	github.com/stretchr/testify v1.10.0
-	github.com/theopenlane/utils v0.4.3
-
+	github.com/theopenlane/utils v0.4.4
 )
 
 require (

go.sum

@@ -15,8 +15,8 @@ github.com/stretchr/testify v1.10.0 h1:Xv5erBjTwe/5IxqUQTdXv5kgmIvbHo3QQyRwhJsOf
 github.com/stretchr/testify v1.10.0/go.mod h1:r2ic/lqez/lEtzL7wO/rwa5dbSLXVDPFyf8C91i36aY=
 github.com/theopenlane/echox v0.2.1 h1:ZhVkimmWxpKITf67oM57SrLWeIdnV8+dNXlC+VzlRaQ=
 github.com/theopenlane/echox v0.2.1/go.mod h1:4j/Hx0uoLk5gVzdA83Qqz7xBEmqpoEP+OnzVaw2p6/o=
-github.com/theopenlane/utils v0.4.3 h1:0ZSqUzbbQt7lczLTIXlbYXOwLuKuQns//L2AHQOZdis=
-github.com/theopenlane/utils v0.4.3/go.mod h1:UTzPMpvyCu35eGium50H7KroHU0+2mh1lMOYTb4Vi70=
+github.com/theopenlane/utils v0.4.4 h1:4Xb2T+4bjMtf4OL73bWQ1a8zllTt43ryVflRzVaUgmU=
+github.com/theopenlane/utils v0.4.4/go.mod h1:lNzPjqQoDM5565s5FRqkmBGO77twAkY3Hxgd38ESo6I=
 go.uber.org/mock v0.5.0 h1:KAMbZvZPyBPWgD14IrIQ38QCyjwpvVVV6K/bHl1IwQU=
 go.uber.org/mock v0.5.0/go.mod h1:ge71pBPLYDk7QIi1LupWxdAykm7KIEFchiOqd6z7qMM=
 golang.org/x/mod v0.18.0 h1:5+9lSbEzPSdWkH32vYPBwEpX8KwDbM52Ud9xBUvNlb0=

httpclient/options.go

@@ -11,7 +11,7 @@ import (
 // NoRedirects configures the client to no perform any redirects
 func NoRedirects() Option {
 	return OptionFunc(func(client *http.Client) error {
-		client.CheckRedirect = func(req *http.Request, via []*http.Request) error {
+		client.CheckRedirect = func(_ *http.Request, _ []*http.Request) error {
 			return http.ErrUseLastResponse
 		}
 
@@ -20,10 +20,10 @@ func NoRedirects() Option {
 }
 
 // MaxRedirects configures the max number of redirects the client will perform before giving up
-func MaxRedirects(max int) Option {
+func MaxRedirects(m int) Option {
 	return OptionFunc(func(client *http.Client) error {
-		client.CheckRedirect = func(req *http.Request, via []*http.Request) error {
-			if len(via) >= max {
+		client.CheckRedirect = func(_ *http.Request, via []*http.Request) error {
+			if len(via) >= m {
 				return ErrMaxAttemptsExceeded
 			}
 
@@ -56,7 +56,7 @@ func ProxyURL(proxyURL string) Option {
 			return err
 		}
 
-		t.Proxy = func(request *http.Request) (*url.URL, error) {
+		t.Proxy = func(_ *http.Request) (*url.URL, error) {
 			return u, nil
 		}
 

httptestutil/inspector_test.go

@@ -207,7 +207,7 @@ func TestInspectNilhandler(t *testing.T) {
 	require.NotNil(t, i.LastExchange())
 }
 
-func ExampleInspectorNextExchange() {
+func ExampleInspector_NextExchange() {
 	i := NewInspector(0)
 
 	var h http.Handler = http.HandlerFunc(func(writer http.ResponseWriter, request *http.Request) {
@@ -232,7 +232,7 @@ func ExampleInspectorNextExchange() {
 	// <nil>
 }
 
-func ExampleInspectorLastExchange() {
+func ExampleInspector_LastExchange() {
 	i := NewInspector(0)
 
 	var h http.Handler = http.HandlerFunc(func(writer http.ResponseWriter, request *http.Request) {

marshaling_test.go

@@ -174,7 +174,7 @@ func TestFormMarshalerMarshal(t *testing.T) {
 }
 
 func TestMarshalFuncApply(t *testing.T) {
-	var mf MarshalFunc = func(v interface{}) (bytes []byte, s string, e error) {
+	var mf MarshalFunc = func(_ interface{}) (bytes []byte, s string, e error) {
 		return nil, "red", nil
 	}