Possible .dockerignore misconfiguration #936
tomokinakamaru
started this conversation in
General Discussion
Replies: 1 comment
-
|
It is completly because I though .gitignore & .dockerignore work the same, you can create a PR if you want to ! |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
(I am posting this here because I was not sure if it is actually a bug or not.)
As part of my research, I am analyzing how developers configure .dockerignore in popular repositories.
During my analysis, I noticed that
/.dockerignoremight have been written under the assumption that .dockerignore and .gitignore follow the same pattern semantics, while they actually differ.1 In particular, the following pattern drew my attention:cards-database/.dockerignore
Line 8 in 70c9252
According to Docker's specification, this pattern matches
.DS_Storeonly in the top-level directory. (To ignore.DS_Storein any directory, the .dockerignore file needs to list**/.DS_Store)Was this pattern written intentionally? If not, I'd be happy to submit a pull request to adjust it.
And if possible, could one of the maintainers tell me whether he/she were aware of the difference between .dockerignore and .gitignore? (I would like to know whether the differences are generally well recognized, or if they tend to slip developers' minds.)
Thank you for maintaining this repository!
Footnotes
See .gitignore doc, .dockerignore doc, and a blog post about the differences ↩
Beta Was this translation helpful? Give feedback.
All reactions