Merge pull request #19 from syswonder/dev/code-cleanup

chore: update submodule configurations and enhance issue templates

Author: enkerewpo

.github/ISSUE_TEMPLATE/bug_report.md

@@ -1,6 +1,6 @@
 ---
 name: Bug Report
-about: Report a bug in the robonix embodied intelligence framework
+about: Report a bug in the Robonix
 title: '[BUG] '
 labels: 'bug'
 assignees: ''
@@ -11,14 +11,14 @@ assignees: ''
 Brief description of the issue.
 
 ## Component
-- [ ] Brain (AI/LLM)
-- [ ] Capability (Hardware interface)
-- [ ] Driver (Hardware driver)
-- [ ] Manager (System bootstrap)
-- [ ] Memory (Knowledge storage)
-- [ ] Simulator (Genesis simulation)
-- [ ] Skill (Behavioral logic)
-- [ ] UAPI (User programming interface)
+
+- [ ] **Managers** (Task, Maps, AI Model services)
+- [ ] **UI System**
+- [ ] **RIDL Executor**
+- [ ] **Skill Library**
+- [ ] **Primitive HAL** (Camera, Base, Arm, …)
+- [ ] **Libraries / ROS2** (stack, bindings)
+- [ ] Other / not sure
 
 ## Steps to Reproduce
 1. 
@@ -31,8 +31,8 @@ What should happen instead.
 ## Environment
 - OS: [e.g. Ubuntu 22.04]
 - ROS2 Version: [e.g. Humble]
-- Python Version: [e.g. 3.8]
-- Hardware: [e.g. Piper Ranger, Genesis Simulator]
+- Rust Version: [e.g. 1.75]
+- Hardware: [e.g. robot base, camera, simulator]
 
 ## Error Logs
 ```

.github/ISSUE_TEMPLATE/feature_request.md

@@ -1,6 +1,6 @@
 ---
 name: Feature Request
-about: Suggest a new feature for the robonix embodied intelligence framework
+about: Suggest a new feature for the Robonix
 title: '[FEATURE] '
 labels: 'enhancement'
 assignees: ''
@@ -11,14 +11,14 @@ assignees: ''
 Brief description of the proposed feature.
 
 ## Component
-- [ ] Brain (AI/LLM)
-- [ ] Capability (Hardware interface)
-- [ ] Driver (Hardware driver)
-- [ ] Manager (System bootstrap)
-- [ ] Memory (Knowledge storage)
-- [ ] Simulator (Genesis simulation)
-- [ ] Skill (Behavioral logic)
-- [ ] UAPI (User programming interface)
+
+- [ ] **Managers** (Task, Maps, AI Model services)
+- [ ] **UI System**
+- [ ] **RIDL Executor**
+- [ ] **Skill Library**
+- [ ] **Primitive HAL** (Camera, Base, Arm, …)
+- [ ] **Libraries / ROS2** (stack, bindings)
+- [ ] Other / not sure
 
 ## Problem Statement
 What problem does this feature solve?

.github/workflows/ci.yml

@@ -0,0 +1,63 @@
+# Robonix CI — all build/check logic lives in rust/Makefile (make ci-rust / make ci-full)
+name: CI
+
+on:
+  push:
+    branches: [main, dev/**]
+  pull_request:
+    branches: [main, dev/**]
+
+env:
+  RUST_DIR: rust
+
+jobs:
+  rust:
+    name: Rust (make ci-rust)
+    runs-on: ubuntu-22.04
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Install Rust
+        uses: dtolnay/rust-toolchain@stable
+        with:
+          components: rustfmt
+
+      - name: make ci-rust
+        run: cd ${{ env.RUST_DIR }} && make ci-rust
+
+  full:
+    name: Full (make ci-full)
+    runs-on: ubuntu-22.04
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Install ROS2 Humble
+        run: |
+          sudo apt-get update
+          sudo apt-get install -y locales
+          sudo locale-gen en_US en_US.UTF-8
+          sudo update-locale LC_ALL=en_US.UTF-8 LANG=en_US.UTF-8
+          export LANG=en_US.UTF-8
+          sudo apt-get install -y curl gnupg2 lsb-release
+          sudo curl -sSL https://raw.githubusercontent.com/ros/rosdistro/master/ros.key -o /usr/share/keyrings/ros-archive-keyring.gpg
+          echo "deb [arch=$(dpkg --print-architecture) signed-by=/usr/share/keyrings/ros-archive-keyring.gpg] http://packages.ros.org/ros2/ubuntu $(lsb_release -cs) main" | sudo tee /etc/apt/sources.list.d/ros2.list > /dev/null
+          sudo apt-get update
+          sudo apt-get install -y ros-humble-ros-base python3-pip
+
+      - name: Install Rust
+        uses: dtolnay/rust-toolchain@stable
+
+      - name: Install colcon
+        run: |
+          source /opt/ros/humble/setup.bash
+          pip3 install --user colcon-common-extensions
+          echo "$HOME/.local/bin" >> $GITHUB_PATH
+          export PATH="$HOME/.local/bin:$PATH"
+          which colcon
+
+      - name: make ci-full
+        run: |
+          source /opt/ros/humble/setup.bash
+          cd ${{ env.RUST_DIR }} && make ci-full
+        env:
+          PYTHON3_EXECUTABLE: /usr/bin/python3

.gitmodules

@@ -1,15 +1,3 @@
-[submodule "robonix/driver/realsense_ros2/src/realsense-ros"]
-    path = robonix/driver/realsense_ros2/src/realsense-ros
-	url = https://github.com/enkerewpo/realsense-ros.git
-[submodule "robonix/driver/mid360/src/livox_ros_driver2"]
-	path = robonix/driver/mid360/src/livox_ros_driver2
-	url = https://github.com/enkerewpo/livox_ros_driver2.git
-[submodule "robonix/driver/ranger_ros2/src/ranger_ros2"]
-	path = robonix/driver/ranger_ros2/src/ranger_ros2
-	url = https://github.com/enkerewpo/ranger_ros2
-[submodule "robonix/driver/ranger_ros2/src/ugv_sdk"]
-	path = robonix/driver/ranger_ros2/src/ugv_sdk
-	url = https://github.com/enkerewpo/ugv_sdk.git
 [submodule "ros2-client"]
 	path = rust/lib/ros2-client
 	url = https://github.com/enkerewpo/ros2-client

rust/Makefile

@@ -6,7 +6,7 @@
 # Tab completion: bash-completion is installed in Docker container
 # If tab completion doesn't work, ensure bash-completion is installed and enabled
 
-.PHONY: help build build-cli build-core build-sdk debug release install install-cli install-core source-sdk env clean test test-all test-rust test-python test-cpp test-ros2 benchmark check setup-dev fmt test-framework
+.PHONY: help build build-cli build-core build-sdk debug release install install-cli install-core source-sdk env clean test test-all test-rust test-python test-cpp test-ros2 benchmark check setup-dev fmt fmt-check ci-rust ci-full test-framework
 .DEFAULT_GOAL := help
 
 # Default ROS2 distribution (can be overridden)
@@ -49,9 +49,14 @@ help:
 	@echo "Development commands:"
 	@echo "  make setup-dev      - Setup development environment (link provider directory)"
 	@echo "  make fmt            - Format code using cargo fmt"
+	@echo "  make fmt-check      - Check format only (CI; fails if not formatted)"
 	@echo "  make check          - Run cargo check on all Rust projects"
 	@echo "  make clean          - Clean build artifacts"
 	@echo ""
+	@echo "CI (single entry points):"
+	@echo "  make ci-rust        - Format check + cargo check + build (no ROS2)"
+	@echo "  make ci-full        - Build SDK + Rust (requires ROS2 sourced, colcon on PATH)"
+	@echo ""
 	@echo "Test commands:"
 	@echo "  make test           - Run all tests (Rust, Python)"
 	@echo "  make test-rust      - Run Rust CLI stress tests"
@@ -111,6 +116,13 @@ build-sdk:
 # Alias for backward compatibility
 buildsdk: build-sdk
 
+# CI targets (single entry points; extend these when adding packages)
+ci-rust: fmt-check check build
+	@echo "✓ ci-rust done"
+
+ci-full: build-sdk build
+	@echo "✓ ci-full done (requires: ROS2 sourced, colcon on PATH)"
+
 # Install commands
 install: install-cli install-core
 	@echo "✓ All binaries installed successfully"
@@ -216,6 +228,13 @@ fmt:
 	cd $(CORE_DIR) && cargo fmt
 	@echo "✓ Code formatted"
 
+# Check formatting only (for CI; fails if not formatted)
+fmt-check:
+	@echo "Checking code format with cargo fmt -- --check..."
+	cd $(CLI_DIR) && cargo fmt -- --check
+	cd $(CORE_DIR) && cargo fmt -- --check
+	@echo "✓ Format check passed"
+
 # Check and test
 check:
 	@echo "Running cargo check on all Rust projects..."