Commit e5d83ec
committed
Update sym class hand written mthd type annotation
The handwritten methods of the sym classes all already accepted lists
(in addition to ndarrays) because they were backed by the autogenerated
functions, which support both. So, I updated the type annotations
accordingly.
Also, since the auto-generated methods already have adequeate error
messages, I removed the hand-written ones as they didn't cover certain
corner cases well (like 2d row vectors), and in order to make them
complete, they would just be duplicates of what was autogenerated more
or less anyway.
Also, fixed the type signature of the camera cal __init__ methods. This
should have been done previously, but was overlooked.
Also made a small fix to the corresponding jinja template's indenting to
match the style we use elsewhere.1 parent 93c689d commit e5d83ec
12 files changed
Lines changed: 33 additions & 177 deletions
File tree
- gen/python/sym
- symforce/codegen/backends/python/templates
- cam_package
- geo_package
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments