Commit b969232
fix(cli): 0.7.1 — Windows sym ask exit-crash + sym groups dns-sd ENOENT
Found by COO's cross-machine Windows test of 0.7.0 (install + daemon
lifecycle + cross-machine mesh all passed; these were the only 2 bugs):
- sym ask: broadcast socket closed with .end() left a named-pipe handle
mid-close; process.exit then tripped a libuv UV_HANDLE_CLOSING assertion
on Windows (0xC0000409). Now socket.destroy() + clear the timer so the
handle is fully gone before exit.
- sym groups: spawn dns-sd ENOENT on Windows (no Apple Bonjour) now degrades
gracefully — node still meshes via bonjour-service; sym join works directly.
Also fixed a timer-ordering (TDZ) bug in the discovery path.
Full suite 168/168; sym ask/groups exit cleanly.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>1 parent a9b50fa commit b969232
4 files changed
Lines changed: 47 additions & 12 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
5 | 14 | | |
6 | 15 | | |
7 | 16 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
219 | 219 | | |
220 | 220 | | |
221 | 221 | | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
222 | 237 | | |
223 | 238 | | |
224 | | - | |
225 | | - | |
226 | | - | |
227 | | - | |
228 | | - | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
229 | 244 | | |
230 | 245 | | |
231 | | - | |
232 | | - | |
| 246 | + | |
233 | 247 | | |
234 | 248 | | |
| 249 | + | |
235 | 250 | | |
236 | 251 | | |
237 | 252 | | |
| |||
647 | 662 | | |
648 | 663 | | |
649 | 664 | | |
650 | | - | |
| 665 | + | |
| 666 | + | |
| 667 | + | |
| 668 | + | |
| 669 | + | |
| 670 | + | |
| 671 | + | |
| 672 | + | |
| 673 | + | |
| 674 | + | |
| 675 | + | |
| 676 | + | |
651 | 677 | | |
652 | 678 | | |
653 | 679 | | |
| |||
669 | 695 | | |
670 | 696 | | |
671 | 697 | | |
672 | | - | |
| 698 | + | |
673 | 699 | | |
674 | 700 | | |
675 | 701 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| |||
0 commit comments