fix(evm): allow passing 0 as reset value without replacing with max

Author: ice-chillios

.changeset/whole-ghosts-win.md

@@ -0,0 +1,5 @@
+---
+"@swapkit/toolboxes": patch
+---
+
+fix(evm): allow passing 0 as reset value without replacing with max

.github/workflows/pr-test.yml

@@ -0,0 +1,27 @@
+name: PR Test
+env:
+  GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+  TEST_API_KEY: ${{ secrets.TEST_API_KEY }}
+
+on:
+  workflow_dispatch:
+  pull_request_target:
+    branches:
+      - develop
+
+jobs:
+  build-lint-test:
+    if: contains(github.event.pull_request.title, ':tada:') == false
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Setup Repo
+        uses: ./tools/github/setup-repo
+
+      - run: bun build:ci
+      - run: bun lint
+      - run: bun type-check:ci
+
+      - name: Test
+        run: bun test:ci

.github/workflows/build-test-publish.yml .github/workflows/release.yml.github/workflows/build-test-publish.yml renamed to .github/workflows/release.yml

@@ -1,15 +1,11 @@
-name: Run build, test & publish
+name: Release
 env:
   GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
   NPM_TOKEN: ${{ secrets.NPM_AUTH_TOKEN }}
   TEST_API_KEY: ${{ secrets.TEST_API_KEY }}
 
 on:
   workflow_dispatch:
-  pull_request_target:
-    branches:
-      - develop
-      - v4
   push:
     branches:
       - develop
@@ -18,12 +14,9 @@ on:
 
 jobs:
   build-lint-test:
-    if: contains(github.event.pull_request.title, ':tada:') == false
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
-        with:
-          fetch-depth: 0
 
       - name: Setup Repo
         uses: ./tools/github/setup-repo
@@ -33,17 +26,14 @@ jobs:
       - run: bun type-check:ci
 
       - name: Test
-        if: contains(github.ref_name, 'nightly') == false
+        if: github.ref_name == 'nightly'
         run: bun test:ci
 
   publish:
-    if: contains(github.ref_name, 'develop') || contains(github.ref_name, 'beta') || contains(github.ref_name, 'nightly')
     needs: [build-lint-test]
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
-        with:
-          fetch-depth: 0
 
       - name: Setup Repo
         uses: ./tools/github/setup-repo
@@ -58,29 +48,28 @@ jobs:
         shell: bash
         id: deployment-params
         run: |
-          git config --global user.email "github-actions[bot]@users.noreply.github.com"
-          git config --global user.name "github-actions[bot]"
+          git config --global user.email "swapkit[bot]@users.noreply.github.com"
+          git config --global user.name "swapkit[bot]"
           echo "publishName=${{ github.ref_name == 'develop' && 'Release' || github.ref_name }}" >> $GITHUB_OUTPUT
 
       - name: Exit pre changeset
-        if: contains(github.ref_name, 'nightly')
+        if: github.ref_name == 'nightly'
         continue-on-error: true
         run: bun changeset pre exit
 
       - name: Change nightly changeset
-        if: contains(github.ref_name, 'nightly')
+        if: github.ref_name == 'nightly'
         run: bun changeset version --snapshot nightly
 
       - name: Change beta changeset
-        if: contains(github.ref_name, 'beta')
+        if: github.ref_name == 'beta'
         continue-on-error: true
         run: bun changeset pre enter beta
 
-
       - name: Create Pull Request or Publish to npm
         id: changesets
+        if: github.ref_name == 'develop'
         uses: changesets/action@v1.4.10
-        if: contains(github.ref_name, 'develop')
         with:
           title: ":tada: Publish ${{ steps.deployment-params.outputs.publishName }}"
           version: bun version-bump
@@ -89,8 +78,8 @@ jobs:
           createGithubReleases: false
 
       - name: Publish Beta to npm
+        if: github.ref_name == 'beta'
         uses: changesets/action@v1.4.10
-        if: contains(github.ref_name, 'beta')
         with:
           title: ":tada: Publish Beta"
           version: bun version-bump
@@ -99,8 +88,8 @@ jobs:
           createGithubReleases: false
 
       - name: Publish Nightly to npm
+        if: github.ref_name == 'nightly'
         uses: changesets/action@v1.4.10
-        if: contains(github.ref_name, 'nightly')
         with:
           title: ":tada: Publish Nightly"
           version: bun version-bump
@@ -110,7 +99,6 @@ jobs:
 
   build-docs:
     runs-on: ubuntu-latest
-    if: contains(github.ref_name, 'develop') || contains(github.ref_name, 'beta') || contains(github.ref_name, 'nightly')
     needs: [build-lint-test]
     permissions:
       contents: read
@@ -119,8 +107,6 @@ jobs:
 
     steps:
       - uses: actions/checkout@v4
-        with:
-          fetch-depth: 0
 
       - name: Setup Repo
         uses: ./tools/github/setup-repo

packages/toolboxes/src/evm/toolbox/baseEVMToolbox.ts

@@ -745,13 +745,15 @@ function getCreateApprovalTx({ provider, signer, chain }: ToolboxWrapParams) {
     const from = (await signer?.getAddress()) || fromParam;
 
     const createTx = getCreateContractTxObject({ provider, chain });
-    const funcParams = [spenderAddress, BigInt(amount || MAX_APPROVAL)];
+    const approvalAmount = ["bigint", "number"].includes(typeof amount)
+      ? (amount as bigint | number)
+      : amount || MAX_APPROVAL;
 
     const txObject = await createTx({
       contractAddress: assetAddress,
       abi: erc20ABI,
       funcName: "approve",
-      funcParams,
+      funcParams: [spenderAddress, BigInt(approvalAmount)],
       txOverrides: { from },
     });
 

packages/wallets/src/types.ts

@@ -40,7 +40,7 @@ export type Callback = (
 
 export type VultisigCosmosProvider = {
   request(
-    request: { method: string; params?: Array<any> | Record<string, any> },
+    request: { method: string; params?: any[] | Record<string, any> },
     callback?: Callback,
   ): Promise<any>;
 };

packages/wallets/src/vultisig/walletHelpers.ts

@@ -109,7 +109,6 @@ async function transaction({
   });
 }
 
-// biome-ignore lint/complexity/noExcessiveCognitiveComplexity: <explanation>
 export async function getVultisigAddress(chain: Chain) {
   try {
     const eipProvider = (await getVultisigProvider(chain)) as Eip1193Provider;