...

Author: vearutop

.golangci.yml

@@ -5,6 +5,9 @@ run:
 linters:
   default: all
   disable:
+    - gocyclo
+    - errcheck
+    - err113
     - nilnil
     - noinlineerr
     - wsl_v5
@@ -31,6 +34,11 @@ linters:
     - varnamelen
     - wrapcheck
   settings:
+    gocognit:
+      min-complexity: 50
+    funlen:
+      statements: 65
+      lines: 120
     dupl:
       threshold: 100
     errcheck:
@@ -42,6 +50,8 @@ linters:
       locale: US
     unparam:
       check-exported: true
+    cyclop:
+      max-complexity: 25
   exclusions:
     generated: lax
     rules:

cmd/jsoncompact/main.go

@@ -16,7 +16,7 @@ import (
 )
 
 // The function is a bit lengthy, but I'm not sure if it would be more approachable divided in several functions.
-func main() { //nolint
+func main() {
 	var (
 		input, output  string
 		length         int

diff/ascii.go

@@ -63,15 +63,23 @@ func (f *ASCIIFormatter) Format(diff Diff) (result string, err error) {
 func (f *ASCIIFormatter) formatObject(left map[string]interface{}, df Diff) {
 	f.addLineWith("{")
 	f.push("ROOT", len(left), false)
-	f.processObject(left, df.Deltas())
+
+	if err := f.processObject(left, df.Deltas()); err != nil {
+		panic(err)
+	}
+
 	f.pop()
 	f.addLineWith("}")
 }
 
 func (f *ASCIIFormatter) formatArray(left []interface{}, df Diff) {
 	f.addLineWith("[")
 	f.push("ROOT", len(left), true)
-	f.processArray(left, df.Deltas())
+
+	if err := f.processArray(left, df.Deltas()); err != nil {
+		panic(err)
+	}
+
 	f.pop()
 	f.addLineWith("]")
 }
@@ -89,9 +97,7 @@ func (f *ASCIIFormatter) processArray(array []interface{}, deltas []Delta) error
 
 	// additional Added
 	for _, delta := range deltas {
-		switch delta.(type) {
-		case *Added:
-			d := delta.(*Added)
+		if d, ok := delta.(*Added); ok {
 			// skip items already processed
 			if int(d.Position.(Index)) < len(array) {
 				continue
@@ -136,7 +142,7 @@ func (f *ASCIIFormatter) processItem(value interface{}, deltas []Delta, position
 				case map[string]interface{}:
 					// ok
 				default:
-					return errors.New("Type mismatch")
+					return errors.New("type mismatch")
 				}
 
 				o := value.(map[string]interface{})
@@ -146,7 +152,11 @@ func (f *ASCIIFormatter) processItem(value interface{}, deltas []Delta, position
 				f.print("{")
 				f.closeLine()
 				f.push(positionStr, len(o), false)
-				f.processObject(o, d.Deltas)
+
+				if err := f.processObject(o, d.Deltas); err != nil {
+					return err
+				}
+
 				f.pop()
 				f.newLine(ASCIISame)
 				f.print("}")
@@ -158,7 +168,7 @@ func (f *ASCIIFormatter) processItem(value interface{}, deltas []Delta, position
 				case []interface{}:
 					// ok
 				default:
-					return errors.New("Type mismatch")
+					return errors.New("type mismatch")
 				}
 
 				a := value.([]interface{})
@@ -168,7 +178,11 @@ func (f *ASCIIFormatter) processItem(value interface{}, deltas []Delta, position
 				f.print("[")
 				f.closeLine()
 				f.push(positionStr, len(a), true)
-				f.processArray(a, d.Deltas)
+
+				if err := f.processArray(a, d.Deltas); err != nil {
+					return err
+				}
+
 				f.pop()
 				f.newLine(ASCIISame)
 				f.print("]")