Skip to content

Commit b1cf89b

Browse files
committed
fix rubocop warnings
1 parent 4e89f79 commit b1cf89b

File tree

6 files changed

+11
-11
lines changed

6 files changed

+11
-11
lines changed

sample/issue922.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ module Polars
3838
module DataFrame
3939
class TableAdapter
4040
def call(df, name) # rubocop:disable Metrics/MethodLength, Naming/MethodParameterName
41-
columns = df.columns.each_with_object({}) { |header, hash| hash[header] = LogicalType::VARCHAR }
41+
columns = df.columns.to_h { |header| [header, LogicalType::VARCHAR] }
4242
counter = 0
4343
height = df.height
4444
width = df.columns.length

sample/issue930.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,11 @@
77

88
module DuckDB
99
class Connection
10-
def register_as_table(name, io, csv_options: {}) # rubocop:disable Metrics/MethodLength, Metrics/AbcSize
10+
def register_as_table(name, io, csv_options: {}) # rubocop:disable Metrics/MethodLength
1111
csv = CSV.new(io, **csv_options)
1212
headers = csv.first.headers
1313
csv.rewind
14-
columns = headers.each_with_object({}) { |header, hash| hash[header] = LogicalType::VARCHAR }
14+
columns = headers.to_h { |header| [header, LogicalType::VARCHAR] }
1515
tf = DuckDB::TableFunction.create(
1616
name:,
1717
columns:

sample/issue930_benchmark.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,11 @@
77

88
module DuckDB
99
class Connection
10-
def register_as_table_with_table_function(name, io, csv_options: {}) # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
10+
def register_as_table_with_table_function(name, io, csv_options: {}) # rubocop:disable Metrics/MethodLength
1111
csv = CSV.new(io, **csv_options)
1212
headers = csv.first.headers
1313
csv.rewind
14-
columns = headers.each_with_object({}) { |header, hash| hash[header] = LogicalType::VARCHAR }
14+
columns = headers.to_h { |header| [header, LogicalType::VARCHAR] }
1515
tf = DuckDB::TableFunction.create(
1616
name:,
1717
columns:

test/duckdb_test/column_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ def test_type
143143
def test_logical_type
144144
logical_types = @columns.map(&:logical_type)
145145

146-
assert(logical_types.all? { |logical_type| logical_type.is_a?(DuckDB::LogicalType) })
146+
assert(logical_types.all?(DuckDB::LogicalType))
147147
end
148148

149149
def test_name

test/duckdb_test/logical_type_test.rb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ def test_list_child_type
192192
list_column.logical_type.child_type
193193
end
194194

195-
assert(child_types.all? { |child_type| child_type.is_a?(DuckDB::LogicalType) })
195+
assert(child_types.all?(DuckDB::LogicalType))
196196
assert_equal(%i[integer varchar], child_types.map(&:type))
197197
end
198198

@@ -210,7 +210,7 @@ def test_array_child_type
210210
array_column.logical_type.child_type
211211
end
212212

213-
assert(child_types.all? { |child_type| child_type.is_a?(DuckDB::LogicalType) })
213+
assert(child_types.all?(DuckDB::LogicalType))
214214
assert_equal(%i[integer varchar], child_types.map(&:type))
215215
end
216216

@@ -258,7 +258,7 @@ def test_union_each_member_type
258258
union_logical_type = union_column.logical_type
259259
member_types = union_logical_type.each_member_type.to_a
260260

261-
assert(member_types.all? { |member_type| member_type.is_a?(DuckDB::LogicalType) })
261+
assert(member_types.all?(DuckDB::LogicalType))
262262
assert_equal(%i[integer varchar], member_types.map(&:type))
263263
end
264264

@@ -281,7 +281,7 @@ def test_struct_each_child_type
281281
struct_logical_type = struct_column.logical_type
282282
child_types = struct_logical_type.each_child_type.to_a
283283

284-
assert(child_types.all? { |child_type| child_type.is_a?(DuckDB::LogicalType) })
284+
assert(child_types.all?(DuckDB::LogicalType))
285285
assert_equal(%i[varchar integer], child_types.map(&:type))
286286
end
287287

test/duckdb_test/table_function_csv_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ def call(csv, name, columns: nil)
2929
def columns(csv)
3030
headers = csv.first.headers
3131
csv.rewind
32-
headers.each_with_object({}) { |header, hash| hash[header] = DuckDB::LogicalType::VARCHAR }
32+
headers.to_h { |header| [header, DuckDB::LogicalType::VARCHAR] }
3333
end
3434

3535
# read a line from the csv and write to output, return number of rows written

0 commit comments

Comments
 (0)