Commit 8a07180
committed
refactor: Standardize object allocation to rb_class_new_instance
Replaced rb_funcall(..., "allocate", 0) with rb_class_new_instance(0, NULL, ...)
in all TableFunction callbacks for consistency.
Changed:
- init_callback: InitInfo allocation
- execute_callback: FunctionInfo and DataChunk allocation
This matches the pattern already used in bind_callback and data_chunk.get_vector.
Benefits:
- More direct and efficient (no method lookup)
- Consistent across all wrapper object creation
- Standard Ruby C extension pattern
Addresses CodeRabbit review feedback on PR #1103.1 parent c445619 commit 8a07180
1 file changed
+3
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
268 | 268 | | |
269 | 269 | | |
270 | 270 | | |
271 | | - | |
| 271 | + | |
272 | 272 | | |
273 | 273 | | |
274 | 274 | | |
| |||
330 | 330 | | |
331 | 331 | | |
332 | 332 | | |
333 | | - | |
| 333 | + | |
334 | 334 | | |
335 | 335 | | |
336 | 336 | | |
337 | 337 | | |
338 | | - | |
| 338 | + | |
339 | 339 | | |
340 | 340 | | |
341 | 341 | | |
| |||
0 commit comments