fix(preset-cli): Clean up logic to display upgrade checks in console

Author: sullivanpj

packages/plugin-console/src/components/console-builtin.tsx

@@ -2527,7 +2527,6 @@ export function DividerFunctionDeclaration() {
         <TSDocExample>
           {`divider({ width: 50, border: "primary" }); // Writes a divider line of width 50 with primary border.`}
         </TSDocExample>
-
         <TSDocParam name="options">
           {`Options for formatting the divider line.`}
         </TSDocParam>
@@ -2782,14 +2781,9 @@ export function SpinnerFunctionDeclaration() {
           }
 
           const streamsToHook = new Set([this.#stream]);
-          if (this.#stream === process.stdout || this.#stream === process.stderr) {
-            if (isInteractive(process.stdout)) {
-              streamsToHook.add(process.stdout);
-            }
-
-            if (isInteractive(process.stderr)) {
-              streamsToHook.add(process.stderr);
-            }
+          if (isInteractive && (this.#stream === process.stdout || this.#stream === process.stderr)) {
+            streamsToHook.add(process.stdout);
+            streamsToHook.add(process.stderr);
           }
 
           for (const stream of streamsToHook) {
@@ -2838,15 +2832,14 @@ export function SpinnerFunctionDeclaration() {
         }
 
         #stopWithIcon(icon: string, message: string) {
-          return this.stop(\`\${icon} \${message ?? this.#message}\`);
+          return this.stop(\` \${icon}  \${message ?? this.#message}\`);
         }
 
         #render() {
           if (this.#isDeferringRender) {
             return;
           }
 
-          const useSynchronizedOutput = isInteractive;
           if (this.#currentFrame === -1 || Date.now() - this.#lastSpinnerFrameTime >= this.#interval) {
             this.#currentFrame = ++this.#currentFrame % this.#frames.length;
             this.#lastSpinnerFrameTime = Date.now();
@@ -2857,7 +2850,7 @@ export function SpinnerFunctionDeclaration() {
             display += "\\n";
           }
 
-          if (useSynchronizedOutput) {
+          if (isInteractive) {
             this.#withSynchronizedOutput(() => {
               this.clear();
               this.#write(display);

packages/preset-cli/src/components/banner-function-declaration.tsx

@@ -115,7 +115,8 @@ export function BannerFunctionDeclaration(
           footer={footer.value}
           variant={variant}
           consoleFnName={consoleFnName}
-          command={command}>
+          command={command}
+          insertNewlineAfterDescription>
           {code`const titleLines = [${titleLines.value
             .map(line => JSON.stringify(line.trim()))
             .join(", ")}];
@@ -242,7 +243,9 @@ export function BannerFunctionDeclaration(
             <ElseClause>{code`spinner.success("Currently running the latest version of ${getAppTitle(
               context,
               true
-            )}.");`}</ElseClause>
+            )}.");
+            writeLine("");
+            `}</ElseClause>
           </IfStatement>
         </Show>
       </FunctionDeclaration>

packages/preset-cli/src/components/command-entry.tsx

@@ -85,7 +85,7 @@ export function CommandEntry(props: CommandEntryProps) {
           prompts: "prompts"
         })}
         builtinImports={defu(builtinImports ?? {}, {
-          env: ["env", "isDevelopment", "isDebug"],
+          env: ["env", "isDevelopment", "isDebug", "paths"],
           console: [
             "debug",
             "info",
@@ -96,7 +96,8 @@ export function CommandEntry(props: CommandEntryProps) {
             "colors",
             "stripAnsi",
             "writeLine",
-            "splitText"
+            "splitText",
+            "createSpinner"
           ],
           utils: [
             "useApp",

packages/preset-cli/src/index.tsx

@@ -78,6 +78,7 @@ export const plugin = <TContext extends CLIPresetContext = CLIPresetContext>(
                 builtinImports={{
                   console: [
                     "info",
+                    "debug",
                     "warn",
                     "help",
                     "error",
@@ -88,7 +89,8 @@ export const plugin = <TContext extends CLIPresetContext = CLIPresetContext>(
                     "colors",
                     "writeLine",
                     "splitText",
-                    "stripAnsi"
+                    "stripAnsi",
+                    "createSpinner"
                   ],
                   utils: [
                     "useApp",
@@ -111,7 +113,8 @@ export const plugin = <TContext extends CLIPresetContext = CLIPresetContext>(
                     "checkForUpdates",
                     "isCheckForUpdatesRequired",
                     "upgrade"
-                  ]
+                  ],
+                  env: ["env", "paths"]
                 }}
                 prefix={
                   <>

packages/preset-script/src/components/banner-function-declaration.tsx

@@ -106,6 +106,7 @@ export interface BannerFunctionBodyDeclarationProps extends BannerFunctionDeclar
   description: string;
   insertNewlineBeforeCommand?: boolean;
   insertNewlineBeforeBanner?: boolean;
+  insertNewlineAfterDescription?: boolean;
 }
 
 /**
@@ -127,7 +128,8 @@ export function BannerFunctionBodyDeclaration(
     command,
     children,
     insertNewlineBeforeCommand = false,
-    insertNewlineBeforeBanner = true
+    insertNewlineBeforeBanner = true,
+    insertNewlineAfterDescription = false
   } = props;
 
   const theme = useTheme();
@@ -255,7 +257,17 @@ export function BannerFunctionBodyDeclaration(
             theme.borderStyles.banner.outline[variant].right
           }"), { consoleFn: console.${consoleFnName} });
         });
-
+        ${
+          insertNewlineAfterDescription
+            ? `writeLine(colors.border.banner.outline.${variant}("${
+                theme.borderStyles.banner.outline[variant].left
+              }") + " ".repeat(Math.max(process.stdout.columns - ${
+                bannerPadding.value
+              })) + colors.border.banner.outline.${variant}("${
+                theme.borderStyles.banner.outline[variant].right
+              }"), { consoleFn: console.${consoleFnName} });`
+            : ""
+        }
         writeLine(colors.border.banner.outline.${variant}("${
           theme.borderStyles.banner.outline[variant].bottomLeft
         }") + ${