[@xstate/store] Fix emitted event type being overridden (#5197)

* Add failing test

* Fix

* Changeset

* Remove console log

Author: davidkpiano

.changeset/lazy-dolphins-sort.md

@@ -0,0 +1,5 @@
+---
+'@xstate/store': patch
+---
+
+The emitted event type can no longer be accidentally overridden in the emitted event payload. See #5196 for the issue.

packages/xstate-store/src/store.ts

@@ -420,8 +420,8 @@ export function createStoreTransition<
         get: (_, eventType: string) => {
           return (payload: any) => {
             effects.push({
-              type: eventType,
-              ...payload
+              ...payload,
+              type: eventType
             });
           };
         }

packages/xstate-store/test/store.test.ts

@@ -481,3 +481,52 @@ it('works with typestates', () => {
     context.data satisfies null;
   }
 });
+
+it('the emit type is not overridden by the payload', () => {
+  const spy = jest.fn();
+  type Context = {
+    drawer?: Drawer | null;
+  };
+
+  type Drawer = {
+    id: string;
+  };
+
+  const context: Context = {
+    drawer: null
+  };
+
+  const drawersBridgeStore = createStore({
+    emits: {
+      drawerOpened: (_payload: { drawer: Drawer }) => {
+        // ...
+      }
+    },
+    context,
+    on: {
+      openDrawer: (context, event: { drawer: Drawer }, enqueue) => {
+        enqueue.emit.drawerOpened(event);
+
+        return {
+          ...context,
+          drawer: event.drawer
+        };
+      }
+    }
+  });
+
+  drawersBridgeStore.on('drawerOpened', (event) => {
+    // expect to be called here
+    spy(event);
+  });
+
+  drawersBridgeStore.send({
+    type: 'openDrawer',
+    drawer: { id: 'a' }
+  });
+
+  expect(spy).toHaveBeenCalledWith({
+    type: 'drawerOpened',
+    drawer: { id: 'a' }
+  });
+});