remove redundant if-conditions

ssbssa · ssbssa · commit 93f24f3c33d0 · 2021-11-21T16:23:34.000+01:00
diff --git a/mgwhelp/dwarf_pe.c b/mgwhelp/dwarf_pe.c
@@ -240,17 +240,17 @@ dwarf_pe_init_link(const wchar_t *image,
                     (PBYTE)pe_obj->pNtHeaders +
                     sizeof(DWORD) +
                     sizeof(IMAGE_FILE_HEADER) );
-            if (imagebase) *imagebase = opt->ImageBase;
+            *imagebase = opt->ImageBase;
         }
         else if (sooh==sizeof(IMAGE_OPTIONAL_HEADER64)) {
             PIMAGE_OPTIONAL_HEADER64 opt = (PIMAGE_OPTIONAL_HEADER64)(
                     (PBYTE)pe_obj->pNtHeaders +
                     sizeof(DWORD) +
                     sizeof(IMAGE_FILE_HEADER) );
-            if (imagebase) *imagebase = opt->ImageBase;
+            *imagebase = opt->ImageBase;
         }
         else {
-            if (imagebase) *imagebase = 0;
+            *imagebase = 0;
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -240,17 +240,17 @@ dwarf_pe_init_link(const wchar_t *image,`
`240`	`240`	`(PBYTE)pe_obj->pNtHeaders +`
`241`	`241`	`sizeof(DWORD) +`
`242`	`242`	`sizeof(IMAGE_FILE_HEADER) );`
`243`		`- if (imagebase) *imagebase = opt->ImageBase;`
	`243`	`+ *imagebase = opt->ImageBase;`
`244`	`244`	`}`
`245`	`245`	`else if (sooh==sizeof(IMAGE_OPTIONAL_HEADER64)) {`
`246`	`246`	`PIMAGE_OPTIONAL_HEADER64 opt = (PIMAGE_OPTIONAL_HEADER64)(`
`247`	`247`	`(PBYTE)pe_obj->pNtHeaders +`
`248`	`248`	`sizeof(DWORD) +`
`249`	`249`	`sizeof(IMAGE_FILE_HEADER) );`
`250`		`- if (imagebase) *imagebase = opt->ImageBase;`
	`250`	`+ *imagebase = opt->ImageBase;`
`251`	`251`	`}`
`252`	`252`	`else {`
`253`		`- if (imagebase) *imagebase = 0;`
	`253`	`+ *imagebase = 0;`
`254`	`254`	`}`
`255`	`255`	`}`
`256`	`256`