vpp: fix bogus errors (#1642)

* Fix vpp error messages logged incorrectly

* More bogus error message during syncd start

Author: yue-fred-gao

vslib/vpp/SaiObjectDB.cpp

@@ -282,7 +282,7 @@ SaiObjectDB::get(
     // check if the object exists
     status = m_switch_db->get(object_type, id, 0, &attr);
     if (status != SAI_STATUS_SUCCESS) {
-        SWSS_LOG_WARN("Object is not found in SwitchVpp %s:%s", sai_serialize_object_type(object_type).c_str(), id.c_str());
+        SWSS_LOG_NOTICE("Object is not found in SwitchVpp %s:%s", sai_serialize_object_type(object_type).c_str(), id.c_str());
         return std::shared_ptr<SaiDBObject>();
     }
     /*
@@ -306,9 +306,16 @@ SaiObject::get_linked_object(
     attr.id = link_attr_id;
     status = get_attr(attr);
     if (status != SAI_STATUS_SUCCESS) {
-        SWSS_LOG_ERROR("Failed to get attribute %d from object %s", link_attr_id, m_id.c_str());
+        SWSS_LOG_NOTICE("Attribute %d not found in object %s", link_attr_id, m_id.c_str());
         return std::shared_ptr<SaiDBObject>();
     }
+
+    if (RealObjectIdManager::objectTypeQuery(attr.value.oid) != linked_object_type) {
+        SWSS_LOG_INFO("Linked object type mismatch: expected %d, got %d. Will return empty object.",
+                       linked_object_type, RealObjectIdManager::objectTypeQuery(attr.value.oid));
+        return std::shared_ptr<SaiDBObject>();
+    }
+
     linked_obj_id = sai_serialize_object_id(attr.value.oid);
 
     return m_switch_db->get_sai_object(linked_object_type, linked_obj_id);

vslib/vpp/SwitchVpp.cpp

@@ -6,6 +6,10 @@
 
 #include "vppxlate/SaiIntfStats.h"
 
+#include "SwitchVppUtils.h"
+
+#include <vector>
+
 using namespace saivs;
 
 // TODO init vpp
@@ -1038,7 +1042,26 @@ sai_status_t SwitchVpp::createPort(
 
     auto sid = sai_serialize_object_id(object_id);
 
-    CHECK_STATUS(create_internal(SAI_OBJECT_TYPE_PORT, sid, switch_id, attr_count, attr_list));
+    const sai_attribute_value_t     *oper_status;
+    uint32_t                        attr_index;
+    sai_status_t status = find_attrib_in_list(attr_count, attr_list,
+                            SAI_PORT_ATTR_OPER_STATUS, &oper_status, &attr_index);
+
+    if (status == SAI_STATUS_ITEM_NOT_FOUND) {
+        // SAI_PORT_ATTR_OPER_STATUS not found, create a copy of attr_list and add it
+        std::vector<sai_attribute_t> modified_attr_list(attr_list, attr_list + attr_count);
+
+        // Add the missing SAI_PORT_ATTR_OPER_STATUS attribute
+        sai_attribute_t oper_status_attr;
+        oper_status_attr.id = SAI_PORT_ATTR_OPER_STATUS;
+        oper_status_attr.value.s32 = SAI_PORT_OPER_STATUS_UNKNOWN;
+        modified_attr_list.push_back(oper_status_attr);
+
+        CHECK_STATUS(create_internal(SAI_OBJECT_TYPE_PORT, sid, switch_id,
+                                   static_cast<uint32_t>(modified_attr_list.size()), modified_attr_list.data()));
+    } else {
+        CHECK_STATUS(create_internal(SAI_OBJECT_TYPE_PORT, sid, switch_id, attr_count, attr_list));
+    }
 
     return create_port_dependencies(object_id);
 }
@@ -1436,7 +1459,7 @@ sai_status_t SwitchVpp::get(
 
     if (it == objectHash.end())
     {
-        SWSS_LOG_ERROR("not found %s:%s",
+        SWSS_LOG_INFO("not found %s:%s",
                 sai_serialize_object_type(objectType).c_str(),
                 serializedObjectId.c_str());
 
@@ -1815,3 +1838,28 @@ sai_status_t SwitchVpp::querySwitchHashAlgorithmCapability(
 
     return SAI_STATUS_SUCCESS;
 }
+
+sai_status_t SwitchVpp::refresh_read_only(
+        _In_ const sai_attr_metadata_t *meta,
+        _In_ sai_object_id_t object_id)
+{
+    SWSS_LOG_ENTER();
+
+    // Handle VPP-specific refresh read-only logic first
+    if (meta->objecttype == SAI_OBJECT_TYPE_BFD_SESSION)
+    {
+        switch (meta->attrid)
+        {
+            case SAI_BFD_SESSION_ATTR_STATE:
+                // VPP stores BFD session state in m_objectHash and will update it
+                // when BFD state changed. So we don't need to refresh.
+                return SAI_STATUS_SUCCESS;
+
+            default:
+                break;
+        }
+    }
+
+    // For all other cases, delegate to the base class implementation
+    return SwitchStateBase::refresh_read_only(meta, object_id);
+}

vslib/vpp/SwitchVpp.h

@@ -73,6 +73,10 @@ namespace saivs
             virtual sai_status_t create_port_serdes_per_port(
                     _In_ sai_object_id_t port_id) override;
 
+            virtual sai_status_t refresh_read_only(
+                    _In_ const sai_attr_metadata_t *meta,
+                    _In_ sai_object_id_t object_id) override;
+
         private: // from vpp VirtualSwitchSaiInterface
 
             void setPortStats(

vslib/vpp/SwitchVppHostif.cpp

@@ -591,7 +591,8 @@ const char* SwitchVpp::hwif_to_tap_name(
 
     if (it == m_hwif_hostif_map.end())
     {
-        SWSS_LOG_ERROR("failed to find hostif info entry for hwif device: %s", tap_name.c_str());
+        // not all hwif are mapped to hostif, e.g. vxlan tunnel interface, bvi interface.
+        SWSS_LOG_NOTICE("failed to find hostif info entry for hwif device: %s", tap_name.c_str());
 
         return "Unknown";
     }

vslib/vpp/SwitchVppRif.cpp

@@ -154,11 +154,11 @@ std::string get_intf_name_for_prefix (
     is_v6 = (route_entry.destination.addr_family == SAI_IP_ADDR_FAMILY_IPV6) ? true : false;
 
     std::string full_if_name = "";
-        bool found = vpp_get_intf_name_for_prefix(route_entry.destination, is_v6, full_if_name);
-        if (found == false)
-        {
+    bool found = vpp_get_intf_name_for_prefix(route_entry.destination, is_v6, full_if_name);
+    if (found == false)
+    {
         auto prefix_str = sai_serialize_ip_prefix(route_entry.destination);
-            SWSS_LOG_ERROR("host interface for prefix not found: %s", prefix_str.c_str());
+        SWSS_LOG_INFO("host interface for prefix not found: %s", prefix_str.c_str());
     }
     return full_if_name;
 
@@ -359,7 +359,7 @@ bool SwitchVpp::vpp_get_hwif_name (
 
     if (found == false)
     {
-        SWSS_LOG_ERROR("host interface for port id %s not found", sai_serialize_object_id(object_id).c_str());
+        SWSS_LOG_NOTICE("host interface for port id %s not found", sai_serialize_object_id(object_id).c_str());
         return false;
     }
 
@@ -486,7 +486,7 @@ sai_status_t SwitchVpp::asyncIntfStateUpdate(const char *hwif_name, bool link_up
     auto port_oid = getPortIdFromIfName(std::string(tap));
 
     if (port_oid == SAI_NULL_OBJECT_ID) {
-        SWSS_LOG_NOTICE("Failed find port oid for tap interface %s", tap);
+        SWSS_LOG_NOTICE("Failed find port oid for tap interface %s. Ignore the update.", tap);
         return SAI_STATUS_SUCCESS;
     }
 
@@ -884,6 +884,16 @@ sai_status_t SwitchVpp::vpp_add_del_intf_ip_addr_norif (
 
     is_v6 = (route_entry.destination.addr_family == SAI_IP_ADDR_FAMILY_IPV6) ? true : false;
 
+    // Check if this is an IPv6 link-local address (fe80::/10)
+    if (is_v6) {
+        const uint8_t* addr = route_entry.destination.addr.ip6;
+        // Link-local addresses start with fe80::/10, so first byte is 0xfe and second byte is 0x80-0xbf
+        if (addr[0] == 0xfe && (addr[1] & 0xc0) == 0x80) {
+            SWSS_LOG_INFO("Skipping configuring interface IP: IPv6 link-local address");
+            return SAI_STATUS_SUCCESS;
+        }
+    }
+
     std::string full_if_name;
     std::string ip_prefix_str;
 

vslib/vpp/SwitchVppRoute.cpp

@@ -103,7 +103,7 @@ void create_vpp_nexthop_entry (
 
 sai_status_t SwitchVpp::IpRouteAddRemove(
         _In_ const SaiObject* route_obj,
-            _In_ bool is_add)
+        _In_ bool is_add)
 {
     SWSS_LOG_ENTER();
 
@@ -112,6 +112,20 @@ sai_status_t SwitchVpp::IpRouteAddRemove(
     sai_object_id_t              next_hop_oid;
     sai_attribute_t              attr;
     std::string                  serializedObjectId = route_obj->get_id();
+    int                          packet_action = SAI_PACKET_ACTION_FORWARD;
+
+    attr.id = SAI_ROUTE_ENTRY_ATTR_PACKET_ACTION;
+    status = route_obj->get_attr(attr);
+    if (status == SAI_STATUS_SUCCESS) {
+        packet_action = attr.value.s32;
+    }
+
+    // We should program drop routes
+    if (packet_action != SAI_PACKET_ACTION_FORWARD) {
+        SWSS_LOG_NOTICE("Ignoring ip route %s: action is not forward: %d",
+                        serializedObjectId.c_str(), packet_action);
+        return SAI_STATUS_SUCCESS;
+    }
 
     attr.id = SAI_ROUTE_ENTRY_ATTR_NEXT_HOP_ID;
     CHECK_STATUS_QUIET(route_obj->get_mandatory_attr(attr));