Update API controller tests to assert unauthorized access instead of redirect

Author: skoruba

templates/install.ps1

@@ -1,6 +1,6 @@
-param([string] $packagesVersions, [string]$gitBranchName = 'dev')
+param([string] $packagesVersions)
 
-./0-build-template.ps1 -packagesVersions $packagesVersions -gitBranchName $gitBranchName
+./0-build-template.ps1 -packagesVersions $packagesVersions
 
 ./1-add-docker-support.ps1
 

tests/Skoruba.Duende.IdentityServer.Admin.Api.IntegrationTests/Tests/ApiResourcesControllerTests.cs

@@ -37,10 +37,7 @@ public async Task GetApiResourcesWithoutPermissions()
             var response = await Client.GetAsync("api/apiresources");
 
             // Assert
-            response.StatusCode.Should().Be(HttpStatusCode.Redirect);
-
-            //The redirect to login
-            response.Headers.Location?.ToString().Should().Contain(AuthenticationConsts.AccountLoginPage);
+            response.StatusCode.Should().Be(HttpStatusCode.Unauthorized);
         }
     }
-}
+}

tests/Skoruba.Duende.IdentityServer.Admin.Api.IntegrationTests/Tests/ClientsControllerTests.cs

@@ -36,10 +36,7 @@ public async Task GetClientsWithoutPermissions()
             var response = await Client.GetAsync("api/clients");
 
             // Assert
-            response.StatusCode.Should().Be(HttpStatusCode.Redirect);
-
-            //The redirect to login
-            response.Headers.Location.ToString().Should().Contain(AuthenticationConsts.AccountLoginPage);
+            response.StatusCode.Should().Be(HttpStatusCode.Unauthorized);
         }
     }
 }

tests/Skoruba.Duende.IdentityServer.Admin.Api.IntegrationTests/Tests/IdentityResourcesControllerTests.cs

@@ -36,10 +36,7 @@ public async Task GetIdentityResourcesWithoutPermissions()
             var response = await Client.GetAsync("api/identityresources");
 
             // Assert
-            response.StatusCode.Should().Be(HttpStatusCode.Redirect);
-
-            //The redirect to login
-            response.Headers.Location.ToString().Should().Contain(AuthenticationConsts.AccountLoginPage);
+            response.StatusCode.Should().Be(HttpStatusCode.Unauthorized);
         }
     }
-}
+}

tests/Skoruba.Duende.IdentityServer.Admin.Api.IntegrationTests/Tests/RolesControllerTests.cs

@@ -36,10 +36,7 @@ public async Task GetRolesWithoutPermissions()
             var response = await Client.GetAsync("api/roles");
 
             // Assert
-            response.StatusCode.Should().Be(HttpStatusCode.Redirect);
-
-            //The redirect to login
-            response.Headers.Location.ToString().Should().Contain(AuthenticationConsts.AccountLoginPage);
+            response.StatusCode.Should().Be(HttpStatusCode.Unauthorized);
         }
     }
-}
+}

tests/Skoruba.Duende.IdentityServer.Admin.Api.IntegrationTests/Tests/UsersControllerTests.cs

@@ -36,10 +36,7 @@ public async Task GetRolesWithoutPermissions()
             var response = await Client.GetAsync("api/users");
 
             // Assert
-            response.StatusCode.Should().Be(HttpStatusCode.Redirect);
-
-            //The redirect to login
-            response.Headers.Location.ToString().Should().Contain(AuthenticationConsts.AccountLoginPage);
+            response.StatusCode.Should().Be(HttpStatusCode.Unauthorized);
         }
     }
-}
+}