Ticket #306 : Always publish events when references are updated

Author: habarthierry-hue

src/Scim/SimpleIdServer.Scim/Api/BaseApiController.cs

@@ -281,7 +281,7 @@ protected async Task<IActionResult> InternalAdd(RepresentationParameter jobj)
             try
             {
                 var command = new AddRepresentationCommand(_resourceType, jobj, _uriProvider.GetAbsoluteUriWithVirtualPath());
-                var scimRepresentation = await _addRepresentationCommandHandler.Handle(command, IsPublishEvtsEnabled);
+                var scimRepresentation = await _addRepresentationCommandHandler.Handle(command);
                 var location = GetLocation(scimRepresentation);
                 var content = scimRepresentation.ToResponse(location, false, mergeExtensionAttributes: _options.MergeExtensionAttributes);
                 if (IsPublishEvtsEnabled) await _busControl.Publish(new RepresentationAddedEvent(scimRepresentation.Id, scimRepresentation.Version, GetResourceType(scimRepresentation.ResourceType), content, _options.IncludeToken ? Request.GetToken() : string.Empty));
@@ -314,7 +314,7 @@ protected async Task<IActionResult> InternalDelete(string id)
             _logger.LogInformation(string.Format(Global.DeleteResource, id));
             try
             {
-                var representation = await _deleteRepresentationCommandHandler.Handle(new DeleteRepresentationCommand(id, _resourceType, _uriProvider.GetAbsoluteUriWithVirtualPath()), IsPublishEvtsEnabled);
+                var representation = await _deleteRepresentationCommandHandler.Handle(new DeleteRepresentationCommand(id, _resourceType, _uriProvider.GetAbsoluteUriWithVirtualPath()));
                 if(IsPublishEvtsEnabled) await _busControl.Publish(new RepresentationRemovedEvent(id, representation.Version, GetResourceType(_resourceType), _options.IncludeToken ? Request.GetToken() : string.Empty));
                 return new StatusCodeResult((int)HttpStatusCode.NoContent);
             }
@@ -340,7 +340,7 @@ protected async Task<IActionResult> InternalUpdate(string id, RepresentationPara
             _logger.LogInformation(Global.UpdateResource, id);
             try
             {
-                var newRepresentation = await _replaceRepresentationCommandHandler.Handle(new ReplaceRepresentationCommand(id, _resourceType, representationParameter, _uriProvider.GetAbsoluteUriWithVirtualPath()), IsPublishEvtsEnabled);
+                var newRepresentation = await _replaceRepresentationCommandHandler.Handle(new ReplaceRepresentationCommand(id, _resourceType, representationParameter, _uriProvider.GetAbsoluteUriWithVirtualPath()));
                 var location = GetLocation(newRepresentation);
                 var content = newRepresentation.ToResponse(location, false, mergeExtensionAttributes: _options.MergeExtensionAttributes);
                 if (IsPublishEvtsEnabled) await _busControl.Publish(new RepresentationUpdatedEvent(newRepresentation.Id, newRepresentation.Version, GetResourceType(_resourceType), content, _options.IncludeToken ? Request.GetToken() : string.Empty));
@@ -383,7 +383,7 @@ protected async Task<IActionResult> InternalPatch(string id, PatchRepresentation
             _logger.LogInformation(string.Format(Global.PatchResource, id, patchRepresentation == null ? string.Empty : JsonConvert.SerializeObject(patchRepresentation)));
             try
             {
-                var patchResult = await _patchRepresentationCommandHandler.Handle(new PatchRepresentationCommand(id, ResourceType, patchRepresentation, _uriProvider.GetAbsoluteUriWithVirtualPath()), IsPublishEvtsEnabled);
+                var patchResult = await _patchRepresentationCommandHandler.Handle(new PatchRepresentationCommand(id, ResourceType, patchRepresentation, _uriProvider.GetAbsoluteUriWithVirtualPath()));
                 if (!patchResult.IsPatched) return NoContent();
                 var newRepresentation = patchResult.SCIMRepresentation;
                 var location = GetLocation(newRepresentation);

src/Scim/SimpleIdServer.Scim/Commands/Handlers/AddRepresentationCommandHandler.cs

@@ -37,7 +37,7 @@ public AddRepresentationCommandHandler(
             _representationReferenceSync = representationReferenceSync;
         }
 
-        public async Task<SCIMRepresentation> Handle(AddRepresentationCommand addRepresentationCommand, bool isPublishEvtsEnabled)
+        public async Task<SCIMRepresentation> Handle(AddRepresentationCommand addRepresentationCommand)
         {
             var requestedSchemas = addRepresentationCommand.Representation.Schemas;
             if (!requestedSchemas.Any())
@@ -85,7 +85,7 @@ public async Task<SCIMRepresentation> Handle(AddRepresentationCommand addReprese
                 await transaction.Commit();
             }
 
-            if (isPublishEvtsEnabled) await Notify(references);
+            await Notify(references);
             scimRepresentation.ApplyEmptyArray();
             return scimRepresentation;
         }

src/Scim/SimpleIdServer.Scim/Commands/Handlers/DeleteRepresentationCommandHandler.cs

@@ -26,7 +26,7 @@ public DeleteRepresentationCommandHandler(ISCIMRepresentationCommandRepository s
             _representationReferenceSync = representationReferenceSync;
         }
 
-        public async Task<SCIMRepresentation> Handle(DeleteRepresentationCommand request, bool isPublishEvtsEnabled)
+        public async Task<SCIMRepresentation> Handle(DeleteRepresentationCommand request)
         {
             var representation = await _scimRepresentationQueryRepository.FindSCIMRepresentationById(request.Id, request.ResourceType);
             if (representation == null)
@@ -46,7 +46,7 @@ public async Task<SCIMRepresentation> Handle(DeleteRepresentationCommand request
                 await transaction.Commit();
             }
 
-            if (isPublishEvtsEnabled) await Notify(references);
+            await Notify(references);
             return representation;
         }
     }

src/Scim/SimpleIdServer.Scim/Commands/Handlers/PatchRepresentationCommandHandler.cs

@@ -39,15 +39,15 @@ public PatchRepresentationCommandHandler(
             _options = options.Value;
         }
 
-        public async Task<PatchRepresentationResult> Handle(PatchRepresentationCommand patchRepresentationCommand, bool isPublishEvtsEnabled)
+        public async Task<PatchRepresentationResult> Handle(PatchRepresentationCommand patchRepresentationCommand)
         {
             CheckParameter(patchRepresentationCommand.PatchRepresentation);
             var existingRepresentation = await _scimRepresentationQueryRepository.FindSCIMRepresentationById(patchRepresentationCommand.Id);
             if (existingRepresentation == null) throw new SCIMNotFoundException(string.Format(Global.ResourceNotFound, patchRepresentationCommand.Id));
-            return await UpdateRepresentation(existingRepresentation, patchRepresentationCommand, isPublishEvtsEnabled);
+            return await UpdateRepresentation(existingRepresentation, patchRepresentationCommand);
         }
 
-        private async Task<PatchRepresentationResult> UpdateRepresentation(SCIMRepresentation existingRepresentation, PatchRepresentationCommand patchRepresentationCommand, bool isPublishEvtsEnabled)
+        private async Task<PatchRepresentationResult> UpdateRepresentation(SCIMRepresentation existingRepresentation, PatchRepresentationCommand patchRepresentationCommand)
         {
             var attributeMappings = await _scimAttributeMappingQueryRepository.GetBySourceResourceType(existingRepresentation.ResourceType);
             var patchResult = existingRepresentation.ApplyPatches(patchRepresentationCommand.PatchRepresentation.Operations, attributeMappings, _options.IgnoreUnsupportedCanonicalValues);
@@ -65,7 +65,7 @@ private async Task<PatchRepresentationResult> UpdateRepresentation(SCIMRepresent
                 await transaction.Commit();
             }
 
-            if (isPublishEvtsEnabled) await Notify(references);
+            await Notify(references);
             existingRepresentation.ApplyEmptyArray();
             return PatchRepresentationResult.Ok(existingRepresentation);
         }

src/Scim/SimpleIdServer.Scim/Commands/Handlers/ReplaceRepresentationCommandHandler.cs

@@ -38,7 +38,7 @@ public ReplaceRepresentationCommandHandler(
             _representationReferenceSync = representationReferenceSync;
         }
 
-        public async Task<SCIMRepresentation> Handle(ReplaceRepresentationCommand replaceRepresentationCommand, bool isPublishEvtsEnabled)
+        public async Task<SCIMRepresentation> Handle(ReplaceRepresentationCommand replaceRepresentationCommand)
         {
             var requestedSchemas = replaceRepresentationCommand.Representation.Schemas;
             if (!requestedSchemas.Any())
@@ -87,7 +87,7 @@ public async Task<SCIMRepresentation> Handle(ReplaceRepresentationCommand replac
                 await transaction.Commit();
             }
 
-            if (isPublishEvtsEnabled) await Notify(references);
+            await Notify(references);
             existingRepresentation.ApplyEmptyArray();
             return existingRepresentation;
         }

src/Scim/SimpleIdServer.Scim/Infrastructure/ISCIMCommandHandler.cs

@@ -6,6 +6,6 @@ namespace SimpleIdServer.Scim.Infrastructure
 {
     public interface ISCIMCommandHandler<TCommand, TResult> where TCommand : ISCIMCommand<TResult>
     {
-        Task<TResult> Handle(TCommand request, bool isPublishEvtsEnabled);
+        Task<TResult> Handle(TCommand request);
     }
 }