Ticket #334 : Publish integration event RepresentationReferenceAttributeUpdatedEvent when the reference attribute is updated

Author: habarthierry-hue

src/Scim/SimpleIdServer.Scim.Startup/Consumers/IntegrationEventConsumer.cs

@@ -9,7 +9,8 @@ namespace SimpleIdServer.Scim.Startup.Consumers
 {
     public class IntegrationEventConsumer : IConsumer<RepresentationAddedEvent>,
         IConsumer<RepresentationRemovedEvent>,
-        IConsumer<RepresentationUpdatedEvent>
+        IConsumer<RepresentationUpdatedEvent>,
+        IConsumer<RepresentationReferenceAttributeUpdatedEvent>
     {
         private readonly ILogger<IntegrationEventConsumer> _logger;
 
@@ -35,5 +36,11 @@ public Task Consume(ConsumeContext<RepresentationUpdatedEvent> context)
             _logger.LogInformation($"Event received : Representation '{context.Message.ResourceType}' has been updated");
             return Task.CompletedTask;
         }
+
+        public Task Consume(ConsumeContext<RepresentationReferenceAttributeUpdatedEvent> context)
+        {
+            _logger.LogInformation($"Event received : Representation '{context.Message.ResourceType}' has been updated");
+            return Task.CompletedTask;
+        }
     }
 }

src/Scim/SimpleIdServer.Scim.Startup/Startup.cs

@@ -148,6 +148,15 @@ public void ConfigureServices(IServiceCollection services)
             .AddSchemas(schemas)
             .AddAttributeMapping(new List<SCIMAttributeMapping>
             {
+                new SCIMAttributeMapping
+                {
+                    Id = Guid.NewGuid().ToString(),
+                    SourceAttributeId = groupSchema.Attributes.First(a => a.Name == "members").Id,
+                    SourceResourceType = StandardSchemas.GroupSchema.ResourceType,
+                    SourceAttributeSelector = "members",
+                    TargetResourceType = StandardSchemas.UserSchema.ResourceType,
+                    TargetAttributeId = userSchema.Attributes.First(a => a.Name == "groups").Id
+                },
                 new SCIMAttributeMapping
                 {
                     Id = Guid.NewGuid().ToString(),

src/Scim/SimpleIdServer.Scim/Commands/Handlers/BaseCommandHandler.cs

@@ -19,6 +19,7 @@ protected async Task Notify(RepresentationSyncResult result)
         {
             foreach(var removeAttr in result.RemoveAttrEvts) await _busControl.Publish(removeAttr);
             foreach(var addAttr in result.AddAttrEvts) await _busControl.Publish(addAttr);
+            foreach (var updateAttr in result.UpdateAttrEvts) await _busControl.Publish(updateAttr);
         }
     }
 }

src/Scim/SimpleIdServer.Scim/ExternalEvents/RepresentationReferenceAttributeUpdatedEvent.cs

@@ -0,0 +1,17 @@
+// Copyright (c) SimpleIdServer. All rights reserved.
+// Licensed under the Apache License, Version 2.0. See LICENSE in the project root for license information.
+using Newtonsoft.Json.Linq;
+
+namespace SimpleIdServer.Scim.ExternalEvents
+{
+    public class RepresentationReferenceAttributeUpdatedEvent : BaseReferenceAttributeEvent
+    {
+        public RepresentationReferenceAttributeUpdatedEvent()
+        {
+        }
+
+        public RepresentationReferenceAttributeUpdatedEvent(string id, int version, string resourceType, string representationAggregateId, string schemaAttributeId, string attributeFullPath, JObject representation) : base(id, version, resourceType, representationAggregateId, schemaAttributeId, attributeFullPath, representation)
+        {
+        }
+    }
+}

src/Scim/SimpleIdServer.Scim/Helpers/RepresentationReferenceSync.cs

@@ -1,5 +1,6 @@
 // Copyright (c) SimpleIdServer. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See LICENSE in the project root for license information.
+using Microsoft.CodeAnalysis;
 using SimpleIdServer.Scim.Domains;
 using SimpleIdServer.Scim.DTOs;
 using SimpleIdServer.Scim.Exceptions;
@@ -10,6 +11,7 @@
 using System.Diagnostics;
 using System.Linq;
 using System.Threading.Tasks;
+using static MassTransit.ValidationResultExtensions;
 
 namespace SimpleIdServer.Scim.Helpers
 {
@@ -96,7 +98,7 @@ public  async Task<RepresentationSyncResult> Sync(string resourceType, SCIMRepre
 				if (duplicateIds.Any()) throw new SCIMUniquenessAttributeException(string.Format(Global.DuplicateReference, string.Join(",", duplicateIds.Select(_ => _.Key).Distinct())));
 				await RemoveReferenceAttributes(result, idsToBeRemoved, attributeMapping, newSourceScimRepresentation, location);
 				await AddReferenceAttributes(result, newIds, attributeMapping, newSourceScimRepresentation, location, targetSchemas.First(s => s.ResourceType == attributeMapping.TargetResourceType));
-				await UpdateReferenceAttributes(existingIds, attributeMapping, newSourceScimRepresentation, patchOperations, targetSchemas.First(s => s.ResourceType == attributeMapping.TargetResourceType));
+				await UpdateReferenceAttributes(result, existingIds, attributeMapping, newSourceScimRepresentation, patchOperations, targetSchemas.First(s => s.ResourceType == attributeMapping.TargetResourceType), location: location);
 			}
 
 			return result;
@@ -141,19 +143,21 @@ protected virtual async Task AddReferenceAttributes(RepresentationSyncResult res
 					var sourceSchema = sourceScimRepresentation.Schemas.First(s => s.ResourceType == attributeMapping.SourceResourceType && s.GetAttributeById(attributeMapping.SourceAttributeId) != null);
 					UpdateScimRepresentation(targetRepresentation, sourceScimRepresentation, attributeMapping.TargetAttributeId, attributeMapping.SourceResourceType, targetSchema, out isAttrUpdated);
 					UpdateScimRepresentation(sourceScimRepresentation, targetRepresentation, attributeMapping.SourceAttributeId, attributeMapping.TargetResourceType, sourceSchema, out bool b);
-					if (!isAttrUpdated && !string.IsNullOrWhiteSpace(attributeMapping.TargetAttributeId)) result.AddReferenceAttr(targetRepresentation, attributeMapping.TargetAttributeId, targetSchema.GetAttributeById(attributeMapping.TargetAttributeId).FullPath, sourceScimRepresentation.Id, location);
+					if (!string.IsNullOrWhiteSpace(attributeMapping.TargetAttributeId) && !isAttrUpdated)
+						result.AddReferenceAttr(targetRepresentation, attributeMapping.TargetAttributeId, targetSchema.GetAttributeById(attributeMapping.TargetAttributeId).FullPath, sourceScimRepresentation.Id, location);
 					result.AddRepresentation(targetRepresentation);
 				}
 			}
 		}
 
-		protected virtual async Task UpdateReferenceAttributes(IEnumerable<string> ids, SCIMAttributeMapping attributeMapping, SCIMRepresentation sourceScimRepresentation, ICollection<SCIMPatchResult> patchOperations, SCIMSchema targetSchema)
+		protected virtual async Task UpdateReferenceAttributes(RepresentationSyncResult result, IEnumerable<string> ids, SCIMAttributeMapping attributeMapping, SCIMRepresentation sourceScimRepresentation, ICollection<SCIMPatchResult> patchOperations, SCIMSchema targetSchema, string location)
         {
 			if (!patchOperations.Any(p => IsDisplayName(p.Attr.FullPath))) return;
 			var targetRepresentations = await _scimRepresentationCommandRepository.FindSCIMRepresentationByIds(ids, attributeMapping.TargetResourceType);
 			foreach (var targetRepresentation in targetRepresentations)
 			{
 				UpdateScimRepresentation(targetRepresentation, sourceScimRepresentation, attributeMapping.TargetAttributeId, attributeMapping.SourceResourceType, targetSchema, out bool isAttrUpdated);
+				result.UpdateReferenceAttr(targetRepresentation, attributeMapping.TargetAttributeId, targetSchema.GetAttributeById(attributeMapping.TargetAttributeId).FullPath, sourceScimRepresentation.Id, location);
 				targetRepresentation.SetUpdated(DateTime.UtcNow);
 			}
 		}

src/Scim/SimpleIdServer.Scim/Helpers/RepresentationSyncResult.cs

@@ -18,12 +18,14 @@ public RepresentationSyncResult(IResourceTypeResolver resourceTypeResolver)
             Representations = new List<SCIMRepresentation>();
             RemoveAttrEvts = new List<RepresentationReferenceAttributeRemovedEvent>();
             AddAttrEvts = new List<RepresentationReferenceAttributeAddedEvent>();
+            UpdateAttrEvts = new List<RepresentationReferenceAttributeUpdatedEvent>();
             _resourceTypeResolver = resourceTypeResolver;
         }
 
         public ICollection<SCIMRepresentation> Representations { get; set; }
         public ICollection<RepresentationReferenceAttributeRemovedEvent> RemoveAttrEvts { get; set; }
         public ICollection<RepresentationReferenceAttributeAddedEvent> AddAttrEvts { get; set; }
+        public ICollection<RepresentationReferenceAttributeUpdatedEvent> UpdateAttrEvts { get; set; }
 
         public void AddRepresentation(SCIMRepresentation representation)
         {
@@ -48,6 +50,15 @@ public void RemoveReferenceAttr(SCIMRepresentation representation, string schema
             ProcessReferenceAttr(RemoveAttrEvts, representation, schemaAttributeId, newEvt, value);
         }
 
+        public void UpdateReferenceAttr(SCIMRepresentation representation, string schemaAttributeId, string fullPath, string value, string location)
+        {
+            location = $"{location}/{_resourceTypeResolver.ResolveByResourceType(representation.ResourceType).ControllerName}/{representation.Id}";
+            var obj = representation.Duplicate().ToResponse(location, false, addEmptyArray: true);
+            var newEvt = new RepresentationReferenceAttributeUpdatedEvent(Guid.NewGuid().ToString(), representation.Version, representation.ResourceType, representation.Id, schemaAttributeId, fullPath, obj);
+            newEvt.Values.Add(value);
+            ProcessReferenceAttr(UpdateAttrEvts, representation, schemaAttributeId, newEvt, value);
+        }
+
         private void ProcessReferenceAttr<T>(ICollection<T> evts, SCIMRepresentation representation, string schemaAttributeId, T newEvt, string value) where T : BaseReferenceAttributeEvent
         {
             var evt = evts.FirstOrDefault(e => e.RepresentationAggregateId == representation.Id && e.SchemaAttributeId == schemaAttributeId);