Skip to content

Commit b63b0cb

Browse files
committed
fix: use full ActionId key for cycleBorderStyle override
The action override was using 'cycleBorderStyle' instead of 'view::cycleBorderStyle', causing a TypeScript error. Also adds a pre-commit hook with husky to run type checking before commits, preventing similar errors in the future.
1 parent 67b21f5 commit b63b0cb

File tree

4 files changed

+23
-2
lines changed

4 files changed

+23
-2
lines changed

.husky/pre-commit

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
npm run typecheck

package-lock.json

Lines changed: 17 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,9 @@
1212
"tauri": "tauri",
1313
"test": "vitest",
1414
"test:run": "vitest run",
15-
"test:coverage": "vitest run --coverage"
15+
"typecheck": "tsc --noEmit",
16+
"test:coverage": "vitest run --coverage",
17+
"prepare": "husky"
1618
},
1719
"dependencies": {
1820
"@dnd-kit/core": "^6.3.1",
@@ -47,6 +49,7 @@
4749
"@types/react": "^19.1.8",
4850
"@types/react-dom": "^19.1.6",
4951
"@vitejs/plugin-react": "^4.6.0",
52+
"husky": "^9.1.7",
5053
"jsdom": "^27.4.0",
5154
"tailwindcss": "^4.1.18",
5255
"typescript": "~5.8.3",

src/App.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2551,7 +2551,7 @@ function App() {
25512551
subtle: 'visible',
25522552
visible: 'theme',
25532553
};
2554-
overrides.cycleBorderStyle = `Border Style: ${effectiveBorderStyle}${nextStyle[effectiveBorderStyle]}`;
2554+
overrides['view::cycleBorderStyle'] = `Border Style: ${effectiveBorderStyle}${nextStyle[effectiveBorderStyle]}`;
25552555

25562556
return overrides;
25572557
}, [config.apps.fileManager, config.apps.terminal, config.apps.editor, effectiveBorderStyle]);

0 commit comments

Comments
 (0)