Fix crash upon provided usages inside property hooks (#302)

Author: janedbal

src/Collector/ProvidedUsagesCollector.php

@@ -7,6 +7,7 @@
 use PHPStan\Analyser\Scope;
 use PHPStan\Collectors\Collector;
 use PHPStan\Reflection\ReflectionProvider;
+use ShipMonk\PHPStan\DeadCode\Enum\MemberType;
 use ShipMonk\PHPStan\DeadCode\Excluder\MemberUsageExcluder;
 use ShipMonk\PHPStan\DeadCode\Graph\ClassMemberUsage;
 use ShipMonk\PHPStan\DeadCode\Graph\CollectedUsage;
@@ -85,7 +86,7 @@ private function validateUsage(
     {
         $origin = $usage->getOrigin();
         $originClass = $origin->getClassName();
-        $originMethod = $origin->getMemberName();
+        $originMember = $origin->getMemberName();
 
         $context = sprintf(
             "It emitted usage of %s by %s for node '%s' in '%s' on line %s",
@@ -101,8 +102,14 @@ private function validateUsage(
                 throw new LogicException("Class '{$originClass}' does not exist. $context");
             }
 
-            if ($originMethod !== null && !$this->reflectionProvider->getClass($originClass)->hasMethod($originMethod)) {
-                throw new LogicException("Method '{$originMethod}' does not exist in class '$originClass'. $context");
+            if ($originMember !== null) {
+                if ($origin->getMemberType() === MemberType::METHOD && !$this->reflectionProvider->getClass($originClass)->hasMethod($originMember)) {
+                    throw new LogicException("Method '{$originMember}' does not exist in class '$originClass'. $context");
+                }
+
+                if ($origin->getMemberType() === MemberType::PROPERTY && !$this->reflectionProvider->getClass($originClass)->hasNativeProperty($originMember)) {
+                    throw new LogicException("Property '{$originMember}' does not exist in class '$originClass'. $context");
+                }
             }
         }
     }

tests/Rule/DeadCodeRuleTest.php

@@ -1026,6 +1026,7 @@ public static function provideFiles(): Traversable
         yield 'provider-nette-tester' => [__DIR__ . '/data/providers/nette-tester.php'];
         yield 'provider-apiphpdoc' => [__DIR__ . '/data/providers/api-phpdoc.php', self::requiresPhp(8_01_00)];
         yield 'provider-enum' => [__DIR__ . '/data/providers/enum.php', self::requiresPhp(8_01_00)];
+        yield 'provider-enum-hooks' => [__DIR__ . '/data/providers/enum-hooks.php', self::requiresPhp(8_01_00)];
         yield 'provider-builtin' => [__DIR__ . '/data/providers/builtin.php'];
         yield 'provider-stream-wrapper' => [__DIR__ . '/data/providers/stream-wrapper.php'];
 

tests/Rule/data/providers/enum-hooks.php

@@ -0,0 +1,19 @@
+<?php declare(strict_types = 1);
+
+namespace EnumProviderHooks;
+
+enum Status: string {
+    case Active = 'active';
+    case Inactive = 'inactive'; // error: Unused EnumProviderHooks\Status::Inactive
+}
+
+class Project
+{
+    public Status $status {
+        get => Status::from('active');
+    }
+}
+
+function test(): void {
+    echo (new Project())->status;
+}