buttonVariants

[wellington-vell]

in the latest update the button variant was added the size="icon-sm" and size="icon-lg"
i was wandering why not just add another variant like format or something like that and utilize the compoundVariants parameter from cva to handle the combination ?

[qyrn]

The current approach with size="icon-sm" and size="icon-lg" keeps the API simpler and more intuitive:

1. Single prop - Users only need to specify size, not both size and format
2. 2. Explicit naming - icon-sm clearly communicates the intent (small icon button)
3. 3. Fewer combinations - Using compoundVariants with separate format prop would create a matrix of combinations to maintain
4. 4. Consistency - Follows the pattern of other UI libraries (like Radix themes)
      While compoundVariants is powerful for complex conditional styling, it adds complexity when the use case is straightforward. The icon sizes are essentially just preset dimensions that don't need to combine with other variants.