Commit 95e7bef
chore: Bug fixes and improvements to review agents and workflow [NOTASK] (#1092)
* fix: Correct bash syntax error in post-inline-suggestions.sh
Fix missing = operator on line 71 causing 'command not found' error.
Changes:
- Line 71: comment_body+''
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
* fix: Add missing 'changes' dependency to summary job
The summary job references needs.changes.outputs.docs but was missing
'changes' in its needs array, causing the condition to fail.
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
* test: Add manual test workflow for inline suggestions script
This workflow can be triggered manually to validate the bash script
works correctly before merging to master.
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
* feat: Add conditional agent execution based on PR type
- Classify PRs as 'rename' or 'content' based on git diff analysis
- Rename PRs (>70% renames, <5 significant content changes): Skip voice-tone and terminology
- Content PRs: Run all agents (voice-tone, terminology)
- Limit suggestions to 100 per PR to prevent overwhelming output
- Show PR type in review summary
This reduces noise on rename/refactor PRs while maintaining full
editorial review for content changes.
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
* chore: Reduce suggestion limit from 100 to 50
Even 100 inline suggestions is overwhelming. Cap at 50 for better UX.
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
* feat: Preserve full suggestions list as downloadable artifact
When >50 suggestions are found:
- First 50 appear as inline comments (actionable)
- Full list uploaded as 'all-editorial-suggestions' artifact
- Comment links to workflow run to download complete list
- Suggestions retained for 30 days
This allows reviewing all suggestions without overwhelming the PR UI.
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
* chore: Raise suggestion limit from 50 to 60
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
* docs: Restructure Claude documentation for clarity
CLAUDE.md (user-facing):
- Added Quick Start section
- Comprehensive PR review workflow explanation
- Manual re-run instructions
- Artifact download guide
- Troubleshooting section
- Directory structure with file counts
.claude/README.md (technical):
- Balanced coverage of skills AND agents
- Agent definitions and configurations
- GitHub Actions integration details
- Development guidelines
- Architecture overview
Both files now follow industry-standard documentation structure with
clear separation between user guide and technical implementation.
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
* style: Convert headings to sentence case
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
* docs: simplify terminology section in CLAUDE.md
Remove specific terminology examples (Tower, RNA-Seq, UI elements) from user guide.
Users can reference .claude/agents/terminology.md for detailed rules.
* docs: add workflows and architecture section to CLAUDE.md
Add clear explanation of editorial and API workflows with step-by-step flow descriptions and component listings.
* docs: clarify .claude directory contents in README
Specify 'agents, skills, and configuration' instead of just 'configuration' for clarity.
* docs: fix heading level for Related documentation section
Change from level 3 (###) to level 2 (##) to match other main sections.
* docs: complete API workflow components list
Add missing workflow file, scripts, and trigger details to match actual implementation.
* Update CLAUDE.md
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Justine Geffen <justinegeffen@users.noreply.github.com>
* fixes from copilot
* Update .claude/README.md
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Justine Geffen <justinegeffen@users.noreply.github.com>
* added syntax checker
* removed test file
* Update .claude/README.md
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Justine Geffen <justinegeffen@users.noreply.github.com>
* Update CLAUDE.md
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Justine Geffen <justinegeffen@users.noreply.github.com>
* final fixes
* final bug fix
---------
Signed-off-by: Justine Geffen <justinegeffen@users.noreply.github.com>
Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>1 parent 72722e3 commit 95e7bef
File tree
5 files changed
+523
-77
lines changed- .claude
- .github
- scripts
- workflows
5 files changed
+523
-77
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
6 | 11 | | |
7 | | - | |
| 12 | + | |
8 | 13 | | |
9 | | - | |
10 | | - | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
11 | 20 | | |
12 | 21 | | |
13 | 22 | | |
14 | 23 | | |
15 | 24 | | |
16 | | - | |
17 | | - | |
| 25 | + | |
18 | 26 | | |
19 | 27 | | |
20 | 28 | | |
21 | 29 | | |
22 | 30 | | |
23 | | - | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
24 | 161 | | |
25 | 162 | | |
26 | 163 | | |
| 164 | + | |
| 165 | + | |
27 | 166 | | |
28 | | - | |
29 | | - | |
30 | | - | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
31 | 213 | | |
32 | 214 | | |
33 | 215 | | |
34 | | - | |
| 216 | + | |
35 | 217 | | |
36 | | - | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
68 | 68 | | |
69 | 69 | | |
70 | 70 | | |
71 | | - | |
| 71 | + | |
72 | 72 | | |
73 | 73 | | |
74 | 74 | | |
| |||
0 commit comments