Fix issue #205: Update SBCCallRegistry with actual B-leg Call-ID

When Call-ID is rewritten via call profile (Call-ID=$ci_mo-b2b) or when
transparent_dlg_id is enabled, the registry now stores the actual Call-ID
used in SIP messages instead of the auto-generated one.

This fixes REFER with Replaces header failures where lookupCall would
return an auto-generated Call-ID that doesn't match any active dialog.

Changes:
- Added SBCCallRegistry::updateCallId() method
- Update A->B registry mapping after Call-ID changes in:
  * transparent_dlg_id mode (SBCCallLeg constructor)
  * call_profile.callid rewrite (applyBProfile)

Author: Marcel Hecko

apps/sbc/SBCCallLeg.cpp

@@ -182,6 +182,9 @@ SBCCallLeg::SBCCallLeg(SBCCallLeg* caller, AmSipDialog* p_dlg,
     dlg->setCallid(caller->dlg->getCallid());
     dlg->setExtLocalTag(caller->dlg->getRemoteTag());
     dlg->cseq = caller->dlg->r_cseq;
+    // Update registry with the actual Call-ID that will be used in SIP messages
+    // The A->B mapping uses the caller's (A-leg's) local tag as the key
+    SBCCallRegistry::updateCallId(caller->dlg->getLocalTag(), caller->dlg->getCallid());
   }
 
   // copy RTP rate limit from caller leg
@@ -411,8 +414,12 @@ void SBCCallLeg::applyBProfile()
   }
 
   // was read from caller but reading directly from profile now
-  if (!call_profile.callid.empty()) 
+  if (!call_profile.callid.empty()) {
     dlg->setCallid(call_profile.callid);
+    // Update registry with the actual Call-ID that will be used in SIP messages
+    // The A->B mapping uses the other leg's (A-leg's) local tag as the key
+    SBCCallRegistry::updateCallId(getOtherId(), call_profile.callid);
+  }
 
   dlg->setContact(call_profile.bleg_contact);
 }

apps/sbc/SBCCallRegistry.cpp

@@ -50,6 +50,19 @@ void SBCCallRegistry::updateCall(const string& ltag, const string& other_rtag) {
   DBG("SBCCallRegistry: Updated call '%s' - rtag to: '%s'\n", ltag.c_str(), other_rtag.c_str());
 }
 
+void SBCCallRegistry::updateCallId(const string& ltag, const string& new_callid) {
+  registry_mutex.lock();
+
+  std::map<string, SBCCallRegistryEntry>::iterator it = registry.find(ltag);
+  if (it != registry.end()) {
+    it->second.callid = new_callid;
+  }
+
+  registry_mutex.unlock();
+
+  DBG("SBCCallRegistry: Updated call '%s' - callid to: '%s'\n", ltag.c_str(), new_callid.c_str());
+}
+
 bool SBCCallRegistry::lookupCall(const string& ltag, SBCCallRegistryEntry& other_dlg) {
   bool res = false;
 

apps/sbc/SBCCallRegistry.h

@@ -54,6 +54,7 @@ class SBCCallRegistry
 
   static void addCall(const string& ltag, const SBCCallRegistryEntry& other_dlg);
   static void updateCall(const string& ltag, const string& other_rtag);
+  static void updateCallId(const string& ltag, const string& new_callid);
   static bool lookupCall(const string& ltag, SBCCallRegistryEntry& other_dlg);
   static void removeCall(const string& ltag);
 };