Fix compilation warnings across the codebase

- Replace deprecated sprintf() with snprintf() in arg_conversion,
  SyslogCDR, AnswerMachine, XmlRpcClient, XmlRpcServer, and AmUtils
- Remove deprecated 'register' storage class specifier in AmSdp,
  AmUriParser, and parse_100rel
- Add virtual destructor to SBCEventLogHandler (polymorphic base class)
- Fix string literal pointer arithmetic with array subscript in
  parse_header for C++ standard compliance
- Guard #pragma GCC diagnostic for -Wclass-memaccess (GCC-only) in
  sip_parser_async.h to avoid warnings on Clang
- Fix integer overflow in MuxStreamQueue stream_id loop
  (AmRtpMuxStream)
- Conditionally add MacPorts paths on Darwin only if they exist
- Set CMAKE_CXX_STANDARD to C++11 in CMakeLists.txt

Author: Marcel Hecko

CMakeLists.txt

@@ -7,6 +7,9 @@ set(CMAKE_MODULE_PATH "${CMAKE_SOURCE_DIR}/cmake" ${CMAKE_MODULE_PATH})
 
 project(SEMS)
 
+set(CMAKE_CXX_STANDARD 11)
+set(CMAKE_CXX_STANDARD_REQUIRED ON)
+
 # Read the version from the VERSION file
 execute_process(
   COMMAND cat "${CMAKE_SOURCE_DIR}/VERSION"
@@ -347,8 +350,12 @@ if(${CMAKE_SYSTEM_NAME} STREQUAL SunOS)
 endif(${CMAKE_SYSTEM_NAME} STREQUAL SunOS)
 
 if(${CMAKE_SYSTEM_NAME} STREQUAL Darwin)
-  include_directories(/opt/local/include)
-  link_directories(/opt/local/lib)
+  if(EXISTS /opt/local/include)
+    include_directories(/opt/local/include)
+  endif()
+  if(EXISTS /opt/local/lib)
+    link_directories(/opt/local/lib)
+  endif()
   set(CMAKE_C_FLAGS
       "${CMAKE_C_FLAGS} -fno-common -DBSD44SOCKETS -D__DARWIN_UNIX03")
   set(CMAKE_CXX_FLAGS

apps/sbc/SBCEventLog.h

@@ -40,7 +40,8 @@ using std::map;
 
 struct SBCEventLogHandler
 {
-  virtual void logEvent(long int timestamp, const string& id, 
+  virtual ~SBCEventLogHandler() {}
+  virtual void logEvent(long int timestamp, const string& id,
 			const string& type, const AmArg& ev)=0;
 };
 

apps/sbc/arg_conversion.cpp

@@ -17,23 +17,23 @@ static string arg2string(const AmArg &a)
   switch (a.getType()) {
     case AmArg::CStr:
       p = a.asCStr();
-      sprintf(tmp, "%c%zd/", CSTR_LABEL, strlen(p));
+      snprintf(tmp, sizeof(tmp), "%c%zd/", CSTR_LABEL, strlen(p));
       s = tmp;
       s += p;
       return s;
 
     case AmArg::Array:
-      sprintf(tmp, "%c%zd/", ARRAY_LABEL, a.size());
+      snprintf(tmp, sizeof(tmp), "%c%zd/", ARRAY_LABEL, a.size());
       s = tmp;
       for (size_t i = 0; i < a.size(); i ++) s += arg2string(a[i]);
       return s;
 
     case AmArg::Struct:
-      sprintf(tmp, "%c%zd/", STRUCT_LABEL, a.size());
+      snprintf(tmp, sizeof(tmp), "%c%zd/", STRUCT_LABEL, a.size());
       s = tmp;
       for (AmArg::ValueStruct::const_iterator it = a.asStruct()->begin();
            it != a.asStruct()->end(); ++it) {
-        sprintf(tmp, "%zd/", it->first.size());
+        snprintf(tmp, sizeof(tmp), "%zd/", it->first.size());
         s += tmp;
         s += it->first;
         s += arg2string(it->second);

apps/sbc/call_control/syslog_cdr/SyslogCDR.cpp

@@ -168,7 +168,7 @@ string timeString(time_t tv_sec) {
   struct tm tmp;
   if (!localtime_r(&tv_sec, &tmp) || strftime(outstr, sizeof(outstr), "%F %T", &tmp) == 0) {
     ERROR("converting time\n");
-    sprintf(outstr, "<unknown>");
+    snprintf(outstr, sizeof(outstr), "<unknown>");
   }
   return string(outstr);
 }

apps/voicemail/AnswerMachine.cpp

@@ -886,7 +886,7 @@ void AnswerMachineDialog::onSessionStart()
   setInOut(&playlist,&playlist);
 
   char now[15];
-  sprintf(now, "%d", (int) time(NULL));
+  snprintf(now, sizeof(now), "%d", (int) time(NULL));
   email_dict["ts"] = now;
 
   AmSession::onSessionStart();

apps/xmlrpc2di/xmlrpc++/src/XmlRpcClient.cpp

@@ -349,7 +349,7 @@ XmlRpcClient::generateHeader(std::string const& body)
   header += _host;
 
   char buff[40];
-  sprintf(buff,":%d\r\n", _port);
+  snprintf(buff, sizeof(buff), ":%d\r\n", _port);
 
   header += buff;
 
@@ -383,7 +383,7 @@ XmlRpcClient::generateHeader(std::string const& body)
 
   header += "Content-Type: text/xml\r\nContent-length: ";
 
-  sprintf(buff,"%zd\r\n\r\n", body.size());
+  snprintf(buff, sizeof(buff), "%zd\r\n\r\n", body.size());
 
   return header + buff;
 }

apps/xmlrpc2di/xmlrpc++/src/XmlRpcServer.cpp

@@ -470,7 +470,7 @@ XmlRpcServer::generateHeader(std::string const& body)
     "Content-length: ";
 
   char buffLen[40];
-  sprintf(buffLen,"%zd\r\n\r\n", body.size());
+  snprintf(buffLen, sizeof(buffLen), "%zd\r\n\r\n", body.size());
 
   return header + buffLen;
 }

core/AmRtpMuxStream.cpp

@@ -255,11 +255,13 @@ int MuxStreamQueue::send(unsigned char* buffer, unsigned int b_size,
   map<unsigned short, unsigned char>::iterator mux_id_it = stream_ids.find(rtp_dst_port);
   if (mux_id_it == stream_ids.end()) {
     // set up a new stream_id for port rtp_dst_port
-    for (stream_id=0;stream_id<=256;stream_id++) {
-      if (streamstates.find(stream_id)==streamstates.end())
+    unsigned int sid;
+    for (sid=0;sid<=255;sid++) {
+      if (streamstates.find((unsigned char)sid)==streamstates.end())
 	break;
     }
-    if (stream_id==256) {
+    stream_id = (unsigned char)sid;
+    if (sid>255) {
       ERROR("trying to send more than 256 streams on RTP MUX connection to  %s:%u\n", remote_ip.c_str(), remote_port);
       // or: find the oldest stream and overwrite that one
       return -1;

core/AmSdp.cpp

@@ -570,7 +570,7 @@ static bool parse_sdp_line_ex(AmSdp* sdp_msg, char*& s)
   if (!s) return true; // SDP can't be empty, return error (true really used for failure?)
 
   char* next=0; size_t line_len = 0;
-  register parse_st state;
+  parse_st state;
   //default state
   state=SDP_DESCR;
   DBG("parsing SDP message...\n");
@@ -745,7 +745,7 @@ static char* parse_sdp_connection(AmSdp* sdp_msg, char* s, char t)
     return next_line;
   }
 
-  register sdp_connection_st state;
+  sdp_connection_st state;
   state = NET_TYPE;
 
   //DBG("parse_sdp_line_ex: parse_sdp_connection: parsing sdp connection\n");
@@ -821,7 +821,7 @@ static void parse_sdp_media(AmSdp* sdp_msg, char* s)
 {
   SdpMedia m;
 
-  register sdp_media_st state;
+  sdp_media_st state;
   state = MEDIA;
   int parsing = 1;
   char* media_line=s;
@@ -999,8 +999,8 @@ static char* parse_sdp_attr(AmSdp* sdp_msg, char* s)
 
   SdpPayload payload;
 
-  register sdp_attr_rtpmap_st rtpmap_st;
-  register sdp_attr_fmtp_st fmtp_st;
+  sdp_attr_rtpmap_st rtpmap_st;
+  sdp_attr_fmtp_st fmtp_st;
   rtpmap_st = TYPE;
   fmtp_st = FORMAT;
   char* attr_line=s;
@@ -1209,7 +1209,7 @@ static void parse_sdp_origin(AmSdp* sdp_msg, char* s)
   size_t line_len=0;
   line_end = skip_till_next_line(s, line_len);
 
-  register sdp_origin_st origin_st;
+  sdp_origin_st origin_st;
   origin_st = USER;
   int parsing = 1;
 

core/AmUriParser.cpp

@@ -90,7 +90,7 @@ static inline int skip_uri(const string& s, unsigned int pos)
   unsigned int len = s.length() - pos;
   unsigned int p = pos;
 
-  register int st = ST1;
+  int st = ST1;
 
   while(len) {
     switch(s[p]) {