Playing with PR #7751 with Twirl support

[pkolyvas]

I noticed that PR #7751 (a work in progress) enabled Twirl template support. This is very exciting.

I wanted to test it out with the idea that perhaps I could be of service getting it over the line. I didnt' want to pollute the PR by commenting there but if you're willing @ajafri2001, I'll take a look. I'd even offer to maintain it, if you were unable. I've got a bit of learning curve ahead of me though, so I'm currently working on getting it running and testing it out.

I have a few questions about next steps (both in terms of the offer and the code itself) if you're into it.

[tgodzik]

I think it was mostly ready and @ajafri2001 forgot about it 😅

@ajafri2001 would it be possible for you to finish it or should I or @pkolyvas pick it up across the finish line?

[ajafri2001]

Hello, my bad, sorry for the delay 😮‍💨, I was hoping to get it merged along with lsp and highlight support for the .routes files, but that part didn't end up going anywhere (yet).

I somehow only kept remembering about the pr when I was busy with other stuff, and not when I actually did have the free time smh 😑.

You’re definitely welcome to work on the PR, or even just review it and point out anything that’s weird or not working as it should.

I’m also very happy to pick it back up myself (now that I'm here), so either way works.

[ajafri2001]

Please let me know if you’d like me to finish it. In particular, if you’re using play and would like this functionality asap, I can wrap it up quickly.

[pkolyvas]

Hello, my bad, sorry for the delay 😮‍💨, I was hoping to get it merged along with lsp and highlight support for the .routes files, but that part didn't end up going anywhere (yet).

No need to apologize at all, and I hope I didn't add any pressure of my own. I'm incredibly grateful you got it this far. I wouldn't have been able to.

I've been trying to find a way to get involved and this felt like the right combination of "right sized to learn without being overwhelmed" and "personally useful".

I've started to poke through the code (I cloned your PR and rebased it to main) to get a feel for everything, and just learning about metals & LSP underpinnings.

As far as picking it up please don't rush or spend time on it on my account. It will take me a little while in-between work to get comfortable with the codebase and building/using it anyway, so I unfortunately won't be helpful yet for a bit. At a minimum, I'd be happy to help maintain this particularly piece of code so it doesn't always fall on you.

You're right to ask if I'm using Play pretty heavily - very much so - but I've gotten by for a long time using Twirl templates with HTML5 syntax highlighting so there's no rush. It's been a valuable way to be forced to learn to write working Scala without any help from my IDE.

[ajafri2001]

I'm incredibly grateful you got it this far. I wouldn't have been able to.

Oh thank you. I was very, very lucky, I implemented this particular piece of functionality for a gsoc project under @tgodzik's mentorship. It definitely wouldn't have been possible without him, as we had pair programming sessions nearly every week for 4 months. I still have got a long way to go but I have massively improved since then.

I've started to poke through the code (I cloned your PR and rebased it to main) to get a feel for everything, and just learning about metals & LSP underpinnings.

Oh, you also need metals to recognize .scala.html files. You can add the following to your extension's package.json file. (It will get merged later scalameta/metals-vscode#1747).

{
        "id": "scala",
        "extensions": [
          ".scala.html"
        ]
}

Some info on the gist of how this works and also setting this up are incidentally here. https://ajafri2001.github.io/gsoc/week1/ (the blog is now abandoned😅)

After that, sbt publishLocal on the branch and using the newly published version in the metals extension settings. Then the functionality should work. (For more info you can go here https://scalameta.org/metals/docs/contributors/getting-started#visual-studio-code)

I think that should be enough for it to work and see basic hover/gotodefinition work. If you are stuck anywhere, please don't hesitate to ask for help.

IIRC, there were some minor bug-fixing/improvements/polishing that needed to be done (I think there are some hardcoded string paths), I also don't remember all the details as of yet😅 , but I'll try and hopefully document them in the pr as comments after testing.

[pkolyvas]

More gratitude for all this, will pour over it over the next few days. Thank you!