[Bug] Crash when image is too small

[kaii-lb]

If the image is small enough (i tested with a 172x39) image, the library will crash with a
java.lang.RuntimeException: Canvas: trying to draw too large(106754160bytes) bitmap. exception.

which seems weird since the image is literally too small to ever fill up the canvas, and the library is handling 8k images just fine.

A work around is using .downsample(DownsampleStrategy.FIT_CENTER) on the glide request builder, which will upscale the image to the device resolution.

here's a snippet of the error log:

12-28 23:08:18.324 25419 25419 E AndroidRuntime: java.lang.RuntimeException: Canvas: trying to draw too large(106754160bytes) bitmap.
12-28 23:08:18.324 25419 25419 E AndroidRuntime: 	at android.graphics.RecordingCanvas.throwIfCannotDraw(RecordingCanvas.java:266)
12-28 23:08:18.324 25419 25419 E AndroidRuntime: 	at android.graphics.BaseRecordingCanvas.drawBitmap(BaseRecordingCanvas.java:94)
12-28 23:08:18.324 25419 25419 E AndroidRuntime: 	at androidx.compose.ui.graphics.AndroidCanvas.drawImageRect-HPBpro0(AndroidCanvas.android.kt:228)
12-28 23:08:18.324 25419 25419 E AndroidRuntime: 	at androidx.compose.ui.graphics.drawscope.CanvasDrawScope.drawImage-AZ2fEMs(CanvasDrawScope.kt:262)
12-28 23:08:18.324 25419 25419 E AndroidRuntime: 	at androidx.compose.ui.node.LayoutNodeDrawScope.drawImage-AZ2fEMs(Unknown Source:24)
12-28 23:08:18.324 25419 25419 E AndroidRuntime: 	at androidx.compose.ui.graphics.drawscope.DrawScope.drawImage-AZ2fEMs$default(DrawScope.kt:555)
12-28 23:08:18.324 25419 25419 E AndroidRuntime: 	at androidx.compose.ui.graphics.painter.BitmapPainter.onDraw(BitmapPainter.kt:89)
12-28 23:08:18.324 25419 25419 E AndroidRuntime: 	at androidx.compose.ui.graphics.painter.Painter.draw-x_KDEd0(Painter.kt:192)
12-28 23:08:18.324 25419 25419 E AndroidRuntime: 	at me.saket.telephoto.subsamplingimage.SubSamplingImageKt.drawImageTile(SubSamplingImage.kt:122)
12-28 23:08:18.324 25419 25419 E AndroidRuntime: 	at me.saket.telephoto.subsamplingimage.SubSamplingImageKt.access$drawImageTile(SubSamplingImage.kt:1)
12-28 23:08:18.324 25419 25419 E AndroidRuntime: 	at me.saket.telephoto.subsamplingimage.SubSamplingImageKt$SubSamplingImage$onDraw$1$1.invoke(SubSamplingImage.kt:61)
12-28 23:08:18.324 25419 25419 E AndroidRuntime: 	at me.saket.telephoto.subsamplingimage.SubSamplingImageKt$SubSamplingImage$onDraw$1$1.invoke(SubSamplingImage.kt:58)

[saket]

Yea that's odd. Can you share a snippet of your code?

[kaii-lb]

sure, here's the related code. as it is right now it works with the aforementioned downsample option.

edit: i skimmed the code rq, havent tested anything yet but it could be this line?
like the initial scale is so large since the image is so small so it can't be drawn anm?

[saket]

I spent some time investigating this, but wasn't able to reproduce the crash on an API 36 emulator. I've set up a minimal reproducer here: kaii-lb/LavenderPhotos@main...saket:LavenderPhotos:saket/jan5/tiny-image-crash

Can you update this branch until it reproduces the crash on your device? Additionally, can you also share the device model and Android version where you're seeing this?

[kaii-lb]

couldn't get it to crash with your code, but if i revert to mine:

crash on first device, switched devices, didn't crash on second device.

gonna go ahead and say its a device specific issue-? i noticed that if i change the "available image area" a bit, the crashes become unpredictable.
ie: removed topbar/bottombar and its not longer consistent.

devices:

• Tecno LH7n Android 14 (only crashes here)
• Samsung A06 Android 14

[saket]

couldn't get it to crash with your code, but if i revert to mine:

Did you forget to paste a link here? Or by "revert" did you mean switching back to using MainActivity on the Tecno device?

[kaii-lb]

switching back to using MainActivity on the Tecno device

yes that's what i meant, just using the exact code in your branch but with MainActivity

i tried using HorizontalImageList in the test activity, wouldn't crash on either device, nor my API 36 emualtor, tho i didn't have time to try the "available image area" thing there

[kaii-lb]

gonna close this as non-reproducible, thanks for the effort!

[saket]

Yeah, sorry about that! There might be a real bug in my code, but it's hard to investigate if I can't reproduce it. I'll try again with AI at some point to see if it has any ideas.

Edit: I'll keep this issue open for now.

[kaii-lb]

i'll try again as well when i have time

thank you for your efforts!