riscv64: RISC-V target fails clippy UI test cognitive_complexity.rs

[yuzibo]

Our riscv64 CI captured the case failed:

...
Running tests/compile-test.rs (build/riscv64gc-unknown-linux-gnu/stage2-tools/riscv64gc-unknown-linux-gnu/release/deps/compile_test-d9361c1d4405b526)
...
tests/ui/non_std_lazy_static/non_std_lazy_static_fixable.fixed ... ok

FAILED TEST: tests/ui/cognitive_complexity.rs
command: CLIPPY_CONF_DIR="tests" RUSTC_ICE="0" "/home/jenkins/rust/build/riscv64gc-unknown-linux-gnu/stage2-tools/riscv64gc-unknown-linux-gnu/release/clippy-driver" "--error-format=json" "--emit=metadata" "-Aunused" "-Ainternal_features" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Dwarnings" "-Ldependency=/home/jenkins/rust/build/riscv64gc-unknown-linux-gnu/stage2-tools/release/deps" "--sysroot=/home/jenkins/rust/build/riscv64gc-unknown-linux-gnu/stage2" "--test" "--out-dir" "/home/jenkins/rust/build/riscv64gc-unknown-linux-gnu/stage2-tools/ui_test/0/tests/ui" "tests/ui/cognitive_complexity.rs" "--extern" "futures=/home/jenkins/rust/build/riscv64gc-unknown-linux-gnu/stage2-tools/riscv64gc-unknown-linux-gnu/debug/deps/libfutures-acd5ebb8ddb3cbe8.rlib" "--extern" "futures=/home/jenkins/rust/build/riscv64gc-unknown-linux-gnu/stage2-tools/riscv64gc-unknown-linux-gnu/debug/deps/libfutures-acd5ebb8ddb3cbe8.rmeta" "--extern" "itertools=/home/jenkins/rust/build/riscv64gc-unknown-linux-gnu/stage2-tools/riscv64gc-unknown-linux-gnu/debug/deps/libitertools-13c299e3d66d3148.rlib" "--extern" "itertools=/home/jenkins/rust/build/riscv64gc-unknown-linux-gnu/stage2-tools/riscv64gc-unknown-linux-gnu/debug/deps/libitertools-13c299e3d66d3148.rmeta" "--extern" "libc=/home/jenkins/rust/build/riscv64gc-unknown-linux-gnu/stage2-tools/riscv64gc-unknown-linux-gnu/debug/deps/liblibc-17e7a0512d686c9a.rlib" "--extern" "libc=/home/jenkins/rust/build/riscv64gc-unknown-linux-gnu/stage2-tools/riscv64gc-unknown-linux-gnu/debug/deps/liblibc-17e7a0512d686c9a.rmeta" "--extern" "parking_lot=/home/jenkins/rust/build/riscv64gc-unknown-linux-gnu/stage2-tools/riscv64gc-unknown-linux-gnu/debug/deps/libparking_lot-c89891ce3e52ccb9.rlib" "--extern" "parking_lot=/home/jenkins/rust/build/riscv64gc-unknown-linux-gnu/stage2-tools/riscv64gc-unknown-linux-gnu/debug/deps/libparking_lot-c89891ce3e52ccb9.rmeta" "--extern" "quote=/home/jenkins/rust/build/riscv64gc-unknown-linux-gnu/stage2-tools/riscv64gc-unknown-linux-gnu/debug/deps/libquote-5c82febc8bf17459.rlib" "--extern" "quote=/home/jenkins/rust/build/riscv64gc-unknown-linux-gnu/stage2-tools/riscv64gc-unknown-linux-gnu/debug/deps/libquote-5c82febc8bf17459.rmeta" "--extern" "regex=/home/jenkins/rust/build/riscv64gc-unknown-linux-gnu/stage2-tools/riscv64gc-unknown-linux-gnu/debug/deps/libregex-d6f903b8f4281fb4.rlib" "--extern" "regex=/home/jenkins/rust/build/riscv64gc-unknown-linux-gnu/stage2-tools/riscv64gc-unknown-linux-gnu/debug/deps/libregex-d6f903b8f4281fb4.rmeta" "--extern" "serde=/home/jenkins/rust/build/riscv64gc-unknown-linux-gnu/stage2-tools/riscv64gc-unknown-linux-gnu/debug/deps/libserde-975e2048162f6620.rlib" "--extern" "serde=/home/jenkins/rust/build/riscv64gc-unknown-linux-gnu/stage2-tools/riscv64gc-unknown-linux-gnu/debug/deps/libserde-975e2048162f6620.rmeta" "--extern" "syn=/home/jenkins/rust/build/riscv64gc-unknown-linux-gnu/stage2-tools/riscv64gc-unknown-linux-gnu/debug/deps/libsyn-88f1b6731ac69b79.rlib" "--extern" "syn=/home/jenkins/rust/build/riscv64gc-unknown-linux-gnu/stage2-tools/riscv64gc-unknown-linux-gnu/debug/deps/libsyn-88f1b6731ac69b79.rmeta" "--extern" "tokio=/home/jenkins/rust/build/riscv64gc-unknown-linux-gnu/stage2-tools/riscv64gc-unknown-linux-gnu/debug/deps/libtokio-14d21f69bc8ffe1c.rlib" "--extern" "tokio=/home/jenkins/rust/build/riscv64gc-unknown-linux-gnu/stage2-tools/riscv64gc-unknown-linux-gnu/debug/deps/libtokio-14d21f69bc8ffe1c.rmeta" "-L" "/home/jenkins/rust/build/riscv64gc-unknown-linux-gnu/stage2-tools/debug/deps" "-L" "/home/jenkins/rust/build/riscv64gc-unknown-linux-gnu/stage2-tools/riscv64gc-unknown-linux-gnu/debug/deps" "--edition" "2024"

error: actual output differed from expected
Execute `./x test src/tools/clippy --bless` to update `tests/ui/cognitive_complexity.stderr` to the actual output
--- tests/ui/cognitive_complexity.stderr
+++ <stderr output>
 error: the function has a cognitive complexity of (28/25)
   --> tests/ui/cognitive_complexity.rs:11:4
... 15 lines skipped ...
 
 error: the function has a cognitive complexity of (2/1)
+  --> tests/ui/cognitive_complexity.rs:121:4

see the log

[workingjubilee]

@yuzibo

1. please do not just dump a log on us, because a log is not a bug report
2. if you must dump a log on us, please do not dump one remotely hosted on us, as they often get deleted, whereas at least a report actually on the issue tracker is on GitHub and thus if we lose the issue, well, we have other problems.
3. posting a log does not constitute identifying the flawed commit in the repository. the commit that the log contains is d01259be620c66b65acfa7911905416e10b70587 which does not exist in this repo.
4. posting a log can also include URLs that are only local and that I cannot access to find out more. the repo it pulls from is http://192.168.135.1:8080/rust-lang/rust-iscas-ci.git which, needless to say, I do not have access to. as a result I cannot even try to find out if that repo's flawed commit is directly based on one of ours, or if it has meaningful patches between.

[yuzibo]

@yuzibo

hi,

Thanks for your feedback.

This is my worry when I open(ed) these issues and I completely understand your frustration.

1. please do not just dump a log on us, because a log is not a bug report

In my original idea, from our CI process perspective, logs are usually the starting point for problem identification, but I understand that upstream reports need to provide more analytical information.

2. if you must dump a log on us, please do not dump one remotely hosted on us, as they often get deleted, whereas at least a report actually on the issue tracker is on GitHub and thus if we lose the issue, well, we have other problems.

Ack.

External logs are indeed fragile for issue tracking. Here I included key error snippets directly in the reports but I thought it was not enough. So I should consider some more reliable solutions if providing external link logs if necessary.

3. posting a log does not constitute identifying the flawed commit in the repository. the commit that the log contains is d01259be620c66b65acfa7911905416e10b70587 which does not exist in this repo.
4. posting a log can also include URLs that are only local and that I cannot access to find out more. the repo it pulls from is http://192.168.135.1:8080/rust-lang/rust-iscas-ci.git which, needless to say, I do not have access to. as a result I cannot even try to find out if that repo's flawed commit is directly based on one of ours, or if it has meaningful patches between.

hmm, the commit d01259 and local repo rust-iscas-ci you mention above is used for Jenkins.

• Each Jenkins job is configured for SCM polling, so every run fetches the repository fresh.
• The real HEAD sha for rust-lang/rust is f794a08738958bbef01c3dcab34ec21d3da1e51a.

You can access the page from "Started by upstream project "RustCI/CommitID" build number 76" job id 76‘s link.

Sorry I have to post more external links to explain the process here again.

[yuzibo]

For the issue, is the triggering method incorrect? I think the method is ro run ./x test --stage 2 src/tools/clippy. I will verify it again.