ci: bump min Go version to 1.23 (#1322)

Signed-off-by: Austin Vazquez <macedonv@amazon.com>

Author: austinvazquez

.github/workflows/build-and-test-msi.yaml

@@ -16,7 +16,7 @@ on:
     - cron: '0 9 * * *'
 env:
   GO111MODULE: on
-  GO_VERSION: '1.22.9'
+  GO_VERSION: '1.23.7'
 
 permissions:
   # This is required for configure-aws-credentials to request an OIDC JWT ID token to access AWS resources later on.

.github/workflows/build-pkg.yaml

@@ -26,7 +26,7 @@ permissions:
   contents: read
 
 env:
-  GO_VERSION: '1.22.9'
+  GO_VERSION: '1.23.7'
 
 jobs:
   build:

.github/workflows/ci.yaml

@@ -41,7 +41,7 @@ permissions:
 
 env:
   DEBUG: ${{ secrets.ACTIONS_STEP_DEBUG }}
-  GO_VERSION: '1.22.8'
+  GO_VERSION: '1.23.7'
 
 concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}
@@ -120,7 +120,7 @@ jobs:
           # Pin the version in case all the builds start to fail at the same time.
           # There may not be an automatic way (e.g., dependabot) to update a specific parameter of a GitHub Action,
           # so we will just update it manually whenever it makes sense (e.g., a feature that we want is added).
-          version: v1.56.1
+          version: v1.64.7
           args: --fix=false --timeout=5m
       - name: set GOOS env to darwin
         run: |
@@ -131,7 +131,7 @@ jobs:
           # Pin the version in case all the builds start to fail at the same time.
           # There may not be an automatic way (e.g., dependabot) to update a specific parameter of a GitHub Action,
           # so we will just update it manually whenever it makes sense (e.g., a feature that we want is added).
-          version: v1.56.1
+          version: v1.64.7
           args: --fix=false --timeout=5m --skip-dirs="(^|/)deps($|/)"
   shellcheck:
     name: ShellCheck

.github/workflows/e2e-linux.yaml

@@ -22,6 +22,9 @@ permissions:
   # This is required for actions/checkout
   contents: read
 
+env:
+  GO_VERSION: '1.23.7'
+
 jobs:
   test:
     runs-on:
@@ -33,12 +36,27 @@ jobs:
         "${{ inputs.runner-type }}",
       ]
     timeout-minutes: 60
+    env:
+      ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: 'true'
     outputs:
       has_creds: ${{ steps.vars.outputs.has_creds}}
       vm_report: ${{ steps.set-multiple-vars.outputs.VM_REPORT }}
       container_report: ${{ steps.set-multiple-vars.outputs.CONTAINER_REPORT }}
       vm_serial_report: ${{ steps.set-multiple-vars.outputs.VM_SERIAL_REPORT }}
     steps:
+      - name: Allow Node16 on AL2
+        if: ${{ (startsWith(inputs.os, 'amazon') && inputs.version == '2' ) }}
+        run: |
+          echo "ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true" >> $GITHUB_ENV
+          echo "ACTIONS_RUNNER_FORCE_ACTIONS_NODE_VERSION=node16" >> $GITHUB_ENV
+      - uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3.6.0
+        # Later checkout versiosn use node which doesn't run on AL2
+        if: ${{ (startsWith(inputs.os, 'amazon') && inputs.version == '2' ) }}
+        with:
+          # We need to get all the git tags to make version injection work. See VERSION in Makefile for more detail.
+          fetch-depth: 0
+          persist-credentials: false
+          submodules: recursive
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
         # checkout uses node version 20, which doesn't run on AL2
         if: ${{ ! (startsWith(inputs.os, 'amazon') && inputs.version == '2' ) }}
@@ -47,17 +65,17 @@ jobs:
           fetch-depth: 0
           persist-credentials: false
           submodules: recursive
-      - name: Check repo out manually
+      - uses: actions/setup-go@93397bea11091df50f3d7e59dc26a7711a8bcfbe # v4.1.0
+        # Later setup-go versions use node which doesn't run on AL2
         if: ${{ (startsWith(inputs.os, 'amazon') && inputs.version == '2' ) }}
-        run: |
-          git clone https://github.com/${GITHUB_REPOSITORY}.git .
-          if [ "$GITHUB_EVENT_NAME" == "pull_request" ]; then
-            git config --add remote.origin.fetch "+refs/heads/*:refs/remotes/origin/*"
-            git config --add remote.origin.fetch "+refs/tags/*:refs/tags/*"
-            git config --add remote.origin.fetch "+${GITHUB_SHA}:${GITHUB_REF}"
-          fi
-          git fetch --prune origin
-          git checkout ${GITHUB_SHA}
+        with:
+          go-version: ${{ env.GO_VERSION }}
+          cache: false
+      - uses: actions/setup-go@f111f3307d8850f501ac008e886eec1fd1932a34 # v5.3.0
+        if: ${{ ! (startsWith(inputs.os, 'amazon') && inputs.version == '2' ) }}
+        with:
+          go-version: ${{ env.GO_VERSION }}
+          cache: false
       - name: Set output variables
         id: vars
         run: |
@@ -103,10 +121,13 @@ jobs:
         run: |
           git status
           git clean -f -d
+
           # required by one of the tests which uses SSH_AUTH_SOCK
           eval "$(ssh-agent -s)"
-          INSTALLED=true REGISTRY=${{ steps.vars.outputs.has_creds == true && env.REGISTRY || '' }} sudo -E make test-e2e-container
-          INSTALLED=true REGISTRY=${{ steps.vars.outputs.has_creds == true && env.REGISTRY || '' }} sudo -E make test-e2e-vm
+
+          # Preserve path so Go from actions/setup-go is used; not the system installed golang.
+          sudo -E env "PATH=$PATH" INSTALLED=true REGISTRY=${{ steps.vars.outputs.has_creds == true && env.REGISTRY || '' }} make test-e2e-container
+          sudo -E env "PATH=$PATH" INSTALLED=true REGISTRY=${{ steps.vars.outputs.has_creds == true && env.REGISTRY || '' }} make test-e2e-vm
       - name: Change ownership of reports
         if: always()
         run: |
@@ -137,10 +158,7 @@ jobs:
         with:
           name: linux-${{ inputs.version }}-test-e2e-${{ inputs.arch }}-${{ github.run_id }}-${{ github.run_attempt }}-e2e-reports
           path: ${{ github.workspace }}/reports/${{ github.run_id }}-${{ github.run_attempt }}-*.json
-      - name: Clean up repo AL2
-        if: ${{ (startsWith(inputs.os, 'amazon') && inputs.version == '2' && always() ) }}
-        run: |
-          rm -rf "${GITHUB_WORKSPACE}"
+
   upload-e2e-test-reports:
     needs: test
     if: always()

.github/workflows/e2e-macos.yaml

@@ -23,7 +23,7 @@ permissions:
   contents: read
 
 env:
-  GO_VERSION: '1.22.9'
+  GO_VERSION: '1.23.7'
 
 jobs:
   test:

.github/workflows/e2e-windows.yaml

@@ -20,7 +20,7 @@ permissions:
   contents: read
 
 env:
-  GO_VERSION: '1.22.9'
+  GO_VERSION: '1.23.7'
 
 jobs:
   test:

.github/workflows/test-pkg.yaml

@@ -26,7 +26,7 @@ permissions:
   contents: read
 
 env:
-  GO_VERSION: '1.22.9'
+  GO_VERSION: '1.23.7'
 
 jobs:
   test:

.github/workflows/upload-build-to-S3.yaml

@@ -4,7 +4,7 @@ on:
   workflow_dispatch:
 env:
   GO111MODULE: on
-  GO_VERSION: '1.22.9'
+  GO_VERSION: '1.23.7'
 
 permissions:
   # This is required for configure-aws-credentials to request an OIDC JWT ID token to access AWS resources later on.

.golangci.yaml

@@ -24,9 +24,9 @@ linters-settings:
     checks: ["all", "-ST1003"]
 linters:
   enable:
+    - copyloopvar
     - errname
     - errorlint
-    - exportloopref
     - forcetypeassert
     - gocritic
     - godot

benchmark/benchmark.go

@@ -7,6 +7,7 @@ package benchmark
 import (
 	"flag"
 	"fmt"
+	"math/big"
 	"os"
 	"path/filepath"
 	"sync"
@@ -149,12 +150,12 @@ func measureMetrics(targetFunc func()) (Metrics, error) { //nolint:unparam // ma
 	avgCPU := sumCPU / float64(len(cpuUsage))
 	totalCPUTime := time.Since(startTime)
 
-	diskUsageDelta := int64(diskUsageBefore - diskUsageAfter)
+	diskUsageDelta := new(big.Int).SetUint64(diskUsageBefore - diskUsageAfter)
 
 	return Metrics{
 		PeakCPUUsage:    peakCPU,
 		AverageCPUUsage: avgCPU,
 		TotalCPUTime:    totalCPUTime,
-		DiskUsageDelta:  diskUsageDelta,
+		DiskUsageDelta:  diskUsageDelta.Int64(),
 	}, nil
 }